juju-core

Code review comment for lp:~thumper/juju-core/verify-storage-move

  1. verify-storage-move
  2. Merge into trunk
Revision history for this message
Andrew Wilkins (axwalk) wrote :

On 2013/10/03 03:19:01, dfc wrote:
> LGTM. Some nice boy scout work in there as well.

https://codereview.appspot.com/14279044/diff/1/environs/bootstrap/bootstrap.go
> File environs/bootstrap/bootstrap.go (right):

https://codereview.appspot.com/14279044/diff/1/environs/bootstrap/bootstrap.go#newcode92
> environs/bootstrap/bootstrap.go:92: _, err :=
 common.LoadState(env.Storage())
> this method hurt my head, but it makes sense in a double negative sort
 of way.

LGTM

https://codereview.appspot.com/14279044/

« Back to merge proposal