Code review comment for lp:~thumper/juju-core/user-display-name

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+221823_code.launchpad.net,

Message:
Please take a look.

Description:
Add a display name option for new users

This ended up being more work than I hoped as I refactored the apiserver
parts, many tests, and made sure there was backwards compatability with
older client apis.

Also changed how the CLI command was tested so it didn't need a
JujuConnSuite.

https://code.launchpad.net/~thumper/juju-core/user-display-name/+merge/221823

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/102970043/

Affected files (+353, -240 lines):
   A [revision details]
   M agent/bootstrap.go
   M cmd/juju/authorizedkeys_test.go
   M cmd/juju/user_add.go
   M cmd/juju/user_add_test.go
   M juju/conn_test.go
   M juju/testing/conn.go
   M provider/dummy/environs.go
   M state/api/params/params.go
   M state/api/usermanager/client.go
   M state/api/usermanager/client_test.go
   M state/apiserver/charms_test.go
   M state/apiserver/client/api_test.go
   M state/apiserver/client/client_test.go
   M state/apiserver/login_test.go
   M state/apiserver/usermanager/usermanager.go
   M state/apiserver/usermanager/usermanager_test.go
   M state/compat_test.go
   M state/conn_test.go
   M state/megawatcher_internal_test.go
   M state/state_test.go
   M state/user.go
   M state/user_test.go

« Back to merge proposal