Code review comment for lp:~thumper/juju-core/use-loggo

Revision history for this message
Tim Penhey (thumper) wrote :

On 03/06/13 21:21, <email address hidden> wrote:
> Just to codify it, the switch to loggo LGTM, but I think I uncovered a
> couple bugs in loggo itself. (if you do SetLoggingLevel(DEBUG) it
> actually doesn't emit logger.Debug() messages (the check is
> getEffectiveLevel() > level rather than getEffectiveLevel() >= level).

Yes it does, this is just a misunderstanding.

Tests for this are in loggo/writer_test.go

« Back to merge proposal