juju-core

Code review comment for lp:~thumper/juju-core/use-loggo

  1. use-loggo
  2. Merge into trunk
Revision history for this message
John A Meinel (jameinel) wrote :

Just to codify it, the switch to loggo LGTM, but I think I uncovered a
couple bugs in loggo itself. (if you do SetLoggingLevel(DEBUG) it
actually doesn't emit logger.Debug() messages (the check is
getEffectiveLevel() > level rather than getEffectiveLevel() >= level).

I'd like us to get some of that sorted out before then.

https://codereview.appspot.com/9738051/

« Back to merge proposal