Code review comment for lp:~thumper/juju-core/use-loggo

Revision history for this message
Frank Mueller (themue) wrote :

LGTM

https://codereview.appspot.com/9738051/diff/1/cmd/logging.go
File cmd/logging.go (right):

https://codereview.appspot.com/9738051/diff/1/cmd/logging.go#newcode26
cmd/logging.go:26: // TODO: rename verbose to --show-log
TODO for whom? Use // TODO(nick) ...

https://codereview.appspot.com/9738051/diff/1/worker/uniter/uniter_test.go
File worker/uniter/uniter_test.go (right):

https://codereview.appspot.com/9738051/diff/1/worker/uniter/uniter_test.go#newcode170
worker/uniter/uniter_test.go:170: // TODO: fix this to actually use a
log writer to catch interesting log messages.
Again // TODO(nick) ...

https://codereview.appspot.com/9738051/

« Back to merge proposal