Code review comment for lp:~thumper/juju-core/use-errgo

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/04/2014 04:33 PM, Roger Peppe wrote:
> On 4 February 2014 14:09, John A Meinel <email address hidden>
> wrote:
>>> Presumably we'll still have some replacement that does similar
>>> prechecks before letting the 'bot at it, won't we?
>>
>> I'm not sure why we would need that, rather than just having the
>> bot do whatever checks we actually care about. (And perhaps a
>> script so you can easily run them yourself?)
>
> I find it very useful because it provides a quick sanity check
> that things are OK rather than checking my email in 30 minutes only
> to find I'd forgotten to gofmt a file.

The bot already does go fmt automatically before running the test
suite, so you don't actually have to go fmt for the bot.

>
> If we *don't* need a pre-check for all the things we currently
> pre-check (gofmt, govet, go build, checktesting), then why would we
> need a test specifically for dependencies.tsv and not those?

Because we've repeatedly broken dependencies.tsv for CI but not noticed?

>
> It seems to me as if the dependencies.tsv format test falls in the
> same category as the other .lbox.check tests, and should be grouped
> accordingly.
>
> One might argue that all the .lbox.check tests should be Go tests,
> and I would probably agree, but only if our tests took an order of
> magnitude less time to run.
>

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLxABAACgkQJdeBCYSNAAMowwCfTCqU4gVWdRbdctezwkH7O4zH
BTgAoJn7zDnpOha3d/eSn0mvjAT0jPo/
=jyiJ
-----END PGP SIGNATURE-----