Code review comment for lp:~thumper/juju-core/use-errgo

Revision history for this message
Roger Peppe (rogpeppe) wrote :

https://codereview.appspot.com/59930043/diff/1/dependencies_test.go
File dependencies_test.go (right):

https://codereview.appspot.com/59930043/diff/1/dependencies_test.go#newcode30
dependencies_test.go:30: func (*dependenciesTest)
TestDependenciesTsvFormat(c *gc.C) {
I think this would work work better as a test in .lbox.check.
There is no package in the root directory and this doesn't really seem
like a great reason to create one.

awk -F "\t" 'NF != 4 {exit 1}' || {
     echo dependencies.tsv is in an invalid format >&2
     exit 1
}

would do the job.

https://codereview.appspot.com/59930043/

« Back to merge proposal