This CL should give some context: https://codereview.appspot.com/10043045/
On 10 June 2013 09:28, John A Meinel <email address hidden> wrote: > You didn't really summarize what the changes are. I'm guessing it is > mostly changing names from "Info" to "Infof" to follow the common idiom > that things which take a format + args end in an extra 'f'. (printf, > etc). > > I think I'm fine with that, but I haven't seen it discussed. > > LGTM > > > https://codereview.appspot.com/10125046/ > > -- > https://code.launchpad.net/~thumper/juju-core/update-loggo/+merge/168342 > Your team juju hackers is requested to review the proposed merge of lp:~thumper/juju-core/update-loggo into lp:juju-core.
« Back to merge proposal
This CL should give some context: https:/ /codereview. appspot. com/10043045/
On 10 June 2013 09:28, John A Meinel <email address hidden> wrote: /codereview. appspot. com/10125046/ /code.launchpad .net/~thumper/ juju-core/ update- loggo/+ merge/168342
> You didn't really summarize what the changes are. I'm guessing it is
> mostly changing names from "Info" to "Infof" to follow the common idiom
> that things which take a format + args end in an extra 'f'. (printf,
> etc).
>
> I think I'm fine with that, but I haven't seen it discussed.
>
> LGTM
>
>
> https:/
>
> --
> https:/
> Your team juju hackers is requested to review the proposed merge of lp:~thumper/juju-core/update-loggo into lp:juju-core.