https://codereview.appspot.com/41470043/diff/1/worker/uniter/uniter_test.go#newcode853
worker/uniter/uniter_test.go:853: runCommands{fmt.Sprintf("echo juju run
${JUJU_UNIT_NAME} > %s", filepath.Join(testDir, "run.output"))},
On 2013/12/13 00:47:04, wallyworld wrote:
> There's a lot of duplicated filepath.Join(testDir, "run.output").
> Can we not just create a generic file at the top of the method and
reuse that?
> Assuming it is cleaned up after each test which we can add if it is
not done
> yet.
Please take a look.
https:/ /codereview. appspot. com/41470043/ diff/1/ worker/ uniter/ uniter_ test.go uniter/ uniter_ test.go (right):
File worker/
https:/ /codereview. appspot. com/41470043/ diff/1/ worker/ uniter/ uniter_ test.go# newcode853 uniter/ uniter_ test.go: 853: runCommands{ fmt.Sprintf( "echo juju run Join(testDir, "run.output"))}, Join(testDir, "run.output").
worker/
${JUJU_UNIT_NAME} > %s", filepath.
On 2013/12/13 00:47:04, wallyworld wrote:
> There's a lot of duplicated filepath.
> Can we not just create a generic file at the top of the method and
reuse that?
> Assuming it is cleaned up after each test which we can add if it is
not done
> yet.
Added some magic to reduce duplication.
https:/ /codereview. appspot. com/41470043/