Code review comment for lp:~thumper/juju-core/uniter-run-commands

Revision history for this message
Ian Booth (wallyworld) wrote :

LGTM with some tweaks

https://codereview.appspot.com/41470043/diff/1/worker/uniter/uniter_test.go
File worker/uniter/uniter_test.go (right):

https://codereview.appspot.com/41470043/diff/1/worker/uniter/uniter_test.go#newcode853
worker/uniter/uniter_test.go:853: runCommands{fmt.Sprintf("echo juju run
${JUJU_UNIT_NAME} > %s", filepath.Join(testDir, "run.output"))},
There's a lot of duplicated filepath.Join(testDir, "run.output").
Can we not just create a generic file at the top of the method and reuse
that? Assuming it is cleaned up after each test which we can add if it
is not done yet.

https://codereview.appspot.com/41470043/

« Back to merge proposal