Code review comment for lp:~thumper/juju-core/uniter-context-run-commands

Revision history for this message
Ian Booth (wallyworld) wrote :

LGTM with a couple of fixes

https://codereview.appspot.com/40370047/diff/1/worker/uniter/context.go
File worker/uniter/context.go (right):

https://codereview.appspot.com/40370047/diff/1/worker/uniter/context.go#newcode214
worker/uniter/context.go:214: // into ctx to execute jujuc tools.
Doc string is out of date

https://codereview.appspot.com/40370047/diff/1/worker/uniter/context_test.go
File worker/uniter/context_test.go (right):

https://codereview.appspot.com/40370047/diff/1/worker/uniter/context_test.go#newcode733
worker/uniter/context_test.go:733: func (s *RunCommandSuite)
GetHookContext(c *gc.C) *uniter.HookContext {
this doesn't need to be exported

https://codereview.appspot.com/40370047/

« Back to merge proposal