Code review comment for lp:~thumper/juju-core/testbase

Revision history for this message
Andrew Wilkins (axwalk) wrote :

LGTM, just one question about dependencies.

https://codereview.appspot.com/13694046/diff/1/testing/testbase/package_test.go
File testing/testbase/package_test.go (right):

https://codereview.appspot.com/13694046/diff/1/testing/testbase/package_test.go#newcode23
testing/testbase/package_test.go:23: // This test is to ensure we don't
bring in any juju-core dependencies.
Glad to have this here. Is it okay for testbase to import
testing/checkers?

https://codereview.appspot.com/13694046/

« Back to merge proposal