LGTM, just one question about dependencies.
https://codereview.appspot.com/13694046/diff/1/testing/testbase/package_test.go File testing/testbase/package_test.go (right):
https://codereview.appspot.com/13694046/diff/1/testing/testbase/package_test.go#newcode23 testing/testbase/package_test.go:23: // This test is to ensure we don't bring in any juju-core dependencies. Glad to have this here. Is it okay for testbase to import testing/checkers?
https://codereview.appspot.com/13694046/
« Back to merge proposal
LGTM, just one question about dependencies.
https:/ /codereview. appspot. com/13694046/ diff/1/ testing/ testbase/ package_ test.go testbase/ package_ test.go (right):
File testing/
https:/ /codereview. appspot. com/13694046/ diff/1/ testing/ testbase/ package_ test.go# newcode23 testbase/ package_ test.go: 23: // This test is to ensure we don't
testing/
bring in any juju-core dependencies.
Glad to have this here. Is it okay for testbase to import
testing/checkers?
https:/ /codereview. appspot. com/13694046/