Code review comment for lp:~thumper/juju-core/system-ssh-key
Revision history for this message
| Roger Peppe (rogpeppe) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
https:/
File provider/
https:/
provider/
system key: %v", err)
On 2013/12/19 22:16:11, thumper wrote:
> On 2013/12/19 01:50:05, axw wrote:
> > I'm told the errors should be worded like "creating system key", so
it ends up
> > as
> > error: creating system key: <thing>
> >
> > (I've traditionally done it the same way as you have here, mind.)
> I'd say that this is dumb.
I agree with both of you here. I think it's good if the error message
still makes sense even when the subsidiary error after the colon is
removed.
https:/
File doc/system-
https:/
doc/system-
to the mongo database. It was an
Strictly speaking it creates a private key for *serving* the mongo
database and the API server.
https:/
doc/system-
robust idea.
I'd like a less hand-wavy justification than this.
Every extra secret lying around is another potential system
vulnerability.
On the other hand, if there *is* a good reason for using different keys
for different purposes, perhaps we should consider using different keys
for serving the API server and for the mongo server.
https:/
File environs/
https:/
environs/
string, privateKey string) error {
We're creating an entire new package for a single constant and a
function that's semantically almost identical to ioutil.WriteFile?
Please let's just define SystemIdentityF
and call WriteFile directly inside provider/local, the only caller.
https:/
environs/
identity: %v", err)
If we've got an error return, please return the more informative error
rather than logging it. The error should be logged later at a higher
level.
https:/