LGTM, thanks. One suggestion below.
https://codereview.appspot.com/39150045/diff/10004/cmd/args_test.go File cmd/args_test.go (right):
https://codereview.appspot.com/39150045/diff/10004/cmd/args_test.go#newcode21 cmd/args_test.go:21: func (*ArgsSuite) TestNewStringsValue(c *gc.C) { It'd be quite nice to see at least one test that tests it as it is intended to be used (in a FlagSet). ISTM that this test could be easily adapted to do that.
https://codereview.appspot.com/39150045/
« Back to merge proposal
LGTM, thanks.
One suggestion below.
https:/ /codereview. appspot. com/39150045/ diff/10004/ cmd/args_ test.go
File cmd/args_test.go (right):
https:/ /codereview. appspot. com/39150045/ diff/10004/ cmd/args_ test.go# newcode21 test.go: 21: func (*ArgsSuite) TestNewStringsV alue(c *gc.C) {
cmd/args_
It'd be quite nice to see at least one test that tests it as it is
intended to be used (in a FlagSet). ISTM that this test could be easily
adapted to do that.
https:/ /codereview. appspot. com/39150045/