Code review comment for lp:~thumper/juju-core/ssh-run-on-remote

Revision history for this message
Andrew Wilkins (axwalk) wrote :

LGTM

https://codereview.appspot.com/49940045/diff/1/utils/ssh/run.go
File utils/ssh/run.go (right):

https://codereview.appspot.com/49940045/diff/1/utils/ssh/run.go#newcode67
utils/ssh/run.go:67: status :=
ee.ProcessState.Sys().(syscall.WaitStatus)
On 2014/01/10 01:57:15, thumper wrote:
> On 2014/01/10 01:23:58, axw wrote:
> > This is not going to work on the Windows CLI, is it?
> >
> > You can use ee.ProcessState.Exited(), but I don't think there's a
> > platform-independent way of getting the exit status. A helper may be
in order.

> Perhaps, but the CLI isn't doing this, the apiserver is.

Ah yes, I misunderstood the point of this. Never mind then.

https://codereview.appspot.com/49940045/

« Back to merge proposal