Code review comment for lp:~thumper/juju-core/run-cmd-refactor

The attempt to merge lp:~thumper/juju-core/run-cmd-refactor into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 1.265s
ok launchpad.net/juju-core/agent/tools 0.249s
ok launchpad.net/juju-core/bzr 7.326s
ok launchpad.net/juju-core/cert 3.417s
ok launchpad.net/juju-core/charm 0.566s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.037s
ok launchpad.net/juju-core/cloudinit/sshinit 1.049s
ok launchpad.net/juju-core/cmd 0.253s
ok launchpad.net/juju-core/cmd/charm-admin 0.807s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 190.068s
ok launchpad.net/juju-core/cmd/jujud 60.586s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 3.131s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/constraints 0.028s
ok launchpad.net/juju-core/container 0.040s
ok launchpad.net/juju-core/container/factory 0.074s
ok launchpad.net/juju-core/container/kvm 0.289s
ok launchpad.net/juju-core/container/kvm/mock 0.048s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 0.403s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.313s
ok launchpad.net/juju-core/environs 3.072s
ok launchpad.net/juju-core/environs/bootstrap 4.542s
ok launchpad.net/juju-core/environs/cloudinit 0.575s
ok launchpad.net/juju-core/environs/config 1.072s
ok launchpad.net/juju-core/environs/configstore 0.061s
ok launchpad.net/juju-core/environs/filestorage 0.033s
ok launchpad.net/juju-core/environs/httpstorage 1.070s
ok launchpad.net/juju-core/environs/imagemetadata 0.531s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.055s
ok launchpad.net/juju-core/environs/jujutest 0.210s
ok launchpad.net/juju-core/environs/manual 12.561s
ok launchpad.net/juju-core/environs/simplestreams 0.337s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 1.257s
ok launchpad.net/juju-core/environs/storage 1.163s
ok launchpad.net/juju-core/environs/sync 32.002s
ok launchpad.net/juju-core/environs/testing 0.203s
ok launchpad.net/juju-core/environs/tools 6.948s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.016s
ok launchpad.net/juju-core/instance 0.022s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 16.194s
ok launchpad.net/juju-core/juju/osenv 0.017s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.016s
ok launchpad.net/juju-core/log/syslog 0.022s
ok launchpad.net/juju-core/names 0.026s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 6.270s
ok launchpad.net/juju-core/provider/common 6.871s
ok launchpad.net/juju-core/provider/dummy 23.855s
ok launchpad.net/juju-core/provider/ec2 23.012s
ok launchpad.net/juju-core/provider/joyent 5.309s
ok launchpad.net/juju-core/provider/local 2.387s
ok launchpad.net/juju-core/provider/maas 21.624s
ok launchpad.net/juju-core/provider/null 1.210s
ok launchpad.net/juju-core/provider/openstack 33.714s
ok launchpad.net/juju-core/replicaset 12.835s
ok launchpad.net/juju-core/rpc 0.096s
ok launchpad.net/juju-core/rpc/jsoncodec 0.034s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.020s
ok launchpad.net/juju-core/state 87.423s
ok launchpad.net/juju-core/state/api 2.127s
ok launchpad.net/juju-core/state/api/agent 2.344s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 6.025s
ok launchpad.net/juju-core/state/api/keymanager 3.756s
ok launchpad.net/juju-core/state/api/keyupdater 2.611s
ok launchpad.net/juju-core/state/api/logger 2.390s
ok launchpad.net/juju-core/state/api/machiner 2.910s
ok launchpad.net/juju-core/state/api/params 0.044s
ok launchpad.net/juju-core/state/api/provisioner 10.598s
ok launchpad.net/juju-core/state/api/uniter 27.678s
ok launchpad.net/juju-core/state/api/upgrader 3.842s
ok launchpad.net/juju-core/state/api/watcher 3.262s
ok launchpad.net/juju-core/state/apiserver 7.085s
ok launchpad.net/juju-core/state/apiserver/agent 3.125s
ok launchpad.net/juju-core/state/apiserver/client 44.506s
ok launchpad.net/juju-core/state/apiserver/common 1.520s
ok launchpad.net/juju-core/state/apiserver/deployer 4.586s
ok launchpad.net/juju-core/state/apiserver/keymanager 4.201s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 3.058s
ok launchpad.net/juju-core/state/apiserver/logger 3.909s
ok launchpad.net/juju-core/state/apiserver/machine 4.155s
ok launchpad.net/juju-core/state/apiserver/provisioner 12.042s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 18.960s
ok launchpad.net/juju-core/state/apiserver/upgrader 5.762s
ok launchpad.net/juju-core/state/multiwatcher 0.760s
ok launchpad.net/juju-core/state/presence 6.617s
? launchpad.net/juju-core/state/statecmd [no test files]
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 5.916s

----------------------------------------------------------------------
FAIL: store_test.go:52: StoreSuite.SetUpTest

store_test.go:53:
    s.MgoSuite.SetUpTest(c)
mgo_test.go:54:
    c.Assert(err, gc.IsNil)
... value *errors.errorString = &errors.errorString{s:"no reachable servers"} ("no reachable servers")

----------------------------------------------------------------------
PANIC: server_test.go:552: StoreSuite.TestBlitzKey

... Panic: Fixture has panicked (see related PANIC)
OOPS: 2 passed, 1 FAILED, 33 MISSED
--- FAIL: Test (10.59 seconds)
FAIL
FAIL launchpad.net/juju-core/store 10.850s
ok launchpad.net/juju-core/testing 1.379s
ok launchpad.net/juju-core/testing/checkers 0.026s
ok launchpad.net/juju-core/testing/testbase 0.042s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.129s
ok launchpad.net/juju-core/tools 0.026s
ok launchpad.net/juju-core/upstart 1.225s
ok launchpad.net/juju-core/utils 2.455s
ok launchpad.net/juju-core/utils/exec 0.068s
ok launchpad.net/juju-core/utils/fslock 1.499s
ok launchpad.net/juju-core/utils/parallel 0.977s
ok launchpad.net/juju-core/utils/set 0.016s
ok launchpad.net/juju-core/utils/ssh 1.182s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 1.084s
ok launchpad.net/juju-core/version 0.069s
ok launchpad.net/juju-core/worker 6.678s
ok launchpad.net/juju-core/worker/addressupdater 1.474s
ok launchpad.net/juju-core/worker/authenticationworker 3.384s
ok launchpad.net/juju-core/worker/cleaner 1.277s
ok launchpad.net/juju-core/worker/deployer 8.702s
ok launchpad.net/juju-core/worker/firewaller 11.427s
ok launchpad.net/juju-core/worker/localstorage 0.062s
ok launchpad.net/juju-core/worker/logger 1.629s
ok launchpad.net/juju-core/worker/machiner 7.501s
ok launchpad.net/juju-core/worker/minunitsworker 1.560s
ok launchpad.net/juju-core/worker/provisioner 40.934s
ok launchpad.net/juju-core/worker/resumer 1.558s
ok launchpad.net/juju-core/worker/terminationworker 0.080s
ok launchpad.net/juju-core/worker/uniter 164.509s
ok launchpad.net/juju-core/worker/uniter/charm 3.856s
ok launchpad.net/juju-core/worker/uniter/debug 0.137s
ok launchpad.net/juju-core/worker/uniter/hook 0.016s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.471s
ok launchpad.net/juju-core/worker/uniter/relation 1.369s
ok launchpad.net/juju-core/worker/upgrader 3.823s

warning: building out-of-date packages:
 launchpad.net/lpad
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.