Code review comment for lp:~thumper/juju-core/run-cmd-refactor

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+201680_code.launchpad.net,

Message:
Please take a look.

Description:
Refactor RunCommands function into a util package

As part of this work, the return structure has been
moved into the utils/exec package along with the
RunCommands function.

I didn't really like the return structure being in
the cmd package, but I didn't see a better place at
the time of making it.

The biggest part of this restructing is the renaming
of the call sites. A benefit is reduced package
dependencies by the users.

https://code.launchpad.net/~thumper/juju-core/run-cmd-refactor/+merge/201680

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/52300043/

Affected files (+237, -91 lines):
   A [revision details]
   M cmd/juju/run_test.go
   M cmd/jujud/main.go
   M cmd/jujud/run.go
   M cmd/jujud/run_test.go
   D cmd/remote.go
   M state/api/params/internal.go
   M state/apiserver/client/run.go
   M state/apiserver/client/run_test.go
   A utils/exec/exec.go
   A utils/exec/exec_test.go
   A utils/exec/package_test.go
   M utils/ssh/run.go
   M worker/uniter/context.go
   M worker/uniter/jujuc/server.go
   M worker/uniter/jujuc/server_test.go
   M worker/uniter/runlistener.go
   M worker/uniter/runlistener_test.go
   M worker/uniter/uniter.go
   M worker/uniter/uniter_test.go

« Back to merge proposal