Affected files (+237, -91 lines):
A [revision details]
M cmd/juju/run_test.go
M cmd/jujud/main.go
M cmd/jujud/run.go
M cmd/jujud/run_test.go
D cmd/remote.go
M state/api/params/internal.go
M state/apiserver/client/run.go
M state/apiserver/client/run_test.go
A utils/exec/exec.go
A utils/exec/exec_test.go
A utils/exec/package_test.go
M utils/ssh/run.go
M worker/uniter/context.go
M worker/uniter/jujuc/server.go
M worker/uniter/jujuc/server_test.go
M worker/uniter/runlistener.go
M worker/uniter/runlistener_test.go
M worker/uniter/uniter.go
M worker/uniter/uniter_test.go
Reviewers: mp+201680_ code.launchpad. net,
Message:
Please take a look.
Description:
Refactor RunCommands function into a util package
As part of this work, the return structure has been
moved into the utils/exec package along with the
RunCommands function.
I didn't really like the return structure being in
the cmd package, but I didn't see a better place at
the time of making it.
The biggest part of this restructing is the renaming
of the call sites. A benefit is reduced package
dependencies by the users.
https:/ /code.launchpad .net/~thumper/ juju-core/ run-cmd- refactor/ +merge/ 201680
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/52300043/
Affected files (+237, -91 lines): run_test. go run_test. go params/ internal. go /client/ run.go /client/ run_test. go exec_test. go package_ test.go uniter/ context. go uniter/ jujuc/server. go uniter/ jujuc/server_ test.go uniter/ runlistener. go uniter/ runlistener_ test.go uniter/ uniter. go uniter/ uniter_ test.go
A [revision details]
M cmd/juju/
M cmd/jujud/main.go
M cmd/jujud/run.go
M cmd/jujud/
D cmd/remote.go
M state/api/
M state/apiserver
M state/apiserver
A utils/exec/exec.go
A utils/exec/
A utils/exec/
M utils/ssh/run.go
M worker/
M worker/
M worker/
M worker/
M worker/
M worker/
M worker/