LGTM though the functions that used the "debugf" wrapper should probably actually be dropped to Tracef level.
https://codereview.appspot.com/88800043/diff/1/state/presence/presence.go File state/presence/presence.go (right):
https://codereview.appspot.com/88800043/diff/1/state/presence/presence.go#newcode22 state/presence/presence.go:22: var logger = loggo.GetLogger("juju.state.presence") These were all disabled by default, should we actually reduce them down to Tracef?
https://codereview.appspot.com/88800043/diff/1/state/watcher/watcher.go File state/watcher/watcher.go (left):
https://codereview.appspot.com/88800043/diff/1/state/watcher/watcher.go#oldcode279 state/watcher/watcher.go:279: debugf("state/watcher: got request: %#v", req) Same here, all of these were actually lower-than-debug because you had to explicitly enable the whole package to log.
We could make "juju.state.watcher" disabled by default, but I think just turning all of these into Tracef makes the most sense.
https://codereview.appspot.com/88800043/
« Back to merge proposal
LGTM though the functions that used the "debugf" wrapper should probably
actually be dropped to Tracef level.
https:/ /codereview. appspot. com/88800043/ diff/1/ state/presence/ presence. go presence. go (right):
File state/presence/
https:/ /codereview. appspot. com/88800043/ diff/1/ state/presence/ presence. go#newcode22 presence. go:22: var logger = ("juju. state.presence" )
state/presence/
loggo.GetLogger
These were all disabled by default, should we actually reduce them down
to Tracef?
https:/ /codereview. appspot. com/88800043/ diff/1/ state/watcher/ watcher. go watcher. go (left):
File state/watcher/
https:/ /codereview. appspot. com/88800043/ diff/1/ state/watcher/ watcher. go#oldcode279 watcher. go:279: debugf( "state/ watcher: got request: %#v",
state/watcher/
req)
Same here, all of these were actually lower-than-debug because you had
to explicitly enable the whole package to log.
We could make "juju.state. watcher" disabled by default, but I think just
turning all of these into Tracef makes the most sense.
https:/ /codereview. appspot. com/88800043/