Code review comment for lp:~thumper/juju-core/remove-old-log-functions

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+216247_code.launchpad.net,

Message:
Please take a look.

Description:
Remove legacy log functions.

This branch removes the old log.Errorf, log.Noticef,
log.Infof, log.Debugf, and log.Warningf in favour of
loggo functions.

The rsyslog package is moved to be under utils, and
the LoggedErrorf is moved to the errors package.

A lot of very mechanical changes.

https://code.launchpad.net/~thumper/juju-core/remove-old-log-functions/+merge/216247

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/88800043/

Affected files (+184, -316 lines):
   A [revision details]
   M charm/charm.go
   M charm/dir.go
   M charm/dir_test.go
   M charm/repo.go
   M charm/repo_test.go
   M cmd/juju/plugin.go
   M cmd/juju/publish.go
   M cmd/jujud/agent.go
   M container/kvm/container.go
   M container/kvm/kvm.go
   M downloader/downloader.go
   M environs/testing/tools.go
   M errors/errors.go
   M juju/api.go
   M juju/conn.go
   D log/log.go
   D log/log_test.go
   M provider/common/state.go
   M rpc/rpc_test.go
   M state/api/watcher/watcher.go
   M state/apiserver/charmrevisionupdater/updater.go
   M state/apiserver/common/password.go
   M state/apiserver/common/resource.go
   M state/presence/presence.go
   M state/watcher/watcher.go
   M store/lpad.go
   M store/server.go
   M store/store.go
   M testing/mgo.go
   M testing/testbase/log_test.go
   M utils/syslog/config_test.go
   M worker/authenticationworker/worker.go
   M worker/charmrevisionworker/revisionupdater.go
   M worker/cleaner/cleaner.go
   M worker/resumer/resumer.go
   M worker/rsyslog/rsyslog_test.go
   M worker/rsyslog/worker.go
   M worker/runner.go

« Back to merge proposal