LGTM with some tweaks
https://codereview.appspot.com/41210043/diff/1/worker/uniter/context.go File worker/uniter/context.go (right):
https://codereview.appspot.com/41210043/diff/1/worker/uniter/context.go#newcode191 worker/uniter/context.go:191: writeChanges := err == nil Why not just make writeChanges a method param? And set it accordingly in the caller if the err the caller has is nil?
https://codereview.appspot.com/41210043/diff/1/worker/uniter/uniter.go File worker/uniter/uniter.go (right):
https://codereview.appspot.com/41210043/diff/1/worker/uniter/uniter.go#newcode35 worker/uniter/uniter.go:35: type UniterExecutionObserver interface { Doc string please
https://codereview.appspot.com/41210043/diff/1/worker/uniter/uniter_test.go File worker/uniter/uniter_test.go (left):
https://codereview.appspot.com/41210043/diff/1/worker/uniter/uniter_test.go#oldcode192 worker/uniter/uniter_test.go:192: func (ctx *context) matchLogHooks(c *gc.C) (match bool, overshoot bool) { Is this still the best method name?
https://codereview.appspot.com/41210043/
« Back to merge proposal
LGTM with some tweaks
https:/ /codereview. appspot. com/41210043/ diff/1/ worker/ uniter/ context. go uniter/ context. go (right):
File worker/
https:/ /codereview. appspot. com/41210043/ diff/1/ worker/ uniter/ context. go#newcode191 uniter/ context. go:191: writeChanges := err == nil
worker/
Why not just make writeChanges a method param?
And set it accordingly in the caller if the err the caller has is nil?
https:/ /codereview. appspot. com/41210043/ diff/1/ worker/ uniter/ uniter. go uniter/ uniter. go (right):
File worker/
https:/ /codereview. appspot. com/41210043/ diff/1/ worker/ uniter/ uniter. go#newcode35 uniter/ uniter. go:35: type UniterExecution Observer interface {
worker/
Doc string please
https:/ /codereview. appspot. com/41210043/ diff/1/ worker/ uniter/ uniter_ test.go uniter/ uniter_ test.go (left):
File worker/
https:/ /codereview. appspot. com/41210043/ diff/1/ worker/ uniter/ uniter_ test.go# oldcode192 uniter/ uniter_ test.go: 192: func (ctx *context) matchLogHooks(c
worker/
*gc.C) (match bool, overshoot bool) {
Is this still the best method name?
https:/ /codereview. appspot. com/41210043/