Code review comment for lp:~thumper/juju-core/really-unit-agent-proxy-settings

The attempt to merge lp:~thumper/juju-core/really-unit-agent-proxy-settings into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 1.330s
ok launchpad.net/juju-core/agent/tools 0.247s
ok launchpad.net/juju-core/bzr 7.485s
ok launchpad.net/juju-core/cert 3.562s
ok launchpad.net/juju-core/charm 0.592s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]
ok launchpad.net/juju-core/cloudinit 0.032s
ok launchpad.net/juju-core/cloudinit/sshinit 1.035s
ok launchpad.net/juju-core/cmd 0.228s
ok launchpad.net/juju-core/cmd/charm-admin 0.852s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 240.691s
ok launchpad.net/juju-core/cmd/jujud 60.651s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 11.419s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/constraints 0.026s
ok launchpad.net/juju-core/container 0.036s
ok launchpad.net/juju-core/container/factory 0.056s
ok launchpad.net/juju-core/container/kvm 0.291s
ok launchpad.net/juju-core/container/kvm/mock 0.055s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 0.332s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.321s
ok launchpad.net/juju-core/environs 3.196s
ok launchpad.net/juju-core/environs/bootstrap 4.532s
ok launchpad.net/juju-core/environs/cloudinit 0.626s
ok launchpad.net/juju-core/environs/config 3.564s
ok launchpad.net/juju-core/environs/configstore 0.040s
ok launchpad.net/juju-core/environs/filestorage 0.032s
ok launchpad.net/juju-core/environs/httpstorage 1.061s
ok launchpad.net/juju-core/environs/imagemetadata 0.517s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.060s
ok launchpad.net/juju-core/environs/jujutest 0.218s
ok launchpad.net/juju-core/environs/manual 11.327s
ok launchpad.net/juju-core/environs/simplestreams 0.365s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 1.180s
ok launchpad.net/juju-core/environs/storage 1.123s
ok launchpad.net/juju-core/environs/sync 33.293s
ok launchpad.net/juju-core/environs/testing 0.206s
ok launchpad.net/juju-core/environs/tools 6.856s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.018s
ok launchpad.net/juju-core/instance 0.024s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 22.405s
ok launchpad.net/juju-core/juju/osenv 0.020s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.016s
ok launchpad.net/juju-core/log/syslog 0.025s
ok launchpad.net/juju-core/names 0.027s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 6.440s
ok launchpad.net/juju-core/provider/common 7.636s
ok launchpad.net/juju-core/provider/dummy 23.296s
ok launchpad.net/juju-core/provider/ec2 18.140s
ok launchpad.net/juju-core/provider/joyent 5.277s
ok launchpad.net/juju-core/provider/local 5.574s
ok launchpad.net/juju-core/provider/maas 18.736s
ok launchpad.net/juju-core/provider/null 1.238s
ok launchpad.net/juju-core/provider/openstack 35.268s
ok launchpad.net/juju-core/replicaset 59.795s
ok launchpad.net/juju-core/rpc 0.098s
ok launchpad.net/juju-core/rpc/jsoncodec 0.043s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.037s
ok launchpad.net/juju-core/state 88.847s
ok launchpad.net/juju-core/state/api 1.961s
ok launchpad.net/juju-core/state/api/agent 2.016s
? launchpad.net/juju-core/state/api/base [no test files]
ok launchpad.net/juju-core/state/api/charmrevisionupdater 1.547s
? launchpad.net/juju-core/state/api/common [no test files]
? launchpad.net/juju-core/state/api/common/testing [no test files]
ok launchpad.net/juju-core/state/api/deployer 6.581s
ok launchpad.net/juju-core/state/api/firewaller 10.945s
ok launchpad.net/juju-core/state/api/keymanager 3.690s
ok launchpad.net/juju-core/state/api/keyupdater 2.676s
ok launchpad.net/juju-core/state/api/logger 2.186s
ok launchpad.net/juju-core/state/api/machiner 3.222s
ok launchpad.net/juju-core/state/api/params 0.036s
ok launchpad.net/juju-core/state/api/provisioner 9.697s
ok launchpad.net/juju-core/state/api/uniter 27.192s
ok launchpad.net/juju-core/state/api/upgrader 3.760s
ok launchpad.net/juju-core/state/api/watcher 3.286s
ok launchpad.net/juju-core/state/apiserver 7.836s
ok launchpad.net/juju-core/state/apiserver/agent 3.093s
ok launchpad.net/juju-core/state/apiserver/charmrevisionupdater 2.848s
? launchpad.net/juju-core/state/apiserver/charmrevisionupdater/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/client 51.509s
ok launchpad.net/juju-core/state/apiserver/common 2.523s
? launchpad.net/juju-core/state/apiserver/common/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/deployer 7.262s
ok launchpad.net/juju-core/state/apiserver/firewaller 7.590s
ok launchpad.net/juju-core/state/apiserver/keymanager 4.460s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 3.159s
ok launchpad.net/juju-core/state/apiserver/logger 3.534s
ok launchpad.net/juju-core/state/apiserver/machine 3.089s
ok launchpad.net/juju-core/state/apiserver/provisioner 12.442s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 20.830s
ok launchpad.net/juju-core/state/apiserver/upgrader 5.964s
ok launchpad.net/juju-core/state/multiwatcher 0.766s
ok launchpad.net/juju-core/state/presence 6.433s
ok launchpad.net/juju-core/state/statecmd 2.058s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 5.741s
ok launchpad.net/juju-core/store 19.599s
ok launchpad.net/juju-core/testing 1.415s
ok launchpad.net/juju-core/testing/checkers 0.025s
ok launchpad.net/juju-core/testing/testbase 0.022s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.178s
ok launchpad.net/juju-core/tools 0.023s
ok launchpad.net/juju-core/upstart 1.293s
ok launchpad.net/juju-core/utils 2.469s
ok launchpad.net/juju-core/utils/exec 0.067s
ok launchpad.net/juju-core/utils/fslock 0.953s
ok launchpad.net/juju-core/utils/parallel 0.993s
ok launchpad.net/juju-core/utils/set 0.025s
ok launchpad.net/juju-core/utils/ssh 19.254s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 0.993s
ok launchpad.net/juju-core/version 0.069s
ok launchpad.net/juju-core/worker 6.676s
ok launchpad.net/juju-core/worker/authenticationworker 3.202s
ok launchpad.net/juju-core/worker/charmrevisionworker 2.357s
ok launchpad.net/juju-core/worker/cleaner 1.358s
ok launchpad.net/juju-core/worker/deployer 3.809s
ok launchpad.net/juju-core/worker/firewaller 12.938s
ok launchpad.net/juju-core/worker/instancepoller 2.560s
ok launchpad.net/juju-core/worker/localstorage 0.054s
ok launchpad.net/juju-core/worker/logger 1.510s
ok launchpad.net/juju-core/worker/machiner 3.172s
ok launchpad.net/juju-core/worker/minunitsworker 1.356s
*** Test killed: ran too long (10m0s).
FAIL launchpad.net/juju-core/worker/provisioner 600.013s
ok launchpad.net/juju-core/worker/resumer 1.640s
ok launchpad.net/juju-core/worker/terminationworker 0.069s
ok launchpad.net/juju-core/worker/uniter 182.899s
ok launchpad.net/juju-core/worker/uniter/charm 4.806s
ok launchpad.net/juju-core/worker/uniter/debug 0.177s
ok launchpad.net/juju-core/worker/uniter/hook 0.022s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.525s
ok launchpad.net/juju-core/worker/uniter/relation 1.400s
ok launchpad.net/juju-core/worker/upgrader 3.916s

warning: building out-of-date packages:
 launchpad.net/lpad
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.