New to lose the global proxy vars. But bigger issue is a missing end-end test to ensure we can make a change it state and it is propagated through and used next time a hook is run.
https://codereview.appspot.com/53240044/diff/1/worker/uniter/proxy.go File worker/uniter/proxy.go (right):
https://codereview.appspot.com/53240044/diff/1/worker/uniter/proxy.go#newcode16 worker/uniter/proxy.go:16: proxyMutex sync.Mutex Please move these from being global to attrs on Uniter
https://codereview.appspot.com/53240044/diff/1/worker/uniter/proxy.go#newcode26 worker/uniter/proxy.go:26: func UpdatePackageProxy(cfg *config.Config) { This could then be moved as well.
https://codereview.appspot.com/53240044/
« Back to merge proposal
New to lose the global proxy vars. But bigger issue is a missing end-end
test to ensure we can make a change it state and it is propagated
through and used next time a hook is run.
https:/ /codereview. appspot. com/53240044/ diff/1/ worker/ uniter/ proxy.go uniter/ proxy.go (right):
File worker/
https:/ /codereview. appspot. com/53240044/ diff/1/ worker/ uniter/ proxy.go# newcode16 uniter/ proxy.go: 16: proxyMutex sync.Mutex
worker/
Please move these from being global to attrs on Uniter
https:/ /codereview. appspot. com/53240044/ diff/1/ worker/ uniter/ proxy.go# newcode26 uniter/ proxy.go: 26: func UpdatePackagePr oxy(cfg *config.Config) {
worker/
This could then be moved as well.
https:/ /codereview. appspot. com/53240044/