Code review comment for lp:~thumper/juju-core/really-unit-agent-proxy-settings

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+202788_code.launchpad.net,

Message:
Please take a look.

Description:
Make the uniter pass on proxy settings

The uniter watches for environment changes and updates
the package proxy settings when they change. These
are used by the Context to specify the environment
for the hook execution.

https://code.launchpad.net/~thumper/juju-core/really-unit-agent-proxy-settings/+merge/202788

Requires:
https://code.launchpad.net/~thumper/juju-core/unit-agent-proxy-settings/+merge/202780

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/53240044/

Affected files (+184, -21 lines):
   A [revision details]
   M environs/cloudinit/cloudinit.go
   M juju/osenv/proxy.go
   M juju/osenv/proxy_test.go
   M worker/uniter/context.go
   M worker/uniter/context_test.go
   M worker/uniter/export_test.go
   A worker/uniter/proxy.go
   M worker/uniter/uniter.go
   M worker/uniter/uniter_test.go

« Back to merge proposal