Code review comment for lp:~thumper/juju-core/no-smash-networking

Revision history for this message
John A Meinel (jameinel) wrote :

I'm happy enough with this change, though I wish there was a test that
needed changing at the same time.

We talked about doing this in jujud startup, rather than during
cloud-init. (Then we have the full power of a programming language
rather than just a 'sed' script.)

Anyway, I definitely prefer this to land rather than block waiting for
something else, I'm just opening the conversation about where we might
be headed.

LGTM

https://codereview.appspot.com/13259043/diff/1/environs/maas/environ.go
File environs/maas/environ.go (right):

https://codereview.appspot.com/13259043/diff/1/environs/maas/environ.go#newcode270
environs/maas/environ.go:270: return `sed -i "s/iface eth0 inet
dhcp/source \/etc\/network\/eth0.config/" etc/network/interfaces`
Doesn't the last bit need to be "/etc/network/interfaces"? Are we always
guaranteed to run at '/' ?

https://codereview.appspot.com/13259043/

« Back to merge proposal