Code review comment for lp:~thumper/juju-core/no-proxy

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+210098_code.launchpad.net,

Message:
Please take a look.

Description:
Adds no_proxy support for proxies.

This was simply missed as part of the proxy support.
Tests updated throughout.

https://code.launchpad.net/~thumper/juju-core/no-proxy/+merge/210098

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/73290043/

Affected files (+140, -50 lines):
   A [revision details]
   M environs/cloudinit/cloudinit_test.go
   M environs/config/config.go
   M environs/config/config_test.go
   M juju/osenv/proxy.go
   M juju/osenv/proxy_test.go
   M provider/local/environprovider.go
   M provider/local/environprovider_test.go
   M worker/machineenvironmentworker/machineenvironmentworker_test.go
   M worker/uniter/context_test.go
   M worker/uniter/uniter_test.go

« Back to merge proposal