juju-core

Merge lp:~thumper/juju-core/machine-id-from-tag into lp:~go-bot/juju-core/trunk

machine-id-from-tag
Merge into trunk

Proposed by Tim Penhey on 2013-06-14

Status:	Merged
Approved by:	Tim Penhey on 2013-06-16
Approved revision:	no longer in the source branch.
Merged at revision:	1285
Proposed branch:	lp:~thumper/juju-core/machine-id-from-tag
Merge into:	lp:~go-bot/juju-core/trunk
Prerequisite:	lp:~thumper/juju-core/instance-instance
Diff against target:	51 lines (+21/-1) 2 files modified state/machine.go (+12/-1) state/machine_test.go (+9/-0)
To merge this branch:	bzr merge lp:~thumper/juju-core/machine-id-from-tag
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Juju Engineering		2013-06-14	Pending
Review via email: mp+169327@code.launchpad.net

Commit message

Add a MachineIdFromTag function.

There are times (coming in future branches) where you want to be able to
reverse the MachineTag result back into a machineId.

https://codereview.appspot.com/10274044/

Description of the change

Add a MachineIdFromTag function.

There are times (coming in future branches) where you want to be able to
reverse the MachineTag result back into a machineId.

https://codereview.appspot.com/10274044/

Revision history for this message

Tim Penhey (thumper) wrote on 2013-06-14:

Reviewers: mp+169327_code.launchpad.net,

Message:
Please take a look.

Description:
Add a MachineIdFromTag function.

There are times (coming in future branches) where you want to be able to
reverse the MachineTag result back into a machineId.

https://code.launchpad.net/~thumper/juju-core/machine-id-from-tag/+merge/169327

Requires:
https://code.launchpad.net/~thumper/juju-core/instance-instance/+merge/169325

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/10274044/

Affected files:
   A [revision details]
   M state/machine.go
   M state/machine_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: state/machine.go
=== modified file 'state/machine.go'
--- state/machine.go 2013-06-12 00:05:50 +0000
+++ state/machine.go 2013-06-14 02:27:04 +0000
@@ -107,15 +107,26 @@
return machineGlobalKey(m.doc.Id)
}

+const machineTagPrefix = "machine-"
+
  // MachineTag returns the tag for the
  // machine with the given id.
  func MachineTag(id string) string {
- tag := fmt.Sprintf("machine-%s", id)
+ tag := fmt.Sprintf("%s%s", machineTagPrefix, id)
   // Containers require "/" to be replaced by "-".
   tag = strings.Replace(tag, "/", "-", -1)
   return tag
  }

+// MachineIdFromTag returns the machine id that was used to create the tag.
+func MachineIdFromTag(tag string) string {
+ // Strip off the "machine-" prefix.
+ id := tag[len(machineTagPrefix):]
+ // Put the slashes back.
+ id = strings.Replace(id, "-", "/", -1)
+ return id
+}
+
  // Tag returns a name identifying the machine that is safe to use
  // as a file name. The returned name will be different from other
  // Tag values returned by any other entities from the same state.

Index: state/machine_test.go
=== modified file 'state/machine_test.go'
--- state/machine_test.go 2013-06-12 00:01:40 +0000
+++ state/machine_test.go 2013-06-14 02:27:04 +0000
@@ -192,6 +192,15 @@
c.Assert(state.MachineTag("10/lxc/1"), Equals, "machine-10-lxc-1")
}

+func (s *MachineSuite) TestMachineIdFromTag(c *C) {
+ c.Assert(state.MachineIdFromTag("machine-10"), Equals, "10")
+ // Check a container id.
+ c.Assert(state.MachineIdFromTag("machine-10-lxc-1"), Equals, "10/lxc/1")
+ // Check reversability.
+ nested := "2/kvm/0/lxc/3"
+ c.Assert(state.MachineIdFromTag(state.MachineTag(nested)), Equals, nested)
+}
+
  func (s *MachineSuite) TestSetMongoPassword(c *C) {
   testSetMongoPassword(c, func(st *state.State) (entity, error) {
    return st.Machine(s.machine.Id())

Reviewers: mp+169327_code.launchpad.net,

Message:
Please take a look.

Description:
Add a MachineIdFromTag function.

There are times (coming in future branches) where you want to be able to
reverse the MachineTag result back into a machineId.

https://code.launchpad.net/~thumper/juju-core/machine-id-from-tag/+merge/169327

Requires:
https://code.launchpad.net/~thumper/juju-core/instance-instance/+merge/169325

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/10274044/

Affected files:
   A [revision details]
   M state/machine.go
   M state/machine_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details]	2012-01-01 00:00:00 +0000
+++ [revision details]	2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tim.penhey@canonical.com-20130614021250-z3sj1uivqa9vilsr
+New revision: tim.penhey@canonical.com-20130614022704-wl0qhs2kdop8vwxk

Index: state/machine.go
=== modified file 'state/machine.go'
--- state/machine.go	2013-06-12 00:05:50 +0000
+++ state/machine.go	2013-06-14 02:27:04 +0000
@@ -107,15 +107,26 @@
  	return machineGlobalKey(m.doc.Id)
  }

+const machineTagPrefix = "machine-"
+
  // MachineTag returns the tag for the
  // machine with the given id.
  func MachineTag(id string) string {
-	tag := fmt.Sprintf("machine-%s", id)
+	tag := fmt.Sprintf("%s%s", machineTagPrefix, id)
  	// Containers require "/" to be replaced by "-".
  	tag = strings.Replace(tag, "/", "-", -1)
  	return tag
  }

+// MachineIdFromTag returns the machine id that was used to create the tag.
+func MachineIdFromTag(tag string) string {
+	// Strip off the "machine-" prefix.
+	id := tag[len(machineTagPrefix):]
+	// Put the slashes back.
+	id = strings.Replace(id, "-", "/", -1)
+	return id
+}
+
  // Tag returns a name identifying the machine that is safe to use
  // as a file name.  The returned name will be different from other
  // Tag values returned by any other entities from the same state.

Index: state/machine_test.go
=== modified file 'state/machine_test.go'
--- state/machine_test.go	2013-06-12 00:01:40 +0000
+++ state/machine_test.go	2013-06-14 02:27:04 +0000
@@ -192,6 +192,15 @@
  	c.Assert(state.MachineTag("10/lxc/1"), Equals, "machine-10-lxc-1")
  }

+func (s *MachineSuite) TestMachineIdFromTag(c *C) {
+	c.Assert(state.MachineIdFromTag("machine-10"), Equals, "10")
+	// Check a container id.
+	c.Assert(state.MachineIdFromTag("machine-10-lxc-1"), Equals, "10/lxc/1")
+	// Check reversability.
+	nested := "2/kvm/0/lxc/3"
+	c.Assert(state.MachineIdFromTag(state.MachineTag(nested)), Equals, nested)
+}
+
  func (s *MachineSuite) TestSetMongoPassword(c *C) {
  	testSetMongoPassword(c, func(st *state.State) (entity, error) {
  		return st.Machine(s.machine.Id())

Revision history for this message

William Reade (fwereade) wrote on 2013-06-14:

LGTM

https://codereview.appspot.com/10274044/

Revision history for this message

John A Meinel (jameinel) wrote on 2013-06-16:

LGTM

https://codereview.appspot.com/10274044/

Revision history for this message

Go Bot (go-bot) wrote on 2013-06-16:

The prerequisite https://code.launchpad.net/~thumper/juju-core/instance-instance has not yet been merged into https://code.launchpad.net/~go-bot/juju-core/trunk.

Revision history for this message

Go Bot (go-bot) wrote on 2013-06-16:

Download full text (24.1 KiB)

The attempt to merge lp:~thumper/juju-core/machine-id-from-tag into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/bzr 7.887s
ok launchpad.net/juju-core/cert 5.241s
ok launchpad.net/juju-core/charm 0.693s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.010s
ok launchpad.net/juju-core/cmd 0.254s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 168.791s

----------------------------------------------------------------------
FAIL: agent.go:0: MachineSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: machine_test.go:190: MachineSuite.TestManageEnviron

The attempt to merge lp:~thumper/juju-core/machine-id-from-tag into lp:juju-core failed. Below is the output from the failed tests.

ok  	launchpad.net/juju-core/bzr	7.887s
ok  	launchpad.net/juju-core/cert	5.241s
ok  	launchpad.net/juju-core/charm	0.693s
?   	launchpad.net/juju-core/charm/hooks	[no test files]
ok  	launchpad.net/juju-core/cloudinit	0.010s
ok  	launchpad.net/juju-core/cmd	0.254s
?   	launchpad.net/juju-core/cmd/builddb	[no test files]
?   	launchpad.net/juju-core/cmd/charmd	[no test files]
?   	launchpad.net/juju-core/cmd/charmload	[no test files]
ok  	launchpad.net/juju-core/cmd/juju	168.791s

----------------------------------------------------------------------
FAIL: agent.go:0: MachineSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
    c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: machine_test.go:190: MachineSuite.TestManageEnviron

[LOG] 64.20527 INFO juju environs/testing: uploading FAKE tools 1.11.1-precise-amd64
[LOG] 64.20532 INFO juju environs: reading tools with major version 1
[LOG] 64.20534 DEBUG juju environs/tools: reading v1.* tools
[LOG] 64.20536 INFO juju environs: falling back to public bucket
[LOG] 64.20538 DEBUG juju environs/tools: reading v1.* tools
[LOG] 64.20541 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 64.20543 INFO juju environs: filtering tools by series: precise
[LOG] 64.20545 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 64.20548 INFO juju environs/dummy: would pick tools from 1.11.1-precise-amd64
[LOG] 64.23659 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 64.24016 INFO juju state: connection established
[LOG] 64.29936 INFO juju state: initializing environment
[LOG] 64.54811 INFO juju state/api: listening on "localhost:0"
[LOG] 64.58435 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 64.58784 INFO juju state: connection established
[LOG] 64.58840 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 64.69674 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 64.70027 INFO juju state: connection established
[LOG] 64.75829 INFO juju state/api: dialing "wss://127.0.0.1:50803/"
[LOG] 64.76305 INFO juju state/api: connection established
[LOG] 64.76311 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 64.76325 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 64.86953 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 64.86973 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Response":{}}
[LOG] 64.86984 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 64.86997 INFO juju environs/testing: uploading FAKE tools 1.11.1-series-amd64
[LOG] 64.87038 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 64.87663 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 64.87676 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 65.04366 INFO juju agent starting
[LOG] 65.04370 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "machine-0"
[LOG] 65.04408 INFO juju agent starting
[LOG] 65.04699 INFO juju writing charm to storage [1418 bytes]
[LOG] 65.04706 INFO juju adding charm to state
[LOG] 65.05050 INFO juju state: connection established
[LOG] 65.05105 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "machine-0"
[LOG] 65.06411 INFO juju state: connection established
[LOG] 65.12045 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "machine-0"
[LOG] 65.12724 INFO juju state: connection established
[LOG] 65.15736 INFO juju jobs for machine agent: [JobManageEnviron]
[LOG] 65.16136 INFO juju.provisioner Starting up provisioner task 0
discarding unknown event dummy.OpPutFile{Env:"dummyenv"}
[LOG] 65.16915 DEBUG juju worker/firewaller: started watching machine 0
[LOG] 65.16974 INFO juju.provisioner machine 0 already started as instance "ardbeg-0"
[LOG] 65.17045 DEBUG juju worker/machiner: agent for machine "0" is now alive
[LOG] 65.17152 INFO juju.provisioner found machine "1" pending provisioning
[LOG] 65.17544 INFO juju environs/dummy: dummy startinstance, machine 1
[LOG] 65.17548 INFO juju environs: reading tools with major version 1
[LOG] 65.17549 DEBUG juju environs/tools: reading v1.* tools
[LOG] 65.17552 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 65.17556 DEBUG juju environs/tools: found 1.11.1-series-amd64
[LOG] 65.17560 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 65.17561 INFO juju environs: filtering tools by series: series
[LOG] 65.17564 INFO juju environs/dummy: would pick tools from 1.11.1-series-amd64
[LOG] 65.17914 DEBUG juju worker/firewaller: started watching unit test-service/0
[LOG] 65.17916 DEBUG juju worker/firewaller: started watching machine 1
[LOG] 65.18501 INFO juju worker/machiner: machine "0" started
[LOG] 65.18533 INFO juju.provisioner started machine 1 as instance dummyenv-0
[LOG] 75.13593 INFO juju environs/dummy: openPorts 1, []params.Port{params.Port{Protocol:"tcp", Number:999}}
[LOG] 75.13602 INFO juju worker/firewaller: opened ports [tcp:999] on machine 1
[LOG] 75.14051 INFO juju.provisioner Shutting down provisioner task 0
[LOG] 75.14072 ERROR juju agent died with no error
[LOG] 75.14234 ERROR juju agent died with no error
[LOG] 75.14453 INFO juju environs/dummy: reset environment
[LOG] 75.14476 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:50870: use of closed network connection (closing true)
[LOG] 75.14729 DEBUG juju rpc/jsoncodec: <- error: EOF (closing false)
... Panic: Fixture has panicked (see related PANIC)
[jujuc whatever]
[remote]
[/path/to/remote]
[remote --help]
[unknown]
[remote --error borken]
[remote --unknown]
[remote unwanted]

----------------------------------------------------------------------
FAIL: unit_test.go:29: UnitSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
unit_test.go:30:
    s.agentSuite.TearDownTest(c)
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
    c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: unit_test.go:167: UnitSuite.TestChangePasswordChanging

[LOG] 91.23364 INFO juju environs/testing: uploading FAKE tools 1.11.1-precise-amd64
[LOG] 91.23372 INFO juju environs: reading tools with major version 1
[LOG] 91.23374 DEBUG juju environs/tools: reading v1.* tools
[LOG] 91.23375 INFO juju environs: falling back to public bucket
[LOG] 91.23377 DEBUG juju environs/tools: reading v1.* tools
[LOG] 91.23382 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 91.23384 INFO juju environs: filtering tools by series: precise
[LOG] 91.23387 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 91.23389 INFO juju environs/dummy: would pick tools from 1.11.1-precise-amd64
[LOG] 91.26330 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 91.26749 INFO juju state: connection established
[LOG] 91.31961 INFO juju state: initializing environment
[LOG] 91.56646 INFO juju state/api: listening on "localhost:0"
[LOG] 91.59534 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 91.59895 INFO juju state: connection established
[LOG] 91.59944 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 91.70680 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 91.71045 INFO juju state: connection established
[LOG] 91.77611 INFO juju state/api: dialing "wss://127.0.0.1:50067/"
[LOG] 91.78049 INFO juju state/api: connection established
[LOG] 91.78056 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 91.78072 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 91.88397 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 91.88414 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Response":{}}
[LOG] 91.88429 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 91.88455 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 91.88879 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 91.88893 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 91.89171 INFO juju writing charm to storage [838 bytes]
[LOG] 91.89181 INFO juju adding charm to state
[LOG] 91.95716 INFO juju agent starting
[LOG] 91.95720 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 91.96059 INFO juju state: connection established
[LOG] 91.96114 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 91.96441 INFO juju state: connection established
[LOG] 91.99903 INFO juju worker/uniter: unit "wordpress/0" started
[LOG] 92.00405 INFO juju worker/uniter: unit "wordpress/0" shutting down: tomb: dying
[LOG] 92.00413 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.00435 DEBUG juju worker/uniter/filter: got unit change
[LOG] 92.00506 DEBUG juju worker/uniter/filter: got service change
[LOG] 92.00566 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.00571 ERROR juju worker/uniter/filter: tomb: dying
[LOG] 92.00690 ERROR juju agent died with no error
[LOG] 92.00695 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 92.01228 INFO juju state: connection established
[LOG] 92.01828 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 92.02105 INFO juju state: connection established
[LOG] 92.04594 INFO juju agent starting
[LOG] 92.04597 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 92.05129 INFO juju state: connection established
[LOG] 92.07496 INFO juju worker/uniter: unit "wordpress/0" started
[LOG] 92.07848 INFO juju worker/uniter: unit "wordpress/0" shutting down: tomb: dying
[LOG] 92.07872 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.07939 ERROR juju worker/uniter/filter: tomb: dying
[LOG] 92.08082 ERROR juju agent died with no error
[LOG] 92.09808 INFO juju agent starting
[LOG] 92.09811 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 92.10129 INFO juju state: connection established
[LOG] 92.10181 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 92.10482 INFO juju state: connection established
[LOG] 92.15090 INFO juju worker/uniter: unit "wordpress/0" started
[LOG] 92.15404 INFO juju worker/uniter: unit "wordpress/0" shutting down: tomb: dying
[LOG] 92.15406 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.15421 DEBUG juju worker/uniter/filter: got unit change
[LOG] 92.15492 DEBUG juju worker/uniter/filter: got service change
[LOG] 92.15532 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.15537 ERROR juju worker/uniter/filter: tomb: dying
[LOG] 92.15650 ERROR juju agent died with no error
[LOG] 92.16420 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity "unit-wordpress-0"
[LOG] 92.16731 INFO juju state: connection established
[LOG] 92.18751 INFO juju environs/dummy: reset environment
[LOG] 92.18950 DEBUG juju rpc/jsoncodec: <- error: EOF (closing false)
[LOG] 92.18953 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:40775: use of closed network connection (closing true)
... Panic: Fixture has panicked (see related PANIC)

----------------------------------------------------------------------
FAIL: upgrade_test.go:33: UpgraderSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
upgrade_test.go:35:
    s.JujuConnSuite.TearDownTest(c)
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
    c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: upgrade_test.go:235: UpgraderSuite.TestDelayedStop

[LOG] 2.29092 INFO juju environs/testing: uploading FAKE tools 1.11.1-precise-amd64
[LOG] 2.29098 INFO juju environs: reading tools with major version 1
[LOG] 2.29100 DEBUG juju environs/tools: reading v1.* tools
[LOG] 2.29102 INFO juju environs: falling back to public bucket
[LOG] 2.29103 DEBUG juju environs/tools: reading v1.* tools
[LOG] 2.29112 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 2.29114 INFO juju environs: filtering tools by series: precise
[LOG] 2.29116 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 2.29119 INFO juju environs/dummy: would pick tools from 1.11.1-precise-amd64
[LOG] 2.32154 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 2.32533 INFO juju state: connection established
[LOG] 2.37365 INFO juju state: initializing environment
[LOG] 2.61387 INFO juju state/api: listening on "localhost:0"
[LOG] 2.64386 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 2.64729 INFO juju state: connection established
[LOG] 2.64781 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 2.75346 INFO juju state: opening state; mongo addresses: ["localhost:43511"]; entity ""
[LOG] 2.75694 INFO juju state: connection established
[LOG] 2.81226 INFO juju state/api: dialing "wss://127.0.0.1:34682/"
[LOG] 2.81658 INFO juju state/api: connection established
[LOG] 2.81664 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 2.81680 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 2.92509 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 2.92531 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Response":{}}
[LOG] 2.92543 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 2.92569 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 2.93314 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 2.93333 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
0. same version
1. same version found for higher proposed version
[LOG] 2.95449 INFO juju environs: reading tools with major version 2
[LOG] 2.95451 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.95454 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.95457 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.95459 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.95460 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.95467 INFO juju environs: finding exact version 2.0.4-foo-bar
[LOG] 2.95471 ERROR juju environs/tools: cannot match tools.Filter{Released:false, Number:version.Number{Major:2, Minor:0, Patch:4, Build:0}, Series:"foo", Arch:"bar"}
[LOG] 2.95473 ERROR juju upgrader error finding tools for 2.0.4-foo-bar: no matching tools available
2. no appropriate version found
3. time out
[LOG] 2.96591 INFO juju environs: reading tools with major version 2
[LOG] 2.96592 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.96597 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.96600 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.96602 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.96604 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.96607 INFO juju environs: finding exact version 2.0.6-foo-bar
[LOG] 2.96609 INFO juju upgrader downloading "http://127.0.0.1:36308/dummyenv/private/tools/juju-2.0.6-foo-bar.tgz"
4. successful upgrade
[LOG] 2.97835 INFO juju environs: reading tools with major version 2
[LOG] 2.97837 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.97843 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.97846 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.97848 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.97854 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.97857 INFO juju environs: finding exact version 2.0.6-foo-bar
[LOG] 2.97859 INFO juju upgrader downloading "http://127.0.0.1:36308/dummyenv/private/tools/juju-2.0.6-foo-bar.tgz"
5. fetch error
[LOG] 2.99072 INFO juju environs: reading tools with major version 2
[LOG] 2.99074 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.99077 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.99080 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.99082 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.99085 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.99087 INFO juju environs: finding exact version 2.0.7-foo-bar
[LOG] 2.99089 INFO juju upgrader downloading "http://127.0.0.1:36308/dummyenv/private/tools/juju-2.0.7-foo-bar.tgz"
[LOG] 2.99129 ERROR juju upgrader download of 2.0.7-foo-bar failed: cannot download "http://127.0.0.1:36308/dummyenv/private/tools/juju-2.0.7-foo-bar.tgz": bad http response: 404 Not Found
[LOG] 2.99177 INFO juju environs/dummy: reset environment
[LOG] 2.99199 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:43133: use of closed network connection (closing true)
[LOG] 2.99489 DEBUG juju rpc/jsoncodec: <- error: EOF (closing false)
... Panic: Fixture has panicked (see related PANIC)
OOPS: 21 passed, 3 FAILED, 23 MISSED
--- FAIL: TestPackage (59.24 seconds)
FAIL
FAIL	launchpad.net/juju-core/cmd/jujud	59.546s
ok  	launchpad.net/juju-core/constraints	0.014s
ok  	launchpad.net/juju-core/downloader	5.370s
ok  	launchpad.net/juju-core/environs	1.981s
ok  	launchpad.net/juju-core/environs/agent	3.223s
?   	launchpad.net/juju-core/environs/all	[no test files]
?   	launchpad.net/juju-core/environs/azure	[no test files]
ok  	launchpad.net/juju-core/environs/cloudinit	0.472s
ok  	launchpad.net/juju-core/environs/config	0.896s
ok  	launchpad.net/juju-core/environs/dummy	14.619s
ok  	launchpad.net/juju-core/environs/ec2	104.645s
ok  	launchpad.net/juju-core/environs/imagemetadata	0.254s
ok  	launchpad.net/juju-core/environs/instances	0.312s
ok  	launchpad.net/juju-core/environs/jujutest	0.308s
ok  	launchpad.net/juju-core/environs/local	0.045s
ok  	launchpad.net/juju-core/environs/maas	8.917s
ok  	launchpad.net/juju-core/environs/openstack	8.238s
?   	launchpad.net/juju-core/environs/testing	[no test files]
ok  	launchpad.net/juju-core/environs/tools	17.844s
?   	launchpad.net/juju-core/errors	[no test files]
?   	launchpad.net/juju-core/instance	[no test files]
ok  	launchpad.net/juju-core/juju	17.364s
?   	launchpad.net/juju-core/juju/testing	[no test files]
ok  	launchpad.net/juju-core/log	0.007s
ok  	launchpad.net/juju-core/log/syslog	0.010s
ok  	launchpad.net/juju-core/rpc	0.264s
ok  	launchpad.net/juju-core/rpc/jsoncodec	0.013s
ok  	launchpad.net/juju-core/schema	0.011s
ok  	launchpad.net/juju-core/state	59.177s
?   	launchpad.net/juju-core/state/api	[no test files]
?   	launchpad.net/juju-core/state/api/common	[no test files]
ok  	launchpad.net/juju-core/state/api/machiner	4.704s
ok  	launchpad.net/juju-core/state/api/params	0.021s
ok  	launchpad.net/juju-core/state/apiserver	57.495s
?   	launchpad.net/juju-core/state/apiserver/common	[no test files]
ok  	launchpad.net/juju-core/state/apiserver/machiner	4.674s
ok  	launchpad.net/juju-core/state/multiwatcher	1.150s
ok  	launchpad.net/juju-core/state/presence	8.282s
ok  	launchpad.net/juju-core/state/statecmd	14.785s
ok  	launchpad.net/juju-core/state/watcher	5.555s
ok  	launchpad.net/juju-core/store	19.495s
ok  	launchpad.net/juju-core/testing	1.413s
?   	launchpad.net/juju-core/testing/checkers	[no test files]
ok  	launchpad.net/juju-core/thirdparty/pbkdf2	0.219s
ok  	launchpad.net/juju-core/upstart	0.154s
ok  	launchpad.net/juju-core/utils	0.876s
ok  	launchpad.net/juju-core/utils/fslock	1.205s
ok  	launchpad.net/juju-core/utils/set	0.009s
ok  	launchpad.net/juju-core/version	0.078s
ok  	launchpad.net/juju-core/worker	2.395s
ok  	launchpad.net/juju-core/worker/cleaner	1.732s
ok  	launchpad.net/juju-core/worker/deployer	4.810s
ok  	launchpad.net/juju-core/worker/firewaller	19.878s
ok  	launchpad.net/juju-core/worker/machiner	4.725s
ok  	launchpad.net/juju-core/worker/provisioner	13.036s
ok  	launchpad.net/juju-core/worker/uniter	127.903s
ok  	launchpad.net/juju-core/worker/uniter/charm	2.965s
ok  	launchpad.net/juju-core/worker/uniter/hook	0.008s
ok  	launchpad.net/juju-core/worker/uniter/jujuc	0.533s
ok  	launchpad.net/juju-core/worker/uniter/relation	4.640s

warning: building out-of-date packages:
	launchpad.net/goamz/ec2/ec2test
	launchpad.net/goamz/s3/s3test
	launchpad.net/goose/testservices/hook
	launchpad.net/goose/testservices/identityservice
	launchpad.net/goose/testservices
	launchpad.net/goose/testservices/novaservice
	launchpad.net/goose/testservices/swiftservice
	launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.

Revision history for this message

Tim Penhey (thumper) wrote on 2013-06-16:

Looks like a spurious test failure, trying again.

Revision history for this message

Go Bot (go-bot) wrote on 2013-06-16:

Download full text (24.1 KiB)

The attempt to merge lp:~thumper/juju-core/machine-id-from-tag into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/bzr 7.212s
ok launchpad.net/juju-core/cert 3.952s
ok launchpad.net/juju-core/charm 0.546s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.010s
ok launchpad.net/juju-core/cmd 0.266s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 170.299s

----------------------------------------------------------------------
FAIL: agent.go:0: MachineSuite.TearDownTest

----------------------------------------------------------------------
PANIC: machine_test.go:190: MachineSuite.TestManageEnviron

The attempt to merge lp:~thumper/juju-core/machine-id-from-tag into lp:juju-core failed. Below is the output from the failed tests.

ok  	launchpad.net/juju-core/bzr	7.212s
ok  	launchpad.net/juju-core/cert	3.952s
ok  	launchpad.net/juju-core/charm	0.546s
?   	launchpad.net/juju-core/charm/hooks	[no test files]
ok  	launchpad.net/juju-core/cloudinit	0.010s
ok  	launchpad.net/juju-core/cmd	0.266s
?   	launchpad.net/juju-core/cmd/builddb	[no test files]
?   	launchpad.net/juju-core/cmd/charmd	[no test files]
?   	launchpad.net/juju-core/cmd/charmload	[no test files]
ok  	launchpad.net/juju-core/cmd/juju	170.299s

----------------------------------------------------------------------
FAIL: agent.go:0: MachineSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
    c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: machine_test.go:190: MachineSuite.TestManageEnviron

[LOG] 64.28435 INFO juju environs/testing: uploading FAKE tools 1.11.1-precise-amd64
[LOG] 64.28441 INFO juju environs: reading tools with major version 1
[LOG] 64.28443 DEBUG juju environs/tools: reading v1.* tools
[LOG] 64.28444 INFO juju environs: falling back to public bucket
[LOG] 64.28446 DEBUG juju environs/tools: reading v1.* tools
[LOG] 64.28450 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 64.28451 INFO juju environs: filtering tools by series: precise
[LOG] 64.28454 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 64.28456 INFO juju environs/dummy: would pick tools from 1.11.1-precise-amd64
[LOG] 64.31914 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 64.32250 INFO juju state: connection established
[LOG] 64.39301 INFO juju state: initializing environment
[LOG] 64.64011 INFO juju state/api: listening on "localhost:0"
[LOG] 64.66967 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 64.67300 INFO juju state: connection established
[LOG] 64.67352 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 64.77893 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 64.78237 INFO juju state: connection established
[LOG] 64.83895 INFO juju state/api: dialing "wss://127.0.0.1:40640/"
[LOG] 64.84357 INFO juju state/api: connection established
[LOG] 64.84363 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 64.84377 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 64.94962 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 64.94984 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Response":{}}
[LOG] 64.94996 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 64.95009 INFO juju environs/testing: uploading FAKE tools 1.11.1-series-amd64
[LOG] 64.95051 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 64.95704 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 64.95717 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 65.14406 INFO juju agent starting
[LOG] 65.14410 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "machine-0"
[LOG] 65.14447 INFO juju agent starting
[LOG] 65.14583 INFO juju writing charm to storage [1418 bytes]
[LOG] 65.14588 INFO juju adding charm to state
[LOG] 65.15729 INFO juju state: connection established
[LOG] 65.15826 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "machine-0"
[LOG] 65.16436 INFO juju state: connection established
[LOG] 65.22324 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "machine-0"
discarding unknown event dummy.OpPutFile{Env:"dummyenv"}
[LOG] 65.23133 INFO juju state: connection established
[LOG] 65.25214 INFO juju jobs for machine agent: [JobManageEnviron]
[LOG] 65.25563 INFO juju.provisioner Starting up provisioner task 0
[LOG] 65.25947 DEBUG juju worker/firewaller: started watching machine 0
[LOG] 65.26008 INFO juju.provisioner machine 0 already started as instance "ardbeg-0"
[LOG] 65.26082 DEBUG juju worker/machiner: agent for machine "0" is now alive
[LOG] 65.26178 INFO juju.provisioner found machine "1" pending provisioning
[LOG] 65.26549 INFO juju environs/dummy: dummy startinstance, machine 1
[LOG] 65.26552 INFO juju environs: reading tools with major version 1
[LOG] 65.26554 DEBUG juju environs/tools: reading v1.* tools
[LOG] 65.26557 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 65.26561 DEBUG juju environs/tools: found 1.11.1-series-amd64
[LOG] 65.26564 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 65.26565 INFO juju environs: filtering tools by series: series
[LOG] 65.26568 INFO juju environs/dummy: would pick tools from 1.11.1-series-amd64
[LOG] 65.26877 DEBUG juju worker/firewaller: started watching unit test-service/0
[LOG] 65.26879 DEBUG juju worker/firewaller: started watching machine 1
[LOG] 65.27450 INFO juju worker/machiner: machine "0" started
[LOG] 65.27487 INFO juju.provisioner started machine 1 as instance dummyenv-0
[LOG] 75.23606 INFO juju environs/dummy: openPorts 1, []params.Port{params.Port{Protocol:"tcp", Number:999}}
[LOG] 75.23610 INFO juju worker/firewaller: opened ports [tcp:999] on machine 1
[LOG] 75.23837 ERROR juju agent died with no error
[LOG] 75.23849 INFO juju.provisioner Shutting down provisioner task 0
[LOG] 75.23867 ERROR juju agent died with no error
[LOG] 75.24006 INFO juju environs/dummy: reset environment
[LOG] 75.24029 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:39285: use of closed network connection (closing true)
[LOG] 75.24058 DEBUG juju rpc/jsoncodec: <- error: EOF (closing false)
... Panic: Fixture has panicked (see related PANIC)
[jujuc whatever]
[remote]
[/path/to/remote]
[remote --help]
[unknown]
[remote --error borken]
[remote --unknown]
[remote unwanted]

----------------------------------------------------------------------
FAIL: unit_test.go:29: UnitSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
unit_test.go:30:
    s.agentSuite.TearDownTest(c)
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
    c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: unit_test.go:167: UnitSuite.TestChangePasswordChanging

[LOG] 91.12845 INFO juju environs/testing: uploading FAKE tools 1.11.1-precise-amd64
[LOG] 91.12852 INFO juju environs: reading tools with major version 1
[LOG] 91.12854 DEBUG juju environs/tools: reading v1.* tools
[LOG] 91.12855 INFO juju environs: falling back to public bucket
[LOG] 91.12857 DEBUG juju environs/tools: reading v1.* tools
[LOG] 91.12862 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 91.12864 INFO juju environs: filtering tools by series: precise
[LOG] 91.12867 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 91.12870 INFO juju environs/dummy: would pick tools from 1.11.1-precise-amd64
[LOG] 91.15812 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 91.16198 INFO juju state: connection established
[LOG] 91.21988 INFO juju state: initializing environment
[LOG] 91.46164 INFO juju state/api: listening on "localhost:0"
[LOG] 91.49176 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 91.49546 INFO juju state: connection established
[LOG] 91.49596 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 91.60629 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 91.60981 INFO juju state: connection established
[LOG] 91.66508 INFO juju state/api: dialing "wss://127.0.0.1:34729/"
[LOG] 91.67691 INFO juju state/api: connection established
[LOG] 91.67700 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 91.67721 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 91.78763 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 91.78787 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Response":{}}
[LOG] 91.78802 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 91.78827 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 91.79275 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 91.79287 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 91.79586 INFO juju writing charm to storage [838 bytes]
[LOG] 91.79593 INFO juju adding charm to state
[LOG] 91.87967 INFO juju agent starting
[LOG] 91.87971 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 91.88311 INFO juju state: connection established
[LOG] 91.88363 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 91.88728 INFO juju state: connection established
[LOG] 91.92179 INFO juju worker/uniter: unit "wordpress/0" started
[LOG] 91.92686 INFO juju worker/uniter: unit "wordpress/0" shutting down: tomb: dying
[LOG] 91.92696 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 91.92721 DEBUG juju worker/uniter/filter: got unit change
[LOG] 91.92796 ERROR juju worker/uniter/filter: tomb: dying
[LOG] 91.92946 ERROR juju agent died with no error
[LOG] 91.92954 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 91.93504 INFO juju state: connection established
[LOG] 91.94125 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 91.94418 INFO juju state: connection established
[LOG] 91.97156 INFO juju agent starting
[LOG] 91.97159 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 91.97499 INFO juju state: connection established
[LOG] 91.99947 INFO juju worker/uniter: unit "wordpress/0" started
[LOG] 92.00301 INFO juju worker/uniter: unit "wordpress/0" shutting down: tomb: dying
[LOG] 92.00324 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.00384 ERROR juju worker/uniter/filter: tomb: dying
[LOG] 92.00521 ERROR juju agent died with no error
[LOG] 92.03278 INFO juju agent starting
[LOG] 92.03282 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 92.03625 INFO juju state: connection established
[LOG] 92.03679 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 92.03989 INFO juju state: connection established
[LOG] 92.07521 INFO juju worker/uniter: unit "wordpress/0" started
[LOG] 92.07860 INFO juju worker/uniter: unit "wordpress/0" shutting down: tomb: dying
[LOG] 92.07869 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.07887 DEBUG juju worker/uniter/filter: got unit change
[LOG] 92.07956 DEBUG juju worker/uniter/filter: got service change
[LOG] 92.08091 DEBUG juju worker/uniter/filter: charm check skipped, not yet installed.
[LOG] 92.08095 DEBUG juju worker/uniter/filter: got relations change
[LOG] 92.08100 ERROR juju worker/uniter/filter: tomb: dying
[LOG] 92.08110 ERROR juju agent died with no error
[LOG] 92.09020 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity "unit-wordpress-0"
[LOG] 92.09364 INFO juju state: connection established
[LOG] 92.11498 INFO juju environs/dummy: reset environment
[LOG] 92.11711 DEBUG juju rpc/jsoncodec: <- error: EOF (closing false)
[LOG] 92.11714 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:42902: use of closed network connection (closing true)
... Panic: Fixture has panicked (see related PANIC)

----------------------------------------------------------------------
FAIL: upgrade_test.go:33: UpgraderSuite.TearDownTest

Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
Waiting for sockets to die: 0 in use, 1 alive
upgrade_test.go:35:
    s.JujuConnSuite.TearDownTest(c)
/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:240:
    c.Fatal("Test left sockets in a dirty state")
... Error: Test left sockets in a dirty state

----------------------------------------------------------------------
PANIC: upgrade_test.go:235: UpgraderSuite.TestDelayedStop

[LOG] 2.23604 INFO juju environs/testing: uploading FAKE tools 1.11.1-precise-amd64
[LOG] 2.23611 INFO juju environs: reading tools with major version 1
[LOG] 2.23613 DEBUG juju environs/tools: reading v1.* tools
[LOG] 2.23614 INFO juju environs: falling back to public bucket
[LOG] 2.23616 DEBUG juju environs/tools: reading v1.* tools
[LOG] 2.23620 DEBUG juju environs/tools: found 1.11.1-precise-amd64
[LOG] 2.23621 INFO juju environs: filtering tools by series: precise
[LOG] 2.23624 INFO juju environs: filtering tools by version: 1.11.1
[LOG] 2.23627 INFO juju environs/dummy: would pick tools from 1.11.1-precise-amd64
[LOG] 2.26606 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 2.26958 INFO juju state: connection established
[LOG] 2.30303 INFO juju state: initializing environment
[LOG] 2.57023 INFO juju state/api: listening on "localhost:0"
[LOG] 2.60128 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 2.60563 INFO juju state: connection established
[LOG] 2.60626 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 2.71174 INFO juju state: opening state; mongo addresses: ["localhost:60317"]; entity ""
[LOG] 2.71549 INFO juju state: connection established
[LOG] 2.77269 INFO juju state/api: dialing "wss://127.0.0.1:53728/"
[LOG] 2.77734 INFO juju state/api: connection established
[LOG] 2.77739 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 2.77753 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret"}}
[LOG] 2.88239 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 2.88265 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Response":{}}
[LOG] 2.88279 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 2.88305 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"State","Request":"Ping","Params":{}}
[LOG] 2.89060 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
[LOG] 2.89097 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Error":"permission denied","ErrorCode":"unauthorized access","Response":{}}
0. same version
1. same version found for higher proposed version
[LOG] 2.91104 INFO juju environs: reading tools with major version 2
[LOG] 2.91106 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.91109 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.91112 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.91114 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.91115 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.91118 INFO juju environs: finding exact version 2.0.4-foo-bar
[LOG] 2.91121 ERROR juju environs/tools: cannot match tools.Filter{Released:false, Number:version.Number{Major:2, Minor:0, Patch:4, Build:0}, Series:"foo", Arch:"bar"}
[LOG] 2.91124 ERROR juju upgrader error finding tools for 2.0.4-foo-bar: no matching tools available
2. no appropriate version found
3. time out
[LOG] 2.92139 INFO juju environs: reading tools with major version 2
[LOG] 2.92141 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.92143 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.92146 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.92148 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.92150 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.92152 INFO juju environs: finding exact version 2.0.6-foo-bar
[LOG] 2.92154 INFO juju upgrader downloading "http://127.0.0.1:43863/dummyenv/private/tools/juju-2.0.6-foo-bar.tgz"
4. successful upgrade
[LOG] 2.93808 INFO juju environs: reading tools with major version 2
[LOG] 2.93812 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.93827 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.93834 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.93840 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.93846 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.93853 INFO juju environs: finding exact version 2.0.6-foo-bar
[LOG] 2.93859 INFO juju upgrader downloading "http://127.0.0.1:43863/dummyenv/private/tools/juju-2.0.6-foo-bar.tgz"
5. fetch error
[LOG] 2.95695 INFO juju environs: reading tools with major version 2
[LOG] 2.95698 DEBUG juju environs/tools: reading v2.* tools
[LOG] 2.95703 DEBUG juju environs/tools: found 2.0.3-foo-bar
[LOG] 2.95708 DEBUG juju environs/tools: found 2.0.5-foo-bar
[LOG] 2.95712 DEBUG juju environs/tools: found 2.0.6-foo-bar
[LOG] 2.95716 DEBUG juju environs/tools: found 2.0.7-foo-bar
[LOG] 2.95729 INFO juju environs: finding exact version 2.0.7-foo-bar
[LOG] 2.95734 INFO juju upgrader downloading "http://127.0.0.1:43863/dummyenv/private/tools/juju-2.0.7-foo-bar.tgz"
[LOG] 2.95807 ERROR juju upgrader download of 2.0.7-foo-bar failed: cannot download "http://127.0.0.1:43863/dummyenv/private/tools/juju-2.0.7-foo-bar.tgz": bad http response: 404 Not Found
[LOG] 2.95904 INFO juju environs/dummy: reset environment
[LOG] 2.96235 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:40382: use of closed network connection (closing true)
[LOG] 2.96636 DEBUG juju rpc/jsoncodec: <- error: EOF (closing false)
... Panic: Fixture has panicked (see related PANIC)
OOPS: 21 passed, 3 FAILED, 23 MISSED
--- FAIL: TestPackage (59.15 seconds)
FAIL
FAIL	launchpad.net/juju-core/cmd/jujud	59.523s
ok  	launchpad.net/juju-core/constraints	0.014s
ok  	launchpad.net/juju-core/downloader	5.312s
ok  	launchpad.net/juju-core/environs	1.788s
ok  	launchpad.net/juju-core/environs/agent	3.131s
?   	launchpad.net/juju-core/environs/all	[no test files]
?   	launchpad.net/juju-core/environs/azure	[no test files]
ok  	launchpad.net/juju-core/environs/cloudinit	0.529s
ok  	launchpad.net/juju-core/environs/config	0.867s
ok  	launchpad.net/juju-core/environs/dummy	14.231s
ok  	launchpad.net/juju-core/environs/ec2	104.801s
ok  	launchpad.net/juju-core/environs/imagemetadata	0.278s
ok  	launchpad.net/juju-core/environs/instances	0.265s
ok  	launchpad.net/juju-core/environs/jujutest	0.316s
ok  	launchpad.net/juju-core/environs/local	0.045s
ok  	launchpad.net/juju-core/environs/maas	8.851s
ok  	launchpad.net/juju-core/environs/openstack	8.092s
?   	launchpad.net/juju-core/environs/testing	[no test files]
ok  	launchpad.net/juju-core/environs/tools	17.152s
?   	launchpad.net/juju-core/errors	[no test files]
?   	launchpad.net/juju-core/instance	[no test files]
ok  	launchpad.net/juju-core/juju	17.278s
?   	launchpad.net/juju-core/juju/testing	[no test files]
ok  	launchpad.net/juju-core/log	0.007s
ok  	launchpad.net/juju-core/log/syslog	0.010s
ok  	launchpad.net/juju-core/rpc	0.269s
ok  	launchpad.net/juju-core/rpc/jsoncodec	0.013s
ok  	launchpad.net/juju-core/schema	0.011s
ok  	launchpad.net/juju-core/state	60.631s
?   	launchpad.net/juju-core/state/api	[no test files]
?   	launchpad.net/juju-core/state/api/common	[no test files]
ok  	launchpad.net/juju-core/state/api/machiner	4.791s
ok  	launchpad.net/juju-core/state/api/params	0.021s
ok  	launchpad.net/juju-core/state/apiserver	58.205s
?   	launchpad.net/juju-core/state/apiserver/common	[no test files]
ok  	launchpad.net/juju-core/state/apiserver/machiner	4.702s
ok  	launchpad.net/juju-core/state/multiwatcher	1.205s
ok  	launchpad.net/juju-core/state/presence	8.281s
ok  	launchpad.net/juju-core/state/statecmd	14.921s
ok  	launchpad.net/juju-core/state/watcher	5.668s
ok  	launchpad.net/juju-core/store	20.088s
ok  	launchpad.net/juju-core/testing	1.488s
?   	launchpad.net/juju-core/testing/checkers	[no test files]
ok  	launchpad.net/juju-core/thirdparty/pbkdf2	0.221s
ok  	launchpad.net/juju-core/upstart	0.154s
ok  	launchpad.net/juju-core/utils	0.873s
ok  	launchpad.net/juju-core/utils/fslock	1.086s
ok  	launchpad.net/juju-core/utils/set	0.008s
ok  	launchpad.net/juju-core/version	0.065s
ok  	launchpad.net/juju-core/worker	2.406s
ok  	launchpad.net/juju-core/worker/cleaner	1.704s
ok  	launchpad.net/juju-core/worker/deployer	4.819s
ok  	launchpad.net/juju-core/worker/firewaller	20.035s
ok  	launchpad.net/juju-core/worker/machiner	4.838s
ok  	launchpad.net/juju-core/worker/provisioner	13.156s
ok  	launchpad.net/juju-core/worker/uniter	129.301s
ok  	launchpad.net/juju-core/worker/uniter/charm	3.506s
ok  	launchpad.net/juju-core/worker/uniter/hook	0.007s
ok  	launchpad.net/juju-core/worker/uniter/jujuc	0.463s
ok  	launchpad.net/juju-core/worker/uniter/relation	4.467s

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Aaron Bentley

Dave Cheney

Dimiter Naydenov

Eric Snow

John A Meinel

Martin Packman

Nate Finch

Raphaël Badin

Tim Penhey

to status/vote changes:

rowez

 === modified file 'state/machine.go'
 --- state/machine.go	2013-06-16 11:39:46 +0000
 +++ state/machine.go	2013-06-16 22:21:24 +0000
@@ -107,15 +107,26 @@
  	return machineGlobalKey(m.doc.Id)
+ }
++const machineTagPrefix = "machine-"
++
  // MachineTag returns the tag for the
  // machine with the given id.
  func MachineTag(id string) string {
--	tag := fmt.Sprintf("machine-%s", id)
++	tag := fmt.Sprintf("%s%s", machineTagPrefix, id)
  	// Containers require "/" to be replaced by "-".
  	tag = strings.Replace(tag, "/", "-", -1)
  	return tag
+ }
++// MachineIdFromTag returns the machine id that was used to create the tag.
++func MachineIdFromTag(tag string) string {
++	// Strip off the "machine-" prefix.
++	id := tag[len(machineTagPrefix):]
++	// Put the slashes back.
++	id = strings.Replace(id, "-", "/", -1)
++	return id
++}
++
  // Tag returns a name identifying the machine that is safe to use
  // as a file name.  The returned name will be different from other
  // Tag values returned by any other entities from the same state.
 === modified file 'state/machine_test.go'
 --- state/machine_test.go	2013-06-12 00:01:40 +0000
 +++ state/machine_test.go	2013-06-16 22:21:24 +0000
@@ -192,6 +192,15 @@
  	c.Assert(state.MachineTag("10/lxc/1"), Equals, "machine-10-lxc-1")
+ }
++func (s *MachineSuite) TestMachineIdFromTag(c *C) {
++	c.Assert(state.MachineIdFromTag("machine-10"), Equals, "10")
++	// Check a container id.
++	c.Assert(state.MachineIdFromTag("machine-10-lxc-1"), Equals, "10/lxc/1")
++	// Check reversability.
++	nested := "2/kvm/0/lxc/3"
++	c.Assert(state.MachineIdFromTag(state.MachineTag(nested)), Equals, nested)
++}
++
  func (s *MachineSuite) TestSetMongoPassword(c *C) {
  	testSetMongoPassword(c, func(st *state.State) (entity, error) {
  		return st.Machine(s.machine.Id())