On 2013/07/31 06:26:34, jtv.canonical wrote:
> LGTM, except you have conflicts. Silly ones, from the looks of it:
mostly
> imports, but also a case where a function gained or lost an error
return.
> I was expecting to see changes to more providers' tests. Don't those
need to
> set the provider type in various places as well?
It is handled by the generic environs function FinishMachineConfig.
On 2013/07/31 06:26:34, jtv.canonical wrote:
> LGTM, except you have conflicts. Silly ones, from the looks of it:
mostly
> imports, but also a case where a function gained or lost an error
return.
> I was expecting to see changes to more providers' tests. Don't those
need to
> set the provider type in various places as well?
It is handled by the generic environs function FinishMachineCo nfig.
https:/ /codereview. appspot. com/12005048/