juju-core

Code review comment for lp:~thumper/juju-core/local-sudo-caller

  1. local-sudo-caller
  2. Merge into trunk
Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+174904_code.launchpad.net,

Message:
Please take a look.

Description:
Add some extra tests around the sudo checks.

Encapsulate the sudo checks, and make a function to
get the uid and gid for the user.

https://code.launchpad.net/~thumper/juju-core/local-sudo-caller/+merge/174904

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/11321043/

Affected files:
   A [revision details]
   M environs/local/config.go
   M environs/local/config_test.go
   M environs/local/export_test.go

« Back to merge proposal