juju-core

Code review comment for lp:~thumper/juju-core/local-provider-skeleton

  1. local-provider-skeleton
  2. Merge into trunk
Revision history for this message
Ian Booth (wallyworld) wrote :

LGTM with the tweak to the test

https://codereview.appspot.com/10679045/diff/2005/environs/local/local_test.go
File environs/local/local_test.go (right):

https://codereview.appspot.com/10679045/diff/2005/environs/local/local_test.go#newcode29
environs/local/local_test.go:29: c.Assert(error, IsNil)
Please assert that the returned provider really is a local provider

https://codereview.appspot.com/10679045/

« Back to merge proposal