Code review comment for lp:~thumper/juju-core/kvm-provisioner

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+197629_code.launchpad.net,

Message:
Please take a look.

Description:
Hook up the kvm broker and provisioner

This branch adds a kvm broker and hooks it up to the
existing container initialization.

The cpu-checker package is added to every machine to
allow kvm-ok to be executed.

A few drive by fixes related to kvm:
  * added a default bridge, used by the broker when
there is no other config.
  * the container wasn't removing the container dir
  * the kvm package isn't actually needed
  * the local provider was setting the wrong container
type (in the case of kvm)

https://code.launchpad.net/~thumper/juju-core/kvm-provisioner/+merge/197629

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/36910043/

Affected files (+388, -4 lines):
   A [revision details]
   M container/kvm/initialisation.go
   M container/kvm/kvm.go
   M environs/cloudinit/cloudinit.go
   M provider/local/environ.go
   M worker/provisioner/container_initialisation.go
   A worker/provisioner/kvm-broker.go
   A worker/provisioner/kvm-broker_test.go

« Back to merge proposal