Code review comment for lp:~thumper/juju-core/kvm-manager-start-stop

Reviewers: mp+196072_code.launchpad.net,

Message:
Please take a look.

Description:
Implement kvm start, stop and list.

The implementation here uses a mix of:
  * uvt-simplestream-libvirt
  * uvt-kvm
  * virsh

These are provided by the uvtool package and the
dependencies. The implementation of the low level
calls out to the shell are in container/kvm/libvirt.go

These low level calls are then used by the container
factory and container instances in container/kvm.

These are used by the container manager instance.

There are some live tests for the kvm calls.
   cd container/kvm
   sudo -E go test
This will take quite some time the first time it is
run on any particular machine as it is syncing the
kvm machine instances. But it does work \o/
The machines won't actually boot functional juju
machines in the test because the tools location is
fake.

https://code.launchpad.net/~thumper/juju-core/kvm-manager-start-stop/+merge/196072

Requires:
https://code.launchpad.net/~thumper/juju-core/local-provider-syslog/+merge/196048

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/30020044/

Affected files (+424, -29 lines):
   A [revision details]
   M container/kvm/container.go
   M container/kvm/containerfactory.go
   M container/kvm/interface.go
   M container/kvm/kvm.go
   M container/kvm/kvm_test.go
   A container/kvm/libvirt.go
   A container/kvm/live_test.go
   M container/kvm/mock/mock-kvm.go
   M container/kvm/mock/mock-kvm_test.go
   M container/userdata.go
   M log/log.go