Code review comment for lp:~thumper/juju-core/jujuc-run

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+198865_code.launchpad.net,

Message:
Please take a look.

Description:
Implement the juju-run symlink in jujud

Adds a command in the jujud executable so if the executable is called as
juju-run, it will attempt to connect to the rpc server being run by the
unit
specified as the first arg.

In order to get the return code passed out of the command infrastructure
I
added a new error type in the cmd package called "rcPassthroughError",
which
has a return code in it.

We use the jujud from the machine agent as the target of the juju-run
symlink
as we can add the symlink using cloud-init and we know there is only one
machine agent.

https://code.launchpad.net/~thumper/juju-core/jujuc-run/+merge/198865

Requires:
https://code.launchpad.net/~thumper/juju-core/uniter-run-commands/+merge/198830

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/41660044/

Affected files (+269, -0 lines):
   A [revision details]
   M cmd/cmd.go
   M cmd/jujud/main.go
   A cmd/jujud/run.go
   A cmd/jujud/run_test.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go

« Back to merge proposal