https://codereview.appspot.com/52470044/diff/1/cmd/jujud/run_test.go#newcode146
cmd/jujud/run_test.go:146: c.Assert(err, gc.ErrorMatches, "timeout")
What happens if this assert fails? The lock will still be held. Will
that adversely affect other tests? I think we should either add cleanup
or change the Assert to Check
LGTM with some consideration to my questions
https:/ /codereview. appspot. com/52470044/ diff/1/ cmd/jujud/ run.go
File cmd/jujud/run.go (right):
https:/ /codereview. appspot. com/52470044/ diff/1/ cmd/jujud/ run.go# newcode42 run.go: 42: If --no-context is specified, the <unit-name>
cmd/jujud/
positional
Not sure if --no-unit would be better here from a user perspective?
https:/ /codereview. appspot. com/52470044/ diff/1/ cmd/jujud/ run.go# newcode61 run.go: 61: f.BoolVar( &c.noContext, "no-context", false, "do
cmd/jujud/
not run the command in a unit context")
--no-unit???
https:/ /codereview. appspot. com/52470044/ diff/1/ cmd/jujud/ run_test. go run_test. go (right):
File cmd/jujud/
https:/ /codereview. appspot. com/52470044/ diff/1/ cmd/jujud/ run_test. go#newcode138 run_test. go:138: s.PatchValue( &fslock. LockWaitDelay, Millisecond)
cmd/jujud/
10*time.
should this be ShortWait?
https:/ /codereview. appspot. com/52470044/ diff/1/ cmd/jujud/ run_test. go#newcode146 run_test. go:146: c.Assert(err, gc.ErrorMatches, "timeout")
cmd/jujud/
What happens if this assert fails? The lock will still be held. Will
that adversely affect other tests? I think we should either add cleanup
or change the Assert to Check
https:/ /codereview. appspot. com/52470044/