Code review comment for lp:~thumper/juju-core/juju-run-just-lock

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+201702_code.launchpad.net,

Message:
Please take a look.

Description:
juju run should always use hook execution lock

When juju run executes remotely, for services and
units it was grabbing the file system lock for the
hook execution to make sure things are serialized
appropriately.

This branch makes sure that the machine executions
also use the file system lock to make sure the
commands are serialized.

https://code.launchpad.net/~thumper/juju-core/juju-run-just-lock/+merge/201702

Requires:
https://code.launchpad.net/~thumper/juju-core/run-cmd-refactor/+merge/201680

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/52470044/

Affected files (+183, -66 lines):
   A [revision details]
   M cmd/jujud/run.go
   M cmd/jujud/run_test.go
   M state/apiserver/client/run.go
   M state/apiserver/client/run_test.go
   D utils/fslock/export_test.go
   M utils/fslock/fslock.go
   M utils/fslock/fslock_test.go
   A utils/fslock/package_test.go

« Back to merge proposal