Merge lp:~thumper/juju-core/juju-errors into lp:~go-bot/juju-core/trunk

Proposed by Tim Penhey
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2731
Proposed branch: lp:~thumper/juju-core/juju-errors
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 3793 lines (+271/-683)
156 files modified
agent/agent.go (+14/-14)
agent/tools/toolsdir.go (+2/-2)
cert/cert.go (+3/-4)
cmd/juju/bootstrap_test.go (+1/-1)
cmd/juju/common.go (+2/-1)
cmd/juju/debuglog.go (+1/-1)
cmd/juju/debuglog_test.go (+1/-1)
cmd/juju/deploy_test.go (+1/-1)
cmd/juju/destroyenvironment_test.go (+1/-1)
cmd/juju/removemachine_test.go (+1/-1)
cmd/jujud/agent.go (+1/-1)
cmd/jujud/bootstrap_test.go (+1/-1)
cmd/jujud/machine.go (+1/-1)
cmd/jujud/machine_test.go (+1/-1)
constraints/constraints.go (+2/-2)
container/kvm/container.go (+2/-1)
container/kvm/kvm.go (+1/-1)
container/lxc/instance.go (+1/-1)
dependencies.tsv (+2/-1)
environs/bootstrap/state.go (+2/-2)
environs/bootstrap/synctools.go (+2/-1)
environs/cloudinit.go (+2/-3)
environs/cloudinit/cloudinit.go (+3/-4)
environs/config.go (+1/-1)
environs/config/config.go (+2/-2)
environs/configstore/disk.go (+5/-6)
environs/configstore/disk_test.go (+1/-1)
environs/configstore/mem.go (+1/-1)
environs/emptystorage.go (+2/-1)
environs/emptystorage_test.go (+1/-1)
environs/filestorage/filestorage.go (+4/-3)
environs/filestorage/filestorage_test.go (+3/-3)
environs/httpstorage/storage.go (+2/-3)
environs/httpstorage/storage_test.go (+1/-1)
environs/imagemetadata/generate.go (+2/-1)
environs/jujutest/livetests.go (+1/-1)
environs/jujutest/tests.go (+1/-1)
environs/open.go (+2/-3)
environs/open_test.go (+1/-1)
environs/simplestreams/datasource.go (+2/-1)
environs/simplestreams/simplestreams.go (+1/-1)
environs/sshstorage/storage.go (+2/-3)
environs/sshstorage/storage_test.go (+2/-2)
environs/tools/simplestreams.go (+2/-1)
environs/tools/tools.go (+1/-1)
environs/tools/tools_test.go (+1/-1)
errors/errors.go (+0/-210)
errors/errors_test.go (+0/-209)
juju/api.go (+2/-1)
juju/apiconn_test.go (+1/-1)
juju/conn.go (+1/-1)
juju/conn_test.go (+1/-1)
provider/azure/certfile.go (+1/-1)
provider/azure/environ.go (+1/-1)
provider/azure/instance.go (+1/-1)
provider/azure/instancetype.go (+1/-1)
provider/azure/storage.go (+1/-1)
provider/azure/storage_test.go (+1/-1)
provider/common/destroy_test.go (+1/-1)
provider/dummy/storage.go (+2/-1)
provider/ec2/ec2.go (+1/-1)
provider/ec2/storage.go (+1/-1)
provider/joyent/environ_instance.go (+1/-1)
provider/joyent/storage.go (+3/-3)
provider/joyent/storage_test.go (+3/-3)
provider/local/environ.go (+2/-3)
provider/local/instance.go (+2/-1)
provider/maas/environ.go (+1/-1)
provider/maas/environ_whitebox_test.go (+1/-1)
provider/maas/storage.go (+1/-1)
provider/maas/storage_test.go (+1/-1)
provider/manual/environ.go (+2/-3)
provider/openstack/provider.go (+2/-2)
provider/openstack/storage.go (+2/-2)
state/addmachine.go (+1/-1)
state/annotator.go (+1/-2)
state/api/agent/machine_test.go (+1/-1)
state/api/client.go (+1/-1)
state/api/machiner/machiner_test.go (+1/-1)
state/api/provisioner/provisioner_test.go (+1/-1)
state/api/uniter/unit_test.go (+1/-1)
state/api/upgrader/unitupgrader_test.go (+1/-1)
state/api/upgrader/upgrader_test.go (+1/-1)
state/apiserver/admin.go (+2/-1)
state/apiserver/charmrevisionupdater/updater.go (+1/-1)
state/apiserver/charmrevisionupdater/updater_test.go (+1/-1)
state/apiserver/charms.go (+25/-25)
state/apiserver/client/api_test.go (+1/-1)
state/apiserver/client/client.go (+12/-13)
state/apiserver/client/client_test.go (+1/-1)
state/apiserver/client/destroy_test.go (+2/-2)
state/apiserver/client/status.go (+2/-1)
state/apiserver/common/errors.go (+2/-1)
state/apiserver/common/errors_test.go (+1/-1)
state/apiserver/common/password_test.go (+1/-1)
state/apiserver/deployer/deployer_test.go (+1/-1)
state/apiserver/firewaller/firewaller_test.go (+1/-1)
state/apiserver/keymanager/keymanager.go (+1/-1)
state/apiserver/keyupdater/authorisedkeys.go (+2/-1)
state/apiserver/machine/machiner.go (+2/-1)
state/apiserver/provisioner/provisioner_test.go (+1/-1)
state/apiserver/uniter/uniter.go (+2/-1)
state/apiserver/uniter/uniter_test.go (+1/-1)
state/apiserver/upgrader/unitupgrader_test.go (+1/-1)
state/apiserver/upgrader/upgrader_test.go (+1/-1)
state/charm_test.go (+1/-1)
state/cleanup.go (+1/-2)
state/cleanup_test.go (+1/-1)
state/configvalidator_test.go (+2/-1)
state/conn_test.go (+1/-1)
state/constraints.go (+1/-1)
state/environ.go (+1/-1)
state/environcapability_test.go (+1/-1)
state/machine.go (+1/-1)
state/machine_test.go (+1/-1)
state/megawatcher.go (+1/-1)
state/minimumunits.go (+3/-6)
state/open.go (+1/-1)
state/policy.go (+2/-1)
state/prechecker_test.go (+1/-1)
state/relation.go (+1/-1)
state/relation_test.go (+1/-1)
state/relationunit.go (+1/-1)
state/relationunit_test.go (+1/-1)
state/service.go (+1/-1)
state/service_test.go (+1/-1)
state/settings.go (+1/-2)
state/settings_test.go (+1/-1)
state/state.go (+1/-1)
state/state_test.go (+1/-1)
state/status.go (+1/-1)
state/tools_test.go (+1/-1)
state/unit.go (+1/-1)
state/unit_test.go (+1/-1)
state/user.go (+1/-1)
state/watcher.go (+1/-1)
worker/authenticationworker/worker.go (+1/-1)
worker/deployer/deployer_test.go (+1/-1)
worker/firewaller/firewaller.go (+6/-6)
worker/instancepoller/aggregate.go (+1/-1)
worker/instancepoller/aggregate_test.go (+3/-2)
worker/instancepoller/machine_test.go (+1/-1)
worker/instancepoller/updater.go (+1/-1)
worker/peergrouper/mock_test.go (+1/-1)
worker/peergrouper/worker.go (+1/-1)
worker/provisioner/kvm-broker_test.go (+1/-1)
worker/provisioner/lxc-broker_test.go (+1/-1)
worker/provisioner/provisioner.go (+1/-1)
worker/provisioner/provisioner_test.go (+1/-1)
worker/rsyslog/worker.go (+7/-7)
worker/uniter/charm/bundles.go (+2/-1)
worker/uniter/relation/relation.go (+2/-1)
worker/uniter/relationer_test.go (+1/-1)
worker/uniter/state.go (+3/-3)
worker/uniter/uniter_test.go (+1/-1)
worker/upgrader/upgrader_test.go (+1/-1)
To merge this branch: bzr merge lp:~thumper/juju-core/juju-errors
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+219608@code.launchpad.net

Commit message

Extract errors package to github.com/juju/errors

Also introduces a dependency on github.com/juju/errgo
and removes the github.com/errgo/errgo dependency.

Adds additional functions for simple tracing and
annotations of errors.

https://codereview.appspot.com/93410043/

Description of the change

Extract errors package to github.com/juju/errors

Also introduces a dependency on github.com/juju/errgo
and removes the github.com/errgo/errgo dependency.

Adds additional functions for simple tracing and
annotations of errors.

https://codereview.appspot.com/93410043/

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :
Download full text (5.6 KiB)

Reviewers: mp+219608_code.launchpad.net,

Message:
Please take a look.

Description:
Extract errors package to github.com/juju/errors

Also introduces a dependency on github.com/juju/errgo
and removes the github.com/errgo/errgo dependency.

Adds additional functions for simple tracing and
annotations of errors.

https://code.launchpad.net/~thumper/juju-core/juju-errors/+merge/219608

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/93410043/

Affected files (+254, -658 lines):
   A [revision details]
   M agent/agent.go
   M agent/tools/toolsdir.go
   M cert/cert.go
   M cmd/juju/bootstrap_test.go
   M cmd/juju/common.go
   M cmd/juju/debuglog.go
   M cmd/juju/debuglog_test.go
   M cmd/juju/deploy_test.go
   M cmd/juju/destroyenvironment_test.go
   M cmd/juju/removemachine_test.go
   M cmd/jujud/agent.go
   M cmd/jujud/bootstrap_test.go
   M cmd/jujud/machine.go
   M cmd/jujud/machine_test.go
   M constraints/constraints.go
   M container/kvm/container.go
   M container/kvm/kvm.go
   M container/lxc/instance.go
   M dependencies.tsv
   M environs/bootstrap/state.go
   M environs/bootstrap/synctools.go
   M environs/cloudinit.go
   M environs/cloudinit/cloudinit.go
   M environs/config.go
   M environs/config/config.go
   M environs/configstore/disk.go
   M environs/configstore/disk_test.go
   M environs/configstore/mem.go
   M environs/emptystorage.go
   M environs/emptystorage_test.go
   M environs/filestorage/filestorage.go
   M environs/filestorage/filestorage_test.go
   M environs/httpstorage/storage.go
   M environs/httpstorage/storage_test.go
   M environs/imagemetadata/generate.go
   M environs/jujutest/livetests.go
   M environs/jujutest/tests.go
   M environs/open.go
   M environs/open_test.go
   M environs/simplestreams/datasource.go
   M environs/simplestreams/simplestreams.go
   M environs/sshstorage/storage.go
   M environs/sshstorage/storage_test.go
   M environs/tools/simplestreams.go
   M environs/tools/tools.go
   M environs/tools/tools_test.go
   D errors/errors.go
   D errors/errors_test.go
   M juju/api.go
   M juju/apiconn_test.go
   M juju/conn.go
   M juju/conn_test.go
   M provider/azure/certfile.go
   M provider/azure/environ.go
   M provider/azure/instance.go
   M provider/azure/instancetype.go
   M provider/azure/storage.go
   M provider/azure/storage_test.go
   M provider/common/destroy_test.go
   M provider/dummy/storage.go
   M provider/ec2/ec2.go
   M provider/ec2/storage.go
   M provider/joyent/environ_instance.go
   M provider/joyent/storage.go
   M provider/joyent/storage_test.go
   M provider/local/environ.go
   M provider/local/instance.go
   M provider/maas/environ.go
   M provider/maas/environ_whitebox_test.go
   M provider/maas/storage.go
   M provider/maas/storage_test.go
   M provider/manual/environ.go
   M provider/openstack/provider.go
   M provider/openstack/storage.go
   M state/addmachine.go
   M state/annotator.go
   M state/api/agent/machine_test.go
   M state/api/client.go
   M state/api/machiner/machiner_test.go
   M state/api/provisioner/provisioner_test.go
   M state/api/uniter/unit_test.go
   M state/api/upgrader/unitupgrader_test.go
   ...

Read more...

Revision history for this message
Dave Cheney (dave-cheney) wrote :
Download full text (6.2 KiB)

mien gott

On Thu, May 15, 2014 at 7:57 AM, Tim Penhey <email address hidden> wrote:
> Reviewers: mp+219608_code.launchpad.net,
>
> Message:
> Please take a look.
>
> Description:
> Extract errors package to github.com/juju/errors
>
> Also introduces a dependency on github.com/juju/errgo
> and removes the github.com/errgo/errgo dependency.
>
> Adds additional functions for simple tracing and
> annotations of errors.
>
> https://code.launchpad.net/~thumper/juju-core/juju-errors/+merge/219608
>
> (do not edit description out of merge proposal)
>
>
> Please review this at https://codereview.appspot.com/93410043/
>
> Affected files (+254, -658 lines):
> A [revision details]
> M agent/agent.go
> M agent/tools/toolsdir.go
> M cert/cert.go
> M cmd/juju/bootstrap_test.go
> M cmd/juju/common.go
> M cmd/juju/debuglog.go
> M cmd/juju/debuglog_test.go
> M cmd/juju/deploy_test.go
> M cmd/juju/destroyenvironment_test.go
> M cmd/juju/removemachine_test.go
> M cmd/jujud/agent.go
> M cmd/jujud/bootstrap_test.go
> M cmd/jujud/machine.go
> M cmd/jujud/machine_test.go
> M constraints/constraints.go
> M container/kvm/container.go
> M container/kvm/kvm.go
> M container/lxc/instance.go
> M dependencies.tsv
> M environs/bootstrap/state.go
> M environs/bootstrap/synctools.go
> M environs/cloudinit.go
> M environs/cloudinit/cloudinit.go
> M environs/config.go
> M environs/config/config.go
> M environs/configstore/disk.go
> M environs/configstore/disk_test.go
> M environs/configstore/mem.go
> M environs/emptystorage.go
> M environs/emptystorage_test.go
> M environs/filestorage/filestorage.go
> M environs/filestorage/filestorage_test.go
> M environs/httpstorage/storage.go
> M environs/httpstorage/storage_test.go
> M environs/imagemetadata/generate.go
> M environs/jujutest/livetests.go
> M environs/jujutest/tests.go
> M environs/open.go
> M environs/open_test.go
> M environs/simplestreams/datasource.go
> M environs/simplestreams/simplestreams.go
> M environs/sshstorage/storage.go
> M environs/sshstorage/storage_test.go
> M environs/tools/simplestreams.go
> M environs/tools/tools.go
> M environs/tools/tools_test.go
> D errors/errors.go
> D errors/errors_test.go
> M juju/api.go
> M juju/apiconn_test.go
> M juju/conn.go
> M juju/conn_test.go
> M provider/azure/certfile.go
> M provider/azure/environ.go
> M provider/azure/instance.go
> M provider/azure/instancetype.go
> M provider/azure/storage.go
> M provider/azure/storage_test.go
> M provider/common/destroy_test.go
> M provider/dummy/storage.go
> M provider/ec2/ec2.go
> M provider/ec2/storage.go
> M provider/joyent/environ_instance.go
> M provider/joyent/storage.go
> M provider/joyent/storage_test.go
> M provider/local/environ.go
> M provider/local/instance.go
> M provider/maas/environ.go
> M provider/maas/environ_whitebox_test.go
> M provider/maas/storage.go
> M provider/maas/storage_test.go
> M provider/manual/environ.go
> M provider/openstack/provider.go
> M provider/openstack/storage.go
> M s...

Read more...

Revision history for this message
Andrew Wilkins (axwalk) wrote :

LGTM with a minor renaming

https://codereview.appspot.com/93410043/diff/1/provider/openstack/storage.go
File provider/openstack/storage.go (right):

https://codereview.appspot.com/93410043/diff/1/provider/openstack/storage.go#newcode12
provider/openstack/storage.go:12: coreerrors "github.com/juju/errors"
s/coreerrors/jujuerrors/

https://codereview.appspot.com/93410043/diff/1/state/apiserver/client/destroy_test.go
File state/apiserver/client/destroy_test.go (right):

https://codereview.appspot.com/93410043/diff/1/state/apiserver/client/destroy_test.go#newcode9
state/apiserver/client/destroy_test.go:9: coreerrors
"github.com/juju/errors"
ditto
(and anywhere else coreerrors exists)

https://codereview.appspot.com/93410043/

Revision history for this message
Go Bot (go-bot) wrote :

The attempt to merge lp:~thumper/juju-core/juju-errors into lp:juju-core failed. Below is the output from the failed tests.

godeps: cannot parse "dependencies.tsv": cannot find directory for "github.com/juju/errgo": not found in GOPATH
mongod: no process found

Revision history for this message
Dave Cheney (dave-cheney) wrote :

LGTM. I have the same comment as axw about renaming the juju/errors
import. Can that be avoided -- it's totally cool to defer that to a
later branch and leave this as the mechanical translation.

https://codereview.appspot.com/93410043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'agent/agent.go'
--- agent/agent.go 2014-04-23 08:50:28 +0000
+++ agent/agent.go 2014-05-15 02:28:23 +0000
@@ -15,7 +15,7 @@
15 "strconv"15 "strconv"
16 "strings"16 "strings"
1717
18 "github.com/errgo/errgo"18 "github.com/juju/errors"
19 "github.com/juju/loggo"19 "github.com/juju/loggo"
2020
21 "launchpad.net/juju-core/instance"21 "launchpad.net/juju-core/instance"
@@ -247,23 +247,23 @@
247// machine or unit agent.247// machine or unit agent.
248func NewAgentConfig(configParams AgentConfigParams) (ConfigSetterWriter, error) {248func NewAgentConfig(configParams AgentConfigParams) (ConfigSetterWriter, error) {
249 if configParams.DataDir == "" {249 if configParams.DataDir == "" {
250 return nil, errgo.Trace(requiredError("data directory"))250 return nil, errors.Trace(requiredError("data directory"))
251 }251 }
252 logDir := DefaultLogDir252 logDir := DefaultLogDir
253 if configParams.LogDir != "" {253 if configParams.LogDir != "" {
254 logDir = configParams.LogDir254 logDir = configParams.LogDir
255 }255 }
256 if configParams.Tag == "" {256 if configParams.Tag == "" {
257 return nil, errgo.Trace(requiredError("entity tag"))257 return nil, errors.Trace(requiredError("entity tag"))
258 }258 }
259 if configParams.UpgradedToVersion == version.Zero {259 if configParams.UpgradedToVersion == version.Zero {
260 return nil, errgo.Trace(requiredError("upgradedToVersion"))260 return nil, errors.Trace(requiredError("upgradedToVersion"))
261 }261 }
262 if configParams.Password == "" {262 if configParams.Password == "" {
263 return nil, errgo.Trace(requiredError("password"))263 return nil, errors.Trace(requiredError("password"))
264 }264 }
265 if len(configParams.CACert) == 0 {265 if len(configParams.CACert) == 0 {
266 return nil, errgo.Trace(requiredError("CA certificate"))266 return nil, errors.Trace(requiredError("CA certificate"))
267 }267 }
268 // Note that the password parts of the state and api information are268 // Note that the password parts of the state and api information are
269 // blank. This is by design.269 // blank. This is by design.
@@ -302,16 +302,16 @@
302// a machine running the state server.302// a machine running the state server.
303func NewStateMachineConfig(configParams AgentConfigParams, serverInfo params.StateServingInfo) (ConfigSetterWriter, error) {303func NewStateMachineConfig(configParams AgentConfigParams, serverInfo params.StateServingInfo) (ConfigSetterWriter, error) {
304 if serverInfo.Cert == "" {304 if serverInfo.Cert == "" {
305 return nil, errgo.Trace(requiredError("state server cert"))305 return nil, errors.Trace(requiredError("state server cert"))
306 }306 }
307 if serverInfo.PrivateKey == "" {307 if serverInfo.PrivateKey == "" {
308 return nil, errgo.Trace(requiredError("state server key"))308 return nil, errors.Trace(requiredError("state server key"))
309 }309 }
310 if serverInfo.StatePort == 0 {310 if serverInfo.StatePort == 0 {
311 return nil, errgo.Trace(requiredError("state port"))311 return nil, errors.Trace(requiredError("state port"))
312 }312 }
313 if serverInfo.APIPort == 0 {313 if serverInfo.APIPort == 0 {
314 return nil, errgo.Trace(requiredError("api port"))314 return nil, errors.Trace(requiredError("api port"))
315 }315 }
316 config, err := NewAgentConfig(configParams)316 config, err := NewAgentConfig(configParams)
317 if err != nil {317 if err != nil {
@@ -535,7 +535,7 @@
535535
536func (c *configInternal) APIAddresses() ([]string, error) {536func (c *configInternal) APIAddresses() ([]string, error) {
537 if c.apiDetails == nil {537 if c.apiDetails == nil {
538 return []string{}, errgo.New("No apidetails in config")538 return []string{}, errors.New("No apidetails in config")
539 }539 }
540 return append([]string{}, c.apiDetails.addresses...), nil540 return append([]string{}, c.apiDetails.addresses...), nil
541}541}
@@ -554,7 +554,7 @@
554554
555func (c *configInternal) check() error {555func (c *configInternal) check() error {
556 if c.stateDetails == nil && c.apiDetails == nil {556 if c.stateDetails == nil && c.apiDetails == nil {
557 return errgo.Trace(requiredError("state or API addresses"))557 return errors.Trace(requiredError("state or API addresses"))
558 }558 }
559 if c.stateDetails != nil {559 if c.stateDetails != nil {
560 if err := checkAddrs(c.stateDetails.addresses, "state server address"); err != nil {560 if err := checkAddrs(c.stateDetails.addresses, "state server address"); err != nil {
@@ -573,11 +573,11 @@
573573
574func checkAddrs(addrs []string, what string) error {574func checkAddrs(addrs []string, what string) error {
575 if len(addrs) == 0 {575 if len(addrs) == 0 {
576 return errgo.Trace(requiredError(what))576 return errors.Trace(requiredError(what))
577 }577 }
578 for _, a := range addrs {578 for _, a := range addrs {
579 if !validAddr.MatchString(a) {579 if !validAddr.MatchString(a) {
580 return errgo.New("invalid %s %q", what, a)580 return errors.Errorf("invalid %s %q", what, a)
581 }581 }
582 }582 }
583 return nil583 return nil
584584
=== modified file 'agent/tools/toolsdir.go'
--- agent/tools/toolsdir.go 2014-03-14 01:16:20 +0000
+++ agent/tools/toolsdir.go 2014-05-15 02:28:23 +0000
@@ -15,7 +15,7 @@
15 "path"15 "path"
16 "strings"16 "strings"
1717
18 "github.com/errgo/errgo"18 "github.com/juju/errors"
1919
20 coretools "launchpad.net/juju-core/tools"20 coretools "launchpad.net/juju-core/tools"
21 "launchpad.net/juju-core/version"21 "launchpad.net/juju-core/version"
@@ -101,7 +101,7 @@
101 }101 }
102 name := path.Join(dir, hdr.Name)102 name := path.Join(dir, hdr.Name)
103 if err := writeFile(name, os.FileMode(hdr.Mode&0777), tr); err != nil {103 if err := writeFile(name, os.FileMode(hdr.Mode&0777), tr); err != nil {
104 return errgo.Annotatef(err, "tar extract %q failed", name)104 return errors.Annotatef(err, "tar extract %q failed", name)
105 }105 }
106 }106 }
107 toolsMetadataData, err := json.Marshal(tools)107 toolsMetadataData, err := json.Marshal(tools)
108108
=== modified file 'cert/cert.go'
--- cert/cert.go 2014-04-30 23:18:40 +0000
+++ cert/cert.go 2014-05-15 02:28:23 +0000
@@ -11,13 +11,12 @@
11 "crypto/x509"11 "crypto/x509"
12 "crypto/x509/pkix"12 "crypto/x509/pkix"
13 "encoding/pem"13 "encoding/pem"
14 "errors"
15 "fmt"14 "fmt"
16 "math/big"15 "math/big"
17 "net"16 "net"
18 "time"17 "time"
1918
20 "github.com/errgo/errgo"19 "github.com/juju/errors"
21)20)
2221
23var KeyBits = 102422var KeyBits = 1024
@@ -64,11 +63,11 @@
64func Verify(srvCertPEM, caCertPEM string, when time.Time) error {63func Verify(srvCertPEM, caCertPEM string, when time.Time) error {
65 caCert, err := ParseCert(caCertPEM)64 caCert, err := ParseCert(caCertPEM)
66 if err != nil {65 if err != nil {
67 return errgo.Annotate(err, "cannot parse CA certificate")66 return errors.Annotate(err, "cannot parse CA certificate")
68 }67 }
69 srvCert, err := ParseCert(srvCertPEM)68 srvCert, err := ParseCert(srvCertPEM)
70 if err != nil {69 if err != nil {
71 return errgo.Annotate(err, "cannot parse server certificate")70 return errors.Annotate(err, "cannot parse server certificate")
72 }71 }
73 pool := x509.NewCertPool()72 pool := x509.NewCertPool()
74 pool.AddCert(caCert)73 pool.AddCert(caCert)
7574
=== modified file 'cmd/juju/bootstrap_test.go'
--- cmd/juju/bootstrap_test.go 2014-05-12 05:23:59 +0000
+++ cmd/juju/bootstrap_test.go 2014-05-15 02:28:23 +0000
@@ -7,6 +7,7 @@
7 "fmt"7 "fmt"
8 "strings"8 "strings"
99
10 "github.com/juju/errors"
10 "github.com/juju/loggo"11 "github.com/juju/loggo"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
@@ -26,7 +27,6 @@
26 envtesting "launchpad.net/juju-core/environs/testing"27 envtesting "launchpad.net/juju-core/environs/testing"
27 envtools "launchpad.net/juju-core/environs/tools"28 envtools "launchpad.net/juju-core/environs/tools"
28 ttesting "launchpad.net/juju-core/environs/tools/testing"29 ttesting "launchpad.net/juju-core/environs/tools/testing"
29 "launchpad.net/juju-core/errors"
30 "launchpad.net/juju-core/juju/arch"30 "launchpad.net/juju-core/juju/arch"
31 "launchpad.net/juju-core/provider/dummy"31 "launchpad.net/juju-core/provider/dummy"
32 coretesting "launchpad.net/juju-core/testing"32 coretesting "launchpad.net/juju-core/testing"
3333
=== modified file 'cmd/juju/common.go'
--- cmd/juju/common.go 2014-04-14 12:36:13 +0000
+++ cmd/juju/common.go 2014-05-15 02:28:23 +0000
@@ -6,12 +6,13 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
10
9 "launchpad.net/juju-core/charm"11 "launchpad.net/juju-core/charm"
10 "launchpad.net/juju-core/cmd"12 "launchpad.net/juju-core/cmd"
11 "launchpad.net/juju-core/environs"13 "launchpad.net/juju-core/environs"
12 "launchpad.net/juju-core/environs/config"14 "launchpad.net/juju-core/environs/config"
13 "launchpad.net/juju-core/environs/configstore"15 "launchpad.net/juju-core/environs/configstore"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/state/api"16 "launchpad.net/juju-core/state/api"
16)17)
1718
1819
=== modified file 'cmd/juju/debuglog.go'
--- cmd/juju/debuglog.go 2014-05-12 05:23:59 +0000
+++ cmd/juju/debuglog.go 2014-05-15 02:28:23 +0000
@@ -7,12 +7,12 @@
7 "fmt"7 "fmt"
8 "io"8 "io"
99
10 "github.com/juju/errors"
10 "github.com/juju/loggo"11 "github.com/juju/loggo"
11 "launchpad.net/gnuflag"12 "launchpad.net/gnuflag"
1213
13 "launchpad.net/juju-core/cmd"14 "launchpad.net/juju-core/cmd"
14 "launchpad.net/juju-core/cmd/envcmd"15 "launchpad.net/juju-core/cmd/envcmd"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/juju"16 "launchpad.net/juju-core/juju"
17 "launchpad.net/juju-core/state/api"17 "launchpad.net/juju-core/state/api"
18)18)
1919
=== modified file 'cmd/juju/debuglog_test.go'
--- cmd/juju/debuglog_test.go 2014-05-12 05:23:59 +0000
+++ cmd/juju/debuglog_test.go 2014-05-15 02:28:23 +0000
@@ -9,13 +9,13 @@
9 "io/ioutil"9 "io/ioutil"
10 "strings"10 "strings"
1111
12 "github.com/juju/errors"
12 "github.com/juju/loggo"13 "github.com/juju/loggo"
13 jc "github.com/juju/testing/checkers"14 jc "github.com/juju/testing/checkers"
14 gc "launchpad.net/gocheck"15 gc "launchpad.net/gocheck"
1516
16 "launchpad.net/juju-core/cmd"17 "launchpad.net/juju-core/cmd"
17 "launchpad.net/juju-core/cmd/envcmd"18 "launchpad.net/juju-core/cmd/envcmd"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/state/api"19 "launchpad.net/juju-core/state/api"
20 "launchpad.net/juju-core/testing"20 "launchpad.net/juju-core/testing"
21)21)
2222
=== modified file 'cmd/juju/deploy_test.go'
--- cmd/juju/deploy_test.go 2014-05-12 04:28:39 +0000
+++ cmd/juju/deploy_test.go 2014-05-15 02:28:23 +0000
@@ -6,13 +6,13 @@
6import (6import (
7 "strings"7 "strings"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/charm"13 "launchpad.net/juju-core/charm"
13 "launchpad.net/juju-core/cmd/envcmd"14 "launchpad.net/juju-core/cmd/envcmd"
14 "launchpad.net/juju-core/constraints"15 "launchpad.net/juju-core/constraints"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/instance"16 "launchpad.net/juju-core/instance"
17 "launchpad.net/juju-core/juju/osenv"17 "launchpad.net/juju-core/juju/osenv"
18 "launchpad.net/juju-core/juju/testing"18 "launchpad.net/juju-core/juju/testing"
1919
=== modified file 'cmd/juju/destroyenvironment_test.go'
--- cmd/juju/destroyenvironment_test.go 2014-04-14 12:36:13 +0000
+++ cmd/juju/destroyenvironment_test.go 2014-05-15 02:28:23 +0000
@@ -6,13 +6,13 @@
6import (6import (
7 "bytes"7 "bytes"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/cmd"13 "launchpad.net/juju-core/cmd"
13 "launchpad.net/juju-core/environs"14 "launchpad.net/juju-core/environs"
14 "launchpad.net/juju-core/environs/configstore"15 "launchpad.net/juju-core/environs/configstore"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/instance"16 "launchpad.net/juju-core/instance"
17 "launchpad.net/juju-core/juju/testing"17 "launchpad.net/juju-core/juju/testing"
18 "launchpad.net/juju-core/provider/dummy"18 "launchpad.net/juju-core/provider/dummy"
1919
=== modified file 'cmd/juju/removemachine_test.go'
--- cmd/juju/removemachine_test.go 2014-05-12 05:23:59 +0000
+++ cmd/juju/removemachine_test.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4package main4package main
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 gc "launchpad.net/gocheck"9 gc "launchpad.net/gocheck"
910
10 "launchpad.net/juju-core/cmd/envcmd"11 "launchpad.net/juju-core/cmd/envcmd"
11 "launchpad.net/juju-core/errors"
12 jujutesting "launchpad.net/juju-core/juju/testing"12 jujutesting "launchpad.net/juju-core/juju/testing"
13 "launchpad.net/juju-core/state"13 "launchpad.net/juju-core/state"
14 "launchpad.net/juju-core/testing"14 "launchpad.net/juju-core/testing"
1515
=== modified file 'cmd/jujud/agent.go'
--- cmd/jujud/agent.go 2014-05-13 23:18:30 +0000
+++ cmd/jujud/agent.go 2014-05-15 02:28:23 +0000
@@ -10,11 +10,11 @@
10 "sync"10 "sync"
11 "time"11 "time"
1212
13 "github.com/juju/errors"
13 "launchpad.net/gnuflag"14 "launchpad.net/gnuflag"
1415
15 "launchpad.net/juju-core/agent"16 "launchpad.net/juju-core/agent"
16 "launchpad.net/juju-core/cmd"17 "launchpad.net/juju-core/cmd"
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/instance"18 "launchpad.net/juju-core/instance"
19 "launchpad.net/juju-core/state"19 "launchpad.net/juju-core/state"
20 "launchpad.net/juju-core/state/api"20 "launchpad.net/juju-core/state/api"
2121
=== modified file 'cmd/jujud/bootstrap_test.go'
--- cmd/jujud/bootstrap_test.go 2014-05-08 07:04:54 +0000
+++ cmd/jujud/bootstrap_test.go 2014-05-15 02:28:23 +0000
@@ -9,6 +9,7 @@
9 "io"9 "io"
10 "io/ioutil"10 "io/ioutil"
1111
12 "github.com/juju/errors"
12 jc "github.com/juju/testing/checkers"13 jc "github.com/juju/testing/checkers"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
14 "launchpad.net/goyaml"15 "launchpad.net/goyaml"
@@ -20,7 +21,6 @@
20 "launchpad.net/juju-core/environs/config"21 "launchpad.net/juju-core/environs/config"
21 "launchpad.net/juju-core/environs/configstore"22 "launchpad.net/juju-core/environs/configstore"
22 envtesting "launchpad.net/juju-core/environs/testing"23 envtesting "launchpad.net/juju-core/environs/testing"
23 "launchpad.net/juju-core/errors"
24 "launchpad.net/juju-core/instance"24 "launchpad.net/juju-core/instance"
25 jujutesting "launchpad.net/juju-core/juju/testing"25 jujutesting "launchpad.net/juju-core/juju/testing"
26 "launchpad.net/juju-core/provider/dummy"26 "launchpad.net/juju-core/provider/dummy"
2727
=== modified file 'cmd/jujud/machine.go'
--- cmd/jujud/machine.go 2014-05-13 23:18:30 +0000
+++ cmd/jujud/machine.go 2014-05-15 02:28:23 +0000
@@ -11,6 +11,7 @@
11 "runtime"11 "runtime"
12 "time"12 "time"
1313
14 "github.com/juju/errors"
14 "github.com/juju/loggo"15 "github.com/juju/loggo"
15 "labix.org/v2/mgo"16 "labix.org/v2/mgo"
16 "launchpad.net/gnuflag"17 "launchpad.net/gnuflag"
@@ -22,7 +23,6 @@
22 "launchpad.net/juju-core/cmd"23 "launchpad.net/juju-core/cmd"
23 "launchpad.net/juju-core/container/kvm"24 "launchpad.net/juju-core/container/kvm"
24 "launchpad.net/juju-core/environs"25 "launchpad.net/juju-core/environs"
25 "launchpad.net/juju-core/errors"
26 "launchpad.net/juju-core/instance"26 "launchpad.net/juju-core/instance"
27 "launchpad.net/juju-core/names"27 "launchpad.net/juju-core/names"
28 "launchpad.net/juju-core/provider"28 "launchpad.net/juju-core/provider"
2929
=== modified file 'cmd/jujud/machine_test.go'
--- cmd/jujud/machine_test.go 2014-04-18 04:39:58 +0000
+++ cmd/jujud/machine_test.go 2014-05-15 02:28:23 +0000
@@ -12,6 +12,7 @@
12 "sync"12 "sync"
13 "time"13 "time"
1414
15 "github.com/juju/errors"
15 "github.com/juju/testing"16 "github.com/juju/testing"
16 jc "github.com/juju/testing/checkers"17 jc "github.com/juju/testing/checkers"
17 gc "launchpad.net/gocheck"18 gc "launchpad.net/gocheck"
@@ -23,7 +24,6 @@
23 lxctesting "launchpad.net/juju-core/container/lxc/testing"24 lxctesting "launchpad.net/juju-core/container/lxc/testing"
24 "launchpad.net/juju-core/environs/config"25 "launchpad.net/juju-core/environs/config"
25 envtesting "launchpad.net/juju-core/environs/testing"26 envtesting "launchpad.net/juju-core/environs/testing"
26 "launchpad.net/juju-core/errors"
27 "launchpad.net/juju-core/instance"27 "launchpad.net/juju-core/instance"
28 "launchpad.net/juju-core/juju"28 "launchpad.net/juju-core/juju"
29 "launchpad.net/juju-core/juju/osenv"29 "launchpad.net/juju-core/juju/osenv"
3030
=== modified file 'constraints/constraints.go'
--- constraints/constraints.go 2014-04-24 11:52:09 +0000
+++ constraints/constraints.go 2014-05-15 02:28:23 +0000
@@ -10,7 +10,7 @@
10 "strconv"10 "strconv"
11 "strings"11 "strings"
1212
13 "github.com/errgo/errgo"13 "github.com/juju/errors"
1414
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/juju/arch"16 "launchpad.net/juju-core/juju/arch"
@@ -274,7 +274,7 @@
274 return fmt.Errorf("unknown constraint %q", name)274 return fmt.Errorf("unknown constraint %q", name)
275 }275 }
276 if err != nil {276 if err != nil {
277 return errgo.Annotatef(err, "bad %q constraint", name)277 return errors.Annotatef(err, "bad %q constraint", name)
278 }278 }
279 return nil279 return nil
280}280}
281281
=== modified file 'container/kvm/container.go'
--- container/kvm/container.go 2014-04-17 03:41:32 +0000
+++ container/kvm/container.go 2014-05-15 02:28:23 +0000
@@ -6,8 +6,9 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
10
9 "launchpad.net/juju-core/container"11 "launchpad.net/juju-core/container"
10 "launchpad.net/juju-core/errors"
11)12)
1213
13type kvmContainer struct {14type kvmContainer struct {
1415
=== modified file 'container/kvm/kvm.go'
--- container/kvm/kvm.go 2014-05-13 11:37:40 +0000
+++ container/kvm/kvm.go 2014-05-15 02:28:23 +0000
@@ -8,13 +8,13 @@
8 "os/exec"8 "os/exec"
9 "strings"9 "strings"
1010
11 "github.com/juju/errors"
11 "github.com/juju/loggo"12 "github.com/juju/loggo"
1213
13 "launchpad.net/juju-core/agent"14 "launchpad.net/juju-core/agent"
14 "launchpad.net/juju-core/constraints"15 "launchpad.net/juju-core/constraints"
15 "launchpad.net/juju-core/container"16 "launchpad.net/juju-core/container"
16 "launchpad.net/juju-core/environs/cloudinit"17 "launchpad.net/juju-core/environs/cloudinit"
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/instance"18 "launchpad.net/juju-core/instance"
19 "launchpad.net/juju-core/names"19 "launchpad.net/juju-core/names"
20 "launchpad.net/juju-core/version"20 "launchpad.net/juju-core/version"
2121
=== modified file 'container/lxc/instance.go'
--- container/lxc/instance.go 2014-04-14 12:36:13 +0000
+++ container/lxc/instance.go 2014-05-15 02:28:23 +0000
@@ -6,9 +6,9 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 "launchpad.net/golxc"10 "launchpad.net/golxc"
1011
11 "launchpad.net/juju-core/errors"
12 "launchpad.net/juju-core/instance"12 "launchpad.net/juju-core/instance"
13)13)
1414
1515
=== modified file 'dependencies.tsv'
--- dependencies.tsv 2014-05-13 11:37:40 +0000
+++ dependencies.tsv 2014-05-15 02:28:23 +0000
@@ -1,10 +1,11 @@
1code.google.com/p/go.crypto hg 6478cc9340cbbe6c04511280c5007722269108e9 1841code.google.com/p/go.crypto hg 6478cc9340cbbe6c04511280c5007722269108e9 184
2code.google.com/p/go.net hg c17ad62118ea511e1051721b429779fa40bddc74 1162code.google.com/p/go.net hg c17ad62118ea511e1051721b429779fa40bddc74 116
3github.com/errgo/errgo git 93d72bf813883d1054cae1c001d3a46603f7f559
4github.com/joyent/gocommon git 98b151a080efe19bcde223d2d3b04389963d2347 3github.com/joyent/gocommon git 98b151a080efe19bcde223d2d3b04389963d2347
5github.com/joyent/gomanta git ff785814c0ebb4050420a2f1d47895b35b8808f2 4github.com/joyent/gomanta git ff785814c0ebb4050420a2f1d47895b35b8808f2
6github.com/joyent/gosdc git 10bbe92c5d98c8b38a0b7f62ee042c7252150efc 5github.com/joyent/gosdc git 10bbe92c5d98c8b38a0b7f62ee042c7252150efc
7github.com/joyent/gosign git 476720af5427223da5420afbbadf620bfb760345 6github.com/joyent/gosign git 476720af5427223da5420afbbadf620bfb760345
7github.com/juju/errgo git 96d8f88c102000c1e7150b957c7c493911519338
8github.com/juju/errors git 075df0417dbcc39d24ee18248d2f8d6e3eed598b
8github.com/juju/loggo git fa3acf9ab9ed09aea29030558528e24a254d27af 9github.com/juju/loggo git fa3acf9ab9ed09aea29030558528e24a254d27af
9github.com/juju/ratelimit git 0025ab75db6c6eaa4ffff0240c2c9e617ad1a0eb 10github.com/juju/ratelimit git 0025ab75db6c6eaa4ffff0240c2c9e617ad1a0eb
10github.com/juju/testing git 9c0e0686136637876ae659e9056897575236e11f 11github.com/juju/testing git 9c0e0686136637876ae659e9056897575236e11f
1112
=== modified file 'environs/bootstrap/state.go'
--- environs/bootstrap/state.go 2014-04-14 12:36:13 +0000
+++ environs/bootstrap/state.go 2014-05-15 02:28:23 +0000
@@ -9,11 +9,11 @@
9 "io"9 "io"
10 "io/ioutil"10 "io/ioutil"
1111
12 "github.com/juju/errors"
12 "launchpad.net/goyaml"13 "launchpad.net/goyaml"
1314
14 "launchpad.net/juju-core/environs"15 "launchpad.net/juju-core/environs"
15 "launchpad.net/juju-core/environs/storage"16 "launchpad.net/juju-core/environs/storage"
16 coreerrors "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/instance"17 "launchpad.net/juju-core/instance"
18)18)
1919
@@ -65,7 +65,7 @@
65func LoadState(stor storage.StorageReader) (*BootstrapState, error) {65func LoadState(stor storage.StorageReader) (*BootstrapState, error) {
66 r, err := storage.Get(stor, StateFile)66 r, err := storage.Get(stor, StateFile)
67 if err != nil {67 if err != nil {
68 if coreerrors.IsNotFound(err) {68 if errors.IsNotFound(err) {
69 return nil, environs.ErrNotBootstrapped69 return nil, environs.ErrNotBootstrapped
70 }70 }
71 return nil, err71 return nil, err
7272
=== modified file 'environs/bootstrap/synctools.go'
--- environs/bootstrap/synctools.go 2014-05-13 23:18:30 +0000
+++ environs/bootstrap/synctools.go 2014-05-15 02:28:23 +0000
@@ -7,11 +7,12 @@
7 "fmt"7 "fmt"
8 "os"8 "os"
99
10 "github.com/juju/errors"
11
10 "launchpad.net/juju-core/environs"12 "launchpad.net/juju-core/environs"
11 "launchpad.net/juju-core/environs/config"13 "launchpad.net/juju-core/environs/config"
12 "launchpad.net/juju-core/environs/sync"14 "launchpad.net/juju-core/environs/sync"
13 envtools "launchpad.net/juju-core/environs/tools"15 envtools "launchpad.net/juju-core/environs/tools"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/juju/arch"16 "launchpad.net/juju-core/juju/arch"
16 coretools "launchpad.net/juju-core/tools"17 coretools "launchpad.net/juju-core/tools"
17 "launchpad.net/juju-core/utils/set"18 "launchpad.net/juju-core/utils/set"
1819
=== modified file 'environs/cloudinit.go'
--- environs/cloudinit.go 2014-04-23 08:50:28 +0000
+++ environs/cloudinit.go 2014-05-15 02:28:23 +0000
@@ -6,14 +6,13 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/errgo/errgo"9 "github.com/juju/errors"
1010
11 "launchpad.net/juju-core/agent"11 "launchpad.net/juju-core/agent"
12 coreCloudinit "launchpad.net/juju-core/cloudinit"12 coreCloudinit "launchpad.net/juju-core/cloudinit"
13 "launchpad.net/juju-core/constraints"13 "launchpad.net/juju-core/constraints"
14 "launchpad.net/juju-core/environs/cloudinit"14 "launchpad.net/juju-core/environs/cloudinit"
15 "launchpad.net/juju-core/environs/config"15 "launchpad.net/juju-core/environs/config"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/juju/osenv"16 "launchpad.net/juju-core/juju/osenv"
18 "launchpad.net/juju-core/names"17 "launchpad.net/juju-core/names"
19 "launchpad.net/juju-core/state"18 "launchpad.net/juju-core/state"
@@ -141,7 +140,7 @@
141 // These really are directly relevant to running a state server.140 // These really are directly relevant to running a state server.
142 cert, key, err := cfg.GenerateStateServerCertAndKey()141 cert, key, err := cfg.GenerateStateServerCertAndKey()
143 if err != nil {142 if err != nil {
144 return errgo.Annotate(err, "cannot generate state server certificate")143 return errors.Annotate(err, "cannot generate state server certificate")
145 }144 }
146145
147 srvInfo := params.StateServingInfo{146 srvInfo := params.StateServingInfo{
148147
=== modified file 'environs/cloudinit/cloudinit.go'
--- environs/cloudinit/cloudinit.go 2014-04-23 08:50:28 +0000
+++ environs/cloudinit/cloudinit.go 2014-05-15 02:28:23 +0000
@@ -10,7 +10,7 @@
10 "path"10 "path"
11 "strings"11 "strings"
1212
13 "github.com/errgo/errgo"13 "github.com/juju/errors"
14 "launchpad.net/goyaml"14 "launchpad.net/goyaml"
1515
16 "launchpad.net/juju-core/agent"16 "launchpad.net/juju-core/agent"
@@ -18,7 +18,6 @@
18 "launchpad.net/juju-core/cloudinit"18 "launchpad.net/juju-core/cloudinit"
19 "launchpad.net/juju-core/constraints"19 "launchpad.net/juju-core/constraints"
20 "launchpad.net/juju-core/environs/config"20 "launchpad.net/juju-core/environs/config"
21 "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/instance"21 "launchpad.net/juju-core/instance"
23 "launchpad.net/juju-core/juju/osenv"22 "launchpad.net/juju-core/juju/osenv"
24 "launchpad.net/juju-core/names"23 "launchpad.net/juju-core/names"
@@ -405,7 +404,7 @@
405 acfg.SetValue(agent.AgentServiceName, cfg.MachineAgentServiceName)404 acfg.SetValue(agent.AgentServiceName, cfg.MachineAgentServiceName)
406 cmds, err := acfg.WriteCommands()405 cmds, err := acfg.WriteCommands()
407 if err != nil {406 if err != nil {
408 return nil, errgo.Annotate(err, "failed to write commands")407 return nil, errors.Annotate(err, "failed to write commands")
409 }408 }
410 c.AddScripts(cmds...)409 c.AddScripts(cmds...)
411 return acfg, nil410 return acfg, nil
@@ -423,7 +422,7 @@
423 conf := upstart.MachineAgentUpstartService(name, toolsDir, cfg.DataDir, cfg.LogDir, tag, machineId, nil)422 conf := upstart.MachineAgentUpstartService(name, toolsDir, cfg.DataDir, cfg.LogDir, tag, machineId, nil)
424 cmds, err := conf.InstallCommands()423 cmds, err := conf.InstallCommands()
425 if err != nil {424 if err != nil {
426 return errgo.Annotatef(err, "cannot make cloud-init upstart script for the %s agent", tag)425 return errors.Annotatef(err, "cannot make cloud-init upstart script for the %s agent", tag)
427 }426 }
428 c.AddRunCmd(cloudinit.LogProgressCmd("Starting Juju machine agent (%s)", name))427 c.AddRunCmd(cloudinit.LogProgressCmd("Starting Juju machine agent (%s)", name))
429 c.AddScripts(cmds...)428 c.AddScripts(cmds...)
430429
=== modified file 'environs/config.go'
--- environs/config.go 2014-03-07 23:03:04 +0000
+++ environs/config.go 2014-05-15 02:28:23 +0000
@@ -9,11 +9,11 @@
9 "os"9 "os"
10 "path/filepath"10 "path/filepath"
1111
12 "github.com/juju/errors"
12 "github.com/juju/loggo"13 "github.com/juju/loggo"
13 "launchpad.net/goyaml"14 "launchpad.net/goyaml"
1415
15 "launchpad.net/juju-core/environs/config"16 "launchpad.net/juju-core/environs/config"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/juju/osenv"17 "launchpad.net/juju-core/juju/osenv"
18)18)
1919
2020
=== modified file 'environs/config/config.go'
--- environs/config/config.go 2014-05-09 13:24:50 +0000
+++ environs/config/config.go 2014-05-15 02:28:23 +0000
@@ -13,7 +13,7 @@
13 "strings"13 "strings"
14 "time"14 "time"
1515
16 "github.com/errgo/errgo"16 "github.com/juju/errors"
17 "github.com/juju/loggo"17 "github.com/juju/loggo"
1818
19 "launchpad.net/juju-core/cert"19 "launchpad.net/juju-core/cert"
@@ -320,7 +320,7 @@
320 caKey, caKeyOK := cfg.CAPrivateKey()320 caKey, caKeyOK := cfg.CAPrivateKey()
321 if caCertOK || caKeyOK {321 if caCertOK || caKeyOK {
322 if err := verifyKeyPair(caCert, caKey); err != nil {322 if err := verifyKeyPair(caCert, caKey); err != nil {
323 return errgo.Annotate(err, "bad CA certificate/key in configuration")323 return errors.Annotate(err, "bad CA certificate/key in configuration")
324 }324 }
325 }325 }
326326
327327
=== modified file 'environs/configstore/disk.go'
--- environs/configstore/disk.go 2014-04-30 23:18:40 +0000
+++ environs/configstore/disk.go 2014-05-15 02:28:23 +0000
@@ -9,11 +9,10 @@
9 "os"9 "os"
10 "path/filepath"10 "path/filepath"
1111
12 "github.com/errgo/errgo"12 "github.com/juju/errors"
13 "github.com/juju/loggo"13 "github.com/juju/loggo"
14 "launchpad.net/goyaml"14 "launchpad.net/goyaml"
1515
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/juju/osenv"16 "launchpad.net/juju-core/juju/osenv"
18 "launchpad.net/juju-core/utils"17 "launchpad.net/juju-core/utils"
19)18)
@@ -173,14 +172,14 @@
173func (info *environInfo) Write() error {172func (info *environInfo) Write() error {
174 data, err := goyaml.Marshal(info.EnvInfo)173 data, err := goyaml.Marshal(info.EnvInfo)
175 if err != nil {174 if err != nil {
176 return errgo.Annotate(err, "cannot marshal environment info")175 return errors.Annotate(err, "cannot marshal environment info")
177 }176 }
178 // Create a temporary file and rename it, so that the data177 // Create a temporary file and rename it, so that the data
179 // changes atomically.178 // changes atomically.
180 parent, _ := filepath.Split(info.path)179 parent, _ := filepath.Split(info.path)
181 tmpFile, err := ioutil.TempFile(parent, "")180 tmpFile, err := ioutil.TempFile(parent, "")
182 if err != nil {181 if err != nil {
183 return errgo.Annotate(err, "cannot create temporary file")182 return errors.Annotate(err, "cannot create temporary file")
184 }183 }
185 _, err = tmpFile.Write(data)184 _, err = tmpFile.Write(data)
186 // N.B. We need to close the file before renaming it185 // N.B. We need to close the file before renaming it
@@ -188,11 +187,11 @@
188 // error.187 // error.
189 tmpFile.Close()188 tmpFile.Close()
190 if err != nil {189 if err != nil {
191 return errgo.Annotate(err, "cannot write temporary file")190 return errors.Annotate(err, "cannot write temporary file")
192 }191 }
193 if err := utils.ReplaceFile(tmpFile.Name(), info.path); err != nil {192 if err := utils.ReplaceFile(tmpFile.Name(), info.path); err != nil {
194 os.Remove(tmpFile.Name())193 os.Remove(tmpFile.Name())
195 return errgo.Annotate(err, "cannot rename new environment info file")194 return errors.Annotate(err, "cannot rename new environment info file")
196 }195 }
197 info.initialized = true196 info.initialized = true
198 return nil197 return nil
199198
=== modified file 'environs/configstore/disk_test.go'
--- environs/configstore/disk_test.go 2014-04-14 12:36:13 +0000
+++ environs/configstore/disk_test.go 2014-05-15 02:28:23 +0000
@@ -12,11 +12,11 @@
12 "strings"12 "strings"
13 "syscall"13 "syscall"
1414
15 "github.com/juju/errors"
15 jc "github.com/juju/testing/checkers"16 jc "github.com/juju/testing/checkers"
16 gc "launchpad.net/gocheck"17 gc "launchpad.net/gocheck"
1718
18 "launchpad.net/juju-core/environs/configstore"19 "launchpad.net/juju-core/environs/configstore"
19 "launchpad.net/juju-core/errors"
20 "launchpad.net/juju-core/testing/testbase"20 "launchpad.net/juju-core/testing/testbase"
21)21)
2222
2323
=== modified file 'environs/configstore/mem.go'
--- environs/configstore/mem.go 2014-03-27 17:05:00 +0000
+++ environs/configstore/mem.go 2014-05-15 02:28:23 +0000
@@ -7,7 +7,7 @@
7 "fmt"7 "fmt"
8 "sync"8 "sync"
99
10 "launchpad.net/juju-core/errors"10 "github.com/juju/errors"
11)11)
1212
13type memStore struct {13type memStore struct {
1414
=== modified file 'environs/emptystorage.go'
--- environs/emptystorage.go 2013-10-03 01:28:51 +0000
+++ environs/emptystorage.go 2014-05-15 02:28:23 +0000
@@ -7,8 +7,9 @@
7 "fmt"7 "fmt"
8 "io"8 "io"
99
10 "github.com/juju/errors"
11
10 "launchpad.net/juju-core/environs/storage"12 "launchpad.net/juju-core/environs/storage"
11 "launchpad.net/juju-core/errors"
12 "launchpad.net/juju-core/utils"13 "launchpad.net/juju-core/utils"
13)14)
1415
1516
=== modified file 'environs/emptystorage_test.go'
--- environs/emptystorage_test.go 2014-02-13 02:46:58 +0000
+++ environs/emptystorage_test.go 2014-05-15 02:28:23 +0000
@@ -6,12 +6,12 @@
6import (6import (
7 "io/ioutil"7 "io/ioutil"
88
9 "github.com/juju/errors"
9 gc "launchpad.net/gocheck"10 gc "launchpad.net/gocheck"
1011
11 "launchpad.net/juju-core/environs"12 "launchpad.net/juju-core/environs"
12 "launchpad.net/juju-core/environs/configstore"13 "launchpad.net/juju-core/environs/configstore"
13 "launchpad.net/juju-core/environs/storage"14 "launchpad.net/juju-core/environs/storage"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/provider/dummy"15 "launchpad.net/juju-core/provider/dummy"
16 "launchpad.net/juju-core/testing"16 "launchpad.net/juju-core/testing"
17 "launchpad.net/juju-core/testing/testbase"17 "launchpad.net/juju-core/testing/testbase"
1818
=== modified file 'environs/filestorage/filestorage.go'
--- environs/filestorage/filestorage.go 2014-04-30 23:18:40 +0000
+++ environs/filestorage/filestorage.go 2014-05-15 02:28:23 +0000
@@ -12,8 +12,9 @@
12 "sort"12 "sort"
13 "strings"13 "strings"
1414
15 "github.com/juju/errors"
16
15 "launchpad.net/juju-core/environs/storage"17 "launchpad.net/juju-core/environs/storage"
16 coreerrors "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/utils"18 "launchpad.net/juju-core/utils"
18)19)
1920
@@ -60,11 +61,11 @@
60 fi, err := os.Stat(filename)61 fi, err := os.Stat(filename)
61 if err != nil {62 if err != nil {
62 if os.IsNotExist(err) {63 if os.IsNotExist(err) {
63 err = coreerrors.NewNotFound(err, "")64 err = errors.NewNotFound(err, "")
64 }65 }
65 return nil, err66 return nil, err
66 } else if fi.IsDir() {67 } else if fi.IsDir() {
67 return nil, coreerrors.NotFoundf("no such file with name %q", name)68 return nil, errors.NotFoundf("no such file with name %q", name)
68 }69 }
69 file, err := os.Open(filename)70 file, err := os.Open(filename)
70 if err != nil {71 if err != nil {
7172
=== modified file 'environs/filestorage/filestorage_test.go'
--- environs/filestorage/filestorage_test.go 2014-04-14 12:36:13 +0000
+++ environs/filestorage/filestorage_test.go 2014-05-15 02:28:23 +0000
@@ -15,12 +15,12 @@
15 "strings"15 "strings"
16 "testing"16 "testing"
1717
18 "github.com/juju/errors"
18 jc "github.com/juju/testing/checkers"19 jc "github.com/juju/testing/checkers"
19 gc "launchpad.net/gocheck"20 gc "launchpad.net/gocheck"
2021
21 "launchpad.net/juju-core/environs/filestorage"22 "launchpad.net/juju-core/environs/filestorage"
22 "launchpad.net/juju-core/environs/storage"23 "launchpad.net/juju-core/environs/storage"
23 coreerrors "launchpad.net/juju-core/errors"
24 "launchpad.net/juju-core/juju/osenv"24 "launchpad.net/juju-core/juju/osenv"
25)25)
2626
@@ -132,12 +132,12 @@
132132
133 // Get on a non-existant path returns errors.NotFound133 // Get on a non-existant path returns errors.NotFound
134 _, err = s.reader.Get("nowhere")134 _, err = s.reader.Get("nowhere")
135 c.Assert(err, jc.Satisfies, coreerrors.IsNotFound)135 c.Assert(err, jc.Satisfies, errors.IsNotFound)
136136
137 // Get on a directory returns errors.NotFound137 // Get on a directory returns errors.NotFound
138 s.createFile(c, "dir/file")138 s.createFile(c, "dir/file")
139 _, err = s.reader.Get("dir")139 _, err = s.reader.Get("dir")
140 c.Assert(err, jc.Satisfies, coreerrors.IsNotFound)140 c.Assert(err, jc.Satisfies, errors.IsNotFound)
141}141}
142142
143func (s *filestorageSuite) TestGetRefusesTemp(c *gc.C) {143func (s *filestorageSuite) TestGetRefusesTemp(c *gc.C) {
144144
=== modified file 'environs/httpstorage/storage.go'
--- environs/httpstorage/storage.go 2014-04-30 23:18:40 +0000
+++ environs/httpstorage/storage.go 2014-05-15 02:28:23 +0000
@@ -6,7 +6,6 @@
6import (6import (
7 "crypto/tls"7 "crypto/tls"
8 "crypto/x509"8 "crypto/x509"
9 "errors"
10 "fmt"9 "fmt"
11 "io"10 "io"
12 "io/ioutil"11 "io/ioutil"
@@ -16,10 +15,10 @@
16 "strings"15 "strings"
17 "sync"16 "sync"
1817
18 "github.com/juju/errors"
19 "github.com/juju/loggo"19 "github.com/juju/loggo"
2020
21 "launchpad.net/juju-core/environs/storage"21 "launchpad.net/juju-core/environs/storage"
22 coreerrors "launchpad.net/juju-core/errors"
23 "launchpad.net/juju-core/utils"22 "launchpad.net/juju-core/utils"
24)23)
2524
@@ -96,7 +95,7 @@
96 return nil, err95 return nil, err
97 }96 }
98 if resp.StatusCode != http.StatusOK {97 if resp.StatusCode != http.StatusOK {
99 return nil, coreerrors.NotFoundf("file %q", name)98 return nil, errors.NotFoundf("file %q", name)
100 }99 }
101 return resp.Body, nil100 return resp.Body, nil
102}101}
103102
=== modified file 'environs/httpstorage/storage_test.go'
--- environs/httpstorage/storage_test.go 2014-04-14 12:36:13 +0000
+++ environs/httpstorage/storage_test.go 2014-05-15 02:28:23 +0000
@@ -11,12 +11,12 @@
11 "net/http"11 "net/http"
12 "path/filepath"12 "path/filepath"
1313
14 "github.com/juju/errors"
14 jc "github.com/juju/testing/checkers"15 jc "github.com/juju/testing/checkers"
15 gc "launchpad.net/gocheck"16 gc "launchpad.net/gocheck"
1617
17 "launchpad.net/juju-core/environs/httpstorage"18 "launchpad.net/juju-core/environs/httpstorage"
18 "launchpad.net/juju-core/environs/storage"19 "launchpad.net/juju-core/environs/storage"
19 "launchpad.net/juju-core/errors"
20 coretesting "launchpad.net/juju-core/testing"20 coretesting "launchpad.net/juju-core/testing"
21)21)
2222
2323
=== modified file 'environs/imagemetadata/generate.go'
--- environs/imagemetadata/generate.go 2014-05-13 23:18:30 +0000
+++ environs/imagemetadata/generate.go 2014-05-15 02:28:23 +0000
@@ -9,9 +9,10 @@
9 "path/filepath"9 "path/filepath"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
13
12 "launchpad.net/juju-core/environs/simplestreams"14 "launchpad.net/juju-core/environs/simplestreams"
13 "launchpad.net/juju-core/environs/storage"15 "launchpad.net/juju-core/environs/storage"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/version/ubuntu"16 "launchpad.net/juju-core/version/ubuntu"
16)17)
1718
1819
=== modified file 'environs/jujutest/livetests.go'
--- environs/jujutest/livetests.go 2014-05-14 02:59:53 +0000
+++ environs/jujutest/livetests.go 2014-05-15 02:28:23 +0000
@@ -11,6 +11,7 @@
11 "strings"11 "strings"
12 "time"12 "time"
1313
14 "github.com/juju/errors"
14 jc "github.com/juju/testing/checkers"15 jc "github.com/juju/testing/checkers"
15 gc "launchpad.net/gocheck"16 gc "launchpad.net/gocheck"
1617
@@ -24,7 +25,6 @@
24 "launchpad.net/juju-core/environs/sync"25 "launchpad.net/juju-core/environs/sync"
25 envtesting "launchpad.net/juju-core/environs/testing"26 envtesting "launchpad.net/juju-core/environs/testing"
26 envtools "launchpad.net/juju-core/environs/tools"27 envtools "launchpad.net/juju-core/environs/tools"
27 "launchpad.net/juju-core/errors"
28 "launchpad.net/juju-core/instance"28 "launchpad.net/juju-core/instance"
29 "launchpad.net/juju-core/juju"29 "launchpad.net/juju-core/juju"
30 "launchpad.net/juju-core/juju/testing"30 "launchpad.net/juju-core/juju/testing"
3131
=== modified file 'environs/jujutest/tests.go'
--- environs/jujutest/tests.go 2014-05-14 02:59:53 +0000
+++ environs/jujutest/tests.go 2014-05-15 02:28:23 +0000
@@ -9,6 +9,7 @@
9 "net/http"9 "net/http"
10 "sort"10 "sort"
1111
12 "github.com/juju/errors"
12 jc "github.com/juju/testing/checkers"13 jc "github.com/juju/testing/checkers"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
1415
@@ -18,7 +19,6 @@
18 "launchpad.net/juju-core/environs/configstore"19 "launchpad.net/juju-core/environs/configstore"
19 "launchpad.net/juju-core/environs/storage"20 "launchpad.net/juju-core/environs/storage"
20 envtesting "launchpad.net/juju-core/environs/testing"21 envtesting "launchpad.net/juju-core/environs/testing"
21 "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/instance"22 "launchpad.net/juju-core/instance"
23 "launchpad.net/juju-core/juju/testing"23 "launchpad.net/juju-core/juju/testing"
24 coretesting "launchpad.net/juju-core/testing"24 coretesting "launchpad.net/juju-core/testing"
2525
=== modified file 'environs/open.go'
--- environs/open.go 2014-04-14 12:36:13 +0000
+++ environs/open.go 2014-05-15 02:28:23 +0000
@@ -9,13 +9,12 @@
9 "strings"9 "strings"
10 "time"10 "time"
1111
12 "github.com/errgo/errgo"12 "github.com/juju/errors"
1313
14 "launchpad.net/juju-core/cert"14 "launchpad.net/juju-core/cert"
15 "launchpad.net/juju-core/environs/config"15 "launchpad.net/juju-core/environs/config"
16 "launchpad.net/juju-core/environs/configstore"16 "launchpad.net/juju-core/environs/configstore"
17 "launchpad.net/juju-core/environs/storage"17 "launchpad.net/juju-core/environs/storage"
18 "launchpad.net/juju-core/errors"
19)18)
2019
21// File named `VerificationFilename` in the storage will contain20// File named `VerificationFilename` in the storage will contain
@@ -274,7 +273,7 @@
274 return err273 return err
275 }274 }
276 if err := info.Destroy(); err != nil {275 if err := info.Destroy(); err != nil {
277 return errgo.Annotate(err, "cannot destroy environment configuration information")276 return errors.Annotate(err, "cannot destroy environment configuration information")
278 }277 }
279 return nil278 return nil
280}279}
281280
=== modified file 'environs/open_test.go'
--- environs/open_test.go 2014-04-24 02:27:38 +0000
+++ environs/open_test.go 2014-05-15 02:28:23 +0000
@@ -6,6 +6,7 @@
6import (6import (
7 "strings"7 "strings"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
@@ -15,7 +16,6 @@
15 "launchpad.net/juju-core/environs/config"16 "launchpad.net/juju-core/environs/config"
16 "launchpad.net/juju-core/environs/configstore"17 "launchpad.net/juju-core/environs/configstore"
17 envtesting "launchpad.net/juju-core/environs/testing"18 envtesting "launchpad.net/juju-core/environs/testing"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/provider/dummy"19 "launchpad.net/juju-core/provider/dummy"
20 "launchpad.net/juju-core/testing"20 "launchpad.net/juju-core/testing"
21 "launchpad.net/juju-core/testing/testbase"21 "launchpad.net/juju-core/testing/testbase"
2222
=== modified file 'environs/simplestreams/datasource.go'
--- environs/simplestreams/datasource.go 2014-03-21 03:27:16 +0000
+++ environs/simplestreams/datasource.go 2014-05-15 02:28:23 +0000
@@ -9,7 +9,8 @@
9 "net/http"9 "net/http"
10 "strings"10 "strings"
1111
12 "launchpad.net/juju-core/errors"12 "github.com/juju/errors"
13
13 "launchpad.net/juju-core/utils"14 "launchpad.net/juju-core/utils"
14)15)
1516
1617
=== modified file 'environs/simplestreams/simplestreams.go'
--- environs/simplestreams/simplestreams.go 2014-05-13 23:18:30 +0000
+++ environs/simplestreams/simplestreams.go 2014-05-15 02:28:23 +0000
@@ -18,9 +18,9 @@
18 "sort"18 "sort"
19 "strings"19 "strings"
2020
21 "github.com/juju/errors"
21 "github.com/juju/loggo"22 "github.com/juju/loggo"
2223
23 "launchpad.net/juju-core/errors"
24 "launchpad.net/juju-core/utils"24 "launchpad.net/juju-core/utils"
25)25)
2626
2727
=== modified file 'environs/sshstorage/storage.go'
--- environs/sshstorage/storage.go 2014-04-14 12:36:13 +0000
+++ environs/sshstorage/storage.go 2014-05-15 02:28:23 +0000
@@ -7,7 +7,6 @@
7 "bufio"7 "bufio"
8 "bytes"8 "bytes"
9 "encoding/base64"9 "encoding/base64"
10 "errors"
11 "fmt"10 "fmt"
12 "io"11 "io"
13 "io/ioutil"12 "io/ioutil"
@@ -16,9 +15,9 @@
16 "strconv"15 "strconv"
17 "strings"16 "strings"
1817
18 "github.com/juju/errors"
19 "github.com/juju/loggo"19 "github.com/juju/loggo"
2020
21 coreerrors "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/utils"21 "launchpad.net/juju-core/utils"
23 "launchpad.net/juju-core/utils/ssh"22 "launchpad.net/juju-core/utils/ssh"
24)23)
@@ -253,7 +252,7 @@
253 if err != nil {252 if err != nil {
254 err := err.(SSHStorageError)253 err := err.(SSHStorageError)
255 if strings.Contains(err.Output, "No such file") {254 if strings.Contains(err.Output, "No such file") {
256 return nil, coreerrors.NewNotFound(err, "")255 return nil, errors.NewNotFound(err, "")
257 }256 }
258 return nil, err257 return nil, err
259 }258 }
260259
=== modified file 'environs/sshstorage/storage_test.go'
--- environs/sshstorage/storage_test.go 2014-04-14 12:36:13 +0000
+++ environs/sshstorage/storage_test.go 2014-05-15 02:28:23 +0000
@@ -16,12 +16,12 @@
16 "strings"16 "strings"
17 "time"17 "time"
1818
19 "github.com/juju/errors"
19 "github.com/juju/testing"20 "github.com/juju/testing"
20 jc "github.com/juju/testing/checkers"21 jc "github.com/juju/testing/checkers"
21 gc "launchpad.net/gocheck"22 gc "launchpad.net/gocheck"
2223
23 "launchpad.net/juju-core/environs/storage"24 "launchpad.net/juju-core/environs/storage"
24 coreerrors "launchpad.net/juju-core/errors"
25 "launchpad.net/juju-core/testing/testbase"25 "launchpad.net/juju-core/testing/testbase"
26 "launchpad.net/juju-core/utils"26 "launchpad.net/juju-core/utils"
27 "launchpad.net/juju-core/utils/ssh"27 "launchpad.net/juju-core/utils/ssh"
@@ -164,7 +164,7 @@
164 c.Assert(out, gc.DeepEquals, data)164 c.Assert(out, gc.DeepEquals, data)
165 }165 }
166 _, err = storage.Get(stor, "notthere")166 _, err = storage.Get(stor, "notthere")
167 c.Assert(err, jc.Satisfies, coreerrors.IsNotFound)167 c.Assert(err, jc.Satisfies, errors.IsNotFound)
168}168}
169169
170func (s *storageSuite) TestWriteFailure(c *gc.C) {170func (s *storageSuite) TestWriteFailure(c *gc.C) {
171171
=== modified file 'environs/tools/simplestreams.go'
--- environs/tools/simplestreams.go 2014-05-13 23:18:30 +0000
+++ environs/tools/simplestreams.go 2014-05-15 02:28:23 +0000
@@ -17,9 +17,10 @@
17 "strings"17 "strings"
18 "time"18 "time"
1919
20 "github.com/juju/errors"
21
20 "launchpad.net/juju-core/environs/simplestreams"22 "launchpad.net/juju-core/environs/simplestreams"
21 "launchpad.net/juju-core/environs/storage"23 "launchpad.net/juju-core/environs/storage"
22 "launchpad.net/juju-core/errors"
23 coretools "launchpad.net/juju-core/tools"24 coretools "launchpad.net/juju-core/tools"
24 "launchpad.net/juju-core/utils/set"25 "launchpad.net/juju-core/utils/set"
25 "launchpad.net/juju-core/version"26 "launchpad.net/juju-core/version"
2627
=== modified file 'environs/tools/tools.go'
--- environs/tools/tools.go 2014-05-13 23:18:30 +0000
+++ environs/tools/tools.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 "github.com/juju/loggo"10 "github.com/juju/loggo"
1011
11 "launchpad.net/juju-core/environs"12 "launchpad.net/juju-core/environs"
12 "launchpad.net/juju-core/environs/simplestreams"13 "launchpad.net/juju-core/environs/simplestreams"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/juju/arch"14 "launchpad.net/juju-core/juju/arch"
15 coretools "launchpad.net/juju-core/tools"15 coretools "launchpad.net/juju-core/tools"
16 "launchpad.net/juju-core/version"16 "launchpad.net/juju-core/version"
1717
=== modified file 'environs/tools/tools_test.go'
--- environs/tools/tools_test.go 2014-04-14 12:36:13 +0000
+++ environs/tools/tools_test.go 2014-05-15 02:28:23 +0000
@@ -8,6 +8,7 @@
8 "os"8 "os"
9 "path/filepath"9 "path/filepath"
1010
11 "github.com/juju/errors"
11 "github.com/juju/loggo"12 "github.com/juju/loggo"
12 jc "github.com/juju/testing/checkers"13 jc "github.com/juju/testing/checkers"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
@@ -18,7 +19,6 @@
18 envtesting "launchpad.net/juju-core/environs/testing"19 envtesting "launchpad.net/juju-core/environs/testing"
19 envtools "launchpad.net/juju-core/environs/tools"20 envtools "launchpad.net/juju-core/environs/tools"
20 ttesting "launchpad.net/juju-core/environs/tools/testing"21 ttesting "launchpad.net/juju-core/environs/tools/testing"
21 "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/provider/dummy"22 "launchpad.net/juju-core/provider/dummy"
23 "launchpad.net/juju-core/testing"23 "launchpad.net/juju-core/testing"
24 "launchpad.net/juju-core/testing/testbase"24 "launchpad.net/juju-core/testing/testbase"
2525
=== removed directory 'errors'
=== removed file 'errors/errors.go'
--- errors/errors.go 2014-04-17 12:53:23 +0000
+++ errors/errors.go 1970-01-01 00:00:00 +0000
@@ -1,210 +0,0 @@
1// Copyright 2013 Canonical Ltd.
2// Licensed under the AGPLv3, see LICENCE file for details.
3
4package errors
5
6import (
7 "fmt"
8
9 "github.com/juju/loggo"
10)
11
12// wrapper defines a way to encapsulate an error inside another error.
13type wrapper struct {
14 // Err is the underlying error.
15 err error
16
17 // Msg is the annotation (prefix) of Err.
18 msg string
19}
20
21// newer is implemented by error types that can add a context message
22// while preserving their type.
23type newer interface {
24 new(msg string) error
25}
26
27// Error implements the error interface.
28func (e *wrapper) Error() string {
29 if e.msg != "" || e.err == nil {
30 if e.err != nil {
31 return fmt.Sprintf("%s: %v", e.msg, e.err.Error())
32 }
33 return e.msg
34 }
35 return e.err.Error()
36}
37
38// wrap is a helper to construct an *wrapper.
39func wrap(err error, format, suffix string, args ...interface{}) wrapper {
40 return wrapper{err, fmt.Sprintf(format+suffix, args...)}
41}
42
43// Contextf prefixes any error stored in err with text formatted
44// according to the format specifier. If err does not contain an
45// error, Contextf does nothing. All errors created with functions
46// from this package are preserved when wrapping.
47func Contextf(err *error, format string, args ...interface{}) {
48 if *err == nil {
49 return
50 }
51 msg := fmt.Sprintf(format, args...)
52 errNewer, ok := (*err).(newer)
53 if ok {
54 *err = errNewer.new(msg)
55 return
56 }
57 *err = fmt.Errorf("%s: %v", msg, *err)
58}
59
60// Maskf masks the given error (when it is not nil) with the given
61// format string and arguments (like fmt.Sprintf), returning a new
62// error. If *err is nil, Maskf does nothing.
63func Maskf(err *error, format string, args ...interface{}) {
64 if *err == nil {
65 return
66 }
67 *err = fmt.Errorf("%s: %v", fmt.Sprintf(format, args...), *err)
68}
69
70// notFound represents an error when something has not been found.
71type notFound struct {
72 wrapper
73}
74
75func (e *notFound) new(msg string) error {
76 return NewNotFound(e, msg)
77}
78
79// NotFoundf returns an error which satisfies IsNotFound().
80func NotFoundf(format string, args ...interface{}) error {
81 return &notFound{wrap(nil, format, " not found", args...)}
82}
83
84// NewNotFound returns an error which wraps err that satisfies
85// IsNotFound().
86func NewNotFound(err error, msg string) error {
87 return &notFound{wrap(err, msg, "")}
88}
89
90// IsNotFound reports whether err was created with NotFoundf() or
91// NewNotFound().
92func IsNotFound(err error) bool {
93 _, ok := err.(*notFound)
94 return ok
95}
96
97// unauthorized represents an error when an operation is unauthorized.
98type unauthorized struct {
99 wrapper
100}
101
102func (e *unauthorized) new(msg string) error {
103 return NewUnauthorized(e, msg)
104}
105
106// Unauthorizedf returns an error which satisfies IsUnauthorized().
107func Unauthorizedf(format string, args ...interface{}) error {
108 return &unauthorized{wrap(nil, format, "", args...)}
109}
110
111// NewUnauthorized returns an error which wraps err and satisfies
112// IsUnauthorized().
113func NewUnauthorized(err error, msg string) error {
114 return &unauthorized{wrap(err, msg, "")}
115}
116
117// IsUnauthorized reports whether err was created with Unauthorizedf() or
118// NewUnauthorized().
119func IsUnauthorized(err error) bool {
120 _, ok := err.(*unauthorized)
121 return ok
122}
123
124// notImplemented represents an error when something is not
125// implemented.
126type notImplemented struct {
127 wrapper
128}
129
130func (e *notImplemented) new(msg string) error {
131 return NewNotImplemented(e, msg)
132}
133
134// NotImplementedf returns an error which satisfies IsNotImplemented().
135func NotImplementedf(format string, args ...interface{}) error {
136 return &notImplemented{wrap(nil, format, " not implemented", args...)}
137}
138
139// NewNotImplemented returns an error which wraps err and satisfies
140// IsNotImplemented().
141func NewNotImplemented(err error, msg string) error {
142 return &notImplemented{wrap(err, msg, "")}
143}
144
145// IsNotImplemented reports whether err was created with
146// NotImplementedf() or NewNotImplemented().
147func IsNotImplemented(err error) bool {
148 _, ok := err.(*notImplemented)
149 return ok
150}
151
152// alreadyExists represents and error when something already exists.
153type alreadyExists struct {
154 wrapper
155}
156
157func (e *alreadyExists) new(msg string) error {
158 return NewAlreadyExists(e, msg)
159}
160
161// AlreadyExistsf returns an error which satisfies IsAlreadyExists().
162func AlreadyExistsf(format string, args ...interface{}) error {
163 return &alreadyExists{wrap(nil, format, " already exists", args...)}
164}
165
166// NewAlreadyExists returns an error which wraps err and satisfies
167// IsAlreadyExists().
168func NewAlreadyExists(err error, msg string) error {
169 return &alreadyExists{wrap(err, msg, "")}
170}
171
172// IsAlreadyExists reports whether the error was created with
173// AlreadyExistsf() or NewAlreadyExists().
174func IsAlreadyExists(err error) bool {
175 _, ok := err.(*alreadyExists)
176 return ok
177}
178
179// notSupported represents an error when something is not supported.
180type notSupported struct {
181 wrapper
182}
183
184func (e *notSupported) new(msg string) error {
185 return NewNotSupported(e, msg)
186}
187
188// NotSupportedf returns an error which satisfies IsNotSupported().
189func NotSupportedf(format string, args ...interface{}) error {
190 return &notSupported{wrap(nil, format, " not supported", args...)}
191}
192
193// NewNotSupported returns an error which wraps err and satisfies
194// IsNotSupported().
195func NewNotSupported(err error, msg string) error {
196 return &notSupported{wrap(err, msg, "")}
197}
198
199// IsNotSupported reports whether the error was created with
200// NotSupportedf() or NewNotSupported().
201func IsNotSupported(err error) bool {
202 _, ok := err.(*notSupported)
203 return ok
204}
205
206// LoggedErrorf logs the error and return an error with the same text.
207func LoggedErrorf(logger loggo.Logger, format string, a ...interface{}) error {
208 logger.Logf(loggo.ERROR, format, a...)
209 return fmt.Errorf(format, a...)
210}
2110
=== removed file 'errors/errors_test.go'
--- errors/errors_test.go 2014-04-17 14:59:02 +0000
+++ errors/errors_test.go 1970-01-01 00:00:00 +0000
@@ -1,209 +0,0 @@
1// Copyright 2013 Canonical Ltd.
2// Licensed under the AGPLv3, see LICENCE file for details.
3
4package errors_test
5
6import (
7 stderrors "errors"
8 "fmt"
9 "reflect"
10 "runtime"
11 "testing"
12
13 jc "github.com/juju/testing/checkers"
14 gc "launchpad.net/gocheck"
15
16 "launchpad.net/juju-core/errors"
17)
18
19// errorInfo holds information about a single error type: a satisfier
20// function, wrapping and variable arguments constructors and message
21// suffix.
22type errorInfo struct {
23 satisfier func(error) bool
24 argsConstructor func(string, ...interface{}) error
25 wrapConstructor func(error, string) error
26 suffix string
27}
28
29// allErrors holds information for all defined errors. When adding new
30// errors, add them here as well to include them in tests.
31var allErrors = []*errorInfo{
32 &errorInfo{errors.IsNotFound, errors.NotFoundf, errors.NewNotFound, " not found"},
33 &errorInfo{errors.IsUnauthorized, errors.Unauthorizedf, errors.NewUnauthorized, ""},
34 &errorInfo{errors.IsNotImplemented, errors.NotImplementedf, errors.NewNotImplemented, " not implemented"},
35 &errorInfo{errors.IsAlreadyExists, errors.AlreadyExistsf, errors.NewAlreadyExists, " already exists"},
36 &errorInfo{errors.IsNotSupported, errors.NotSupportedf, errors.NewNotSupported, " not supported"},
37}
38
39type errorsSuite struct{}
40
41var _ = gc.Suite(&errorsSuite{})
42
43func Test(t *testing.T) {
44 gc.TestingT(t)
45}
46
47func (t *errorInfo) satisfierName() string {
48 value := reflect.ValueOf(t.satisfier)
49 f := runtime.FuncForPC(value.Pointer())
50 return f.Name()
51}
52
53func (t *errorInfo) equal(t0 *errorInfo) bool {
54 if t0 == nil {
55 return false
56 }
57 return t.satisfierName() == t0.satisfierName()
58}
59
60type errorTest struct {
61 err error
62 message string
63 errInfo *errorInfo
64}
65
66func contextf(err error, format string, args ...interface{}) error {
67 errors.Contextf(&err, format, args...)
68 return err
69}
70
71func maskf(err error, format string, args ...interface{}) error {
72 errors.Maskf(&err, format, args...)
73 return err
74}
75
76func mustSatisfy(c *gc.C, err error, errInfo *errorInfo) {
77 if errInfo != nil {
78 msg := fmt.Sprintf("%#v must satisfy %v", err, errInfo.satisfierName())
79 c.Check(err, jc.Satisfies, errInfo.satisfier, gc.Commentf(msg))
80 }
81}
82
83func mustNotSatisfy(c *gc.C, err error, errInfo *errorInfo) {
84 if errInfo != nil {
85 msg := fmt.Sprintf("%#v must not satisfy %v", err, errInfo.satisfierName())
86 c.Check(err, gc.Not(jc.Satisfies), errInfo.satisfier, gc.Commentf(msg))
87 }
88}
89
90func checkErrorMatches(c *gc.C, err error, message string, errInfo *errorInfo) {
91 if message == "<nil>" {
92 c.Check(err, gc.IsNil)
93 c.Check(errInfo, gc.IsNil)
94 } else {
95 c.Check(err, gc.ErrorMatches, message)
96 }
97}
98
99func runErrorTests(c *gc.C, errorTests []errorTest, checkMustSatisfy bool) {
100 for i, t := range errorTests {
101 c.Logf("test %d: %T: %v", i, t.err, t.err)
102 checkErrorMatches(c, t.err, t.message, t.errInfo)
103 if checkMustSatisfy {
104 mustSatisfy(c, t.err, t.errInfo)
105 }
106
107 // Check all other satisfiers to make sure none match.
108 for _, otherErrInfo := range allErrors {
109 if checkMustSatisfy && otherErrInfo.equal(t.errInfo) {
110 continue
111 }
112 mustNotSatisfy(c, t.err, otherErrInfo)
113 }
114 }
115}
116
117func (*errorsSuite) TestMaskf(c *gc.C) {
118 // Ensure Maskf masks all known errors and their satisfiers don't
119 // succeed.
120 errorTests := []errorTest{}
121 for _, errInfo := range allErrors {
122 errorTests = append(errorTests, []errorTest{{
123 maskf(nil, "masked"),
124 "<nil>",
125 nil,
126 }, {
127 maskf(stderrors.New("blast"), "masked"),
128 "masked: blast",
129 nil,
130 }, {
131 maskf(errInfo.argsConstructor("foo %d", 42), "masked %d", 69),
132 "masked 69: foo 42" + errInfo.suffix,
133 errInfo,
134 }, {
135 maskf(errInfo.argsConstructor(""), "masked"),
136 "masked: " + errInfo.suffix,
137 errInfo,
138 }, {
139 maskf(errInfo.wrapConstructor(stderrors.New("pow!"), "woo"), "masked"),
140 "masked: woo: pow!",
141 errInfo,
142 }}...)
143 }
144
145 runErrorTests(c, errorTests, false)
146}
147
148func (*errorsSuite) TestContextf(c *gc.C) {
149 // Ensure Contextf masks only unknown error types, but passes through known ones.
150 errorTests := []errorTest{}
151 for _, errInfo := range allErrors {
152 errorTests = append(errorTests, []errorTest{{
153 contextf(nil, "prefix"),
154 "<nil>",
155 nil,
156 }, {
157 contextf(stderrors.New("blast"), "prefix"),
158 "prefix: blast",
159 nil,
160 }, {
161 contextf(errInfo.argsConstructor("foo %d", 42), "prefix %d", 69),
162 "prefix 69: foo 42" + errInfo.suffix,
163 errInfo,
164 }, {
165 contextf(errInfo.argsConstructor(""), "prefix"),
166 "prefix: " + errInfo.suffix,
167 errInfo,
168 }, {
169 contextf(errInfo.wrapConstructor(stderrors.New("pow!"), "woo"), "prefix"),
170 "prefix: woo: pow!",
171 errInfo,
172 }}...)
173 }
174
175 runErrorTests(c, errorTests, true)
176}
177
178func (*errorsSuite) TestAllErrors(c *gc.C) {
179 errorTests := []errorTest{}
180 for _, errInfo := range allErrors {
181 errorTests = append(errorTests, []errorTest{{
182 nil,
183 "<nil>",
184 nil,
185 }, {
186 errInfo.argsConstructor("foo %d", 42),
187 "foo 42" + errInfo.suffix,
188 errInfo,
189 }, {
190 errInfo.argsConstructor(""),
191 errInfo.suffix,
192 errInfo,
193 }, {
194 errInfo.wrapConstructor(stderrors.New("pow!"), "prefix"),
195 "prefix: pow!",
196 errInfo,
197 }, {
198 errInfo.wrapConstructor(stderrors.New("pow!"), ""),
199 "pow!",
200 errInfo,
201 }, {
202 errInfo.wrapConstructor(nil, "prefix"),
203 "prefix",
204 errInfo,
205 }}...)
206 }
207
208 runErrorTests(c, errorTests, true)
209}
2100
=== modified file 'juju/api.go'
--- juju/api.go 2014-04-25 14:10:09 +0000
+++ juju/api.go 2014-05-15 02:28:23 +0000
@@ -8,10 +8,11 @@
8 "io"8 "io"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
12
11 "launchpad.net/juju-core/environs"13 "launchpad.net/juju-core/environs"
12 "launchpad.net/juju-core/environs/config"14 "launchpad.net/juju-core/environs/config"
13 "launchpad.net/juju-core/environs/configstore"15 "launchpad.net/juju-core/environs/configstore"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"16 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/names"17 "launchpad.net/juju-core/names"
17 "launchpad.net/juju-core/state/api"18 "launchpad.net/juju-core/state/api"
1819
=== modified file 'juju/apiconn_test.go'
--- juju/apiconn_test.go 2014-04-25 13:57:06 +0000
+++ juju/apiconn_test.go 2014-05-15 02:28:23 +0000
@@ -8,6 +8,7 @@
8 "os"8 "os"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
@@ -16,7 +17,6 @@
16 "launchpad.net/juju-core/environs/config"17 "launchpad.net/juju-core/environs/config"
17 "launchpad.net/juju-core/environs/configstore"18 "launchpad.net/juju-core/environs/configstore"
18 envtesting "launchpad.net/juju-core/environs/testing"19 envtesting "launchpad.net/juju-core/environs/testing"
19 "launchpad.net/juju-core/errors"
20 "launchpad.net/juju-core/instance"20 "launchpad.net/juju-core/instance"
21 "launchpad.net/juju-core/juju"21 "launchpad.net/juju-core/juju"
22 "launchpad.net/juju-core/juju/osenv"22 "launchpad.net/juju-core/juju/osenv"
2323
=== modified file 'juju/conn.go'
--- juju/conn.go 2014-04-17 12:53:23 +0000
+++ juju/conn.go 2014-05-15 02:28:23 +0000
@@ -11,12 +11,12 @@
11 "os"11 "os"
12 "time"12 "time"
1313
14 "github.com/juju/errors"
14 "github.com/juju/loggo"15 "github.com/juju/loggo"
1516
16 "launchpad.net/juju-core/charm"17 "launchpad.net/juju-core/charm"
17 "launchpad.net/juju-core/environs"18 "launchpad.net/juju-core/environs"
18 "launchpad.net/juju-core/environs/configstore"19 "launchpad.net/juju-core/environs/configstore"
19 "launchpad.net/juju-core/errors"
20 "launchpad.net/juju-core/juju/osenv"20 "launchpad.net/juju-core/juju/osenv"
21 "launchpad.net/juju-core/state"21 "launchpad.net/juju-core/state"
22 "launchpad.net/juju-core/utils"22 "launchpad.net/juju-core/utils"
2323
=== modified file 'juju/conn_test.go'
--- juju/conn_test.go 2014-04-24 02:27:38 +0000
+++ juju/conn_test.go 2014-05-15 02:28:23 +0000
@@ -12,6 +12,7 @@
12 "strings"12 "strings"
13 stdtesting "testing"13 stdtesting "testing"
1414
15 "github.com/juju/errors"
15 jc "github.com/juju/testing/checkers"16 jc "github.com/juju/testing/checkers"
16 gc "launchpad.net/gocheck"17 gc "launchpad.net/gocheck"
1718
@@ -22,7 +23,6 @@
22 "launchpad.net/juju-core/environs/config"23 "launchpad.net/juju-core/environs/config"
23 "launchpad.net/juju-core/environs/configstore"24 "launchpad.net/juju-core/environs/configstore"
24 envtesting "launchpad.net/juju-core/environs/testing"25 envtesting "launchpad.net/juju-core/environs/testing"
25 "launchpad.net/juju-core/errors"
26 "launchpad.net/juju-core/instance"26 "launchpad.net/juju-core/instance"
27 "launchpad.net/juju-core/juju"27 "launchpad.net/juju-core/juju"
28 "launchpad.net/juju-core/juju/osenv"28 "launchpad.net/juju-core/juju/osenv"
2929
=== modified file 'provider/azure/certfile.go'
--- provider/azure/certfile.go 2014-04-17 12:47:50 +0000
+++ provider/azure/certfile.go 2014-05-15 02:28:23 +0000
@@ -7,7 +7,7 @@
7 "os"7 "os"
8 "path"8 "path"
99
10 "launchpad.net/juju-core/errors"10 "github.com/juju/errors"
11)11)
1212
13// tempCertFile is a temporary file containing an x509 certificate.13// tempCertFile is a temporary file containing an x509 certificate.
1414
=== modified file 'provider/azure/environ.go'
--- provider/azure/environ.go 2014-05-14 02:59:53 +0000
+++ provider/azure/environ.go 2014-05-15 02:28:23 +0000
@@ -12,6 +12,7 @@
12 "sync"12 "sync"
13 "time"13 "time"
1414
15 "github.com/juju/errors"
15 "launchpad.net/gwacl"16 "launchpad.net/gwacl"
1617
17 "launchpad.net/juju-core/constraints"18 "launchpad.net/juju-core/constraints"
@@ -23,7 +24,6 @@
23 "launchpad.net/juju-core/environs/simplestreams"24 "launchpad.net/juju-core/environs/simplestreams"
24 "launchpad.net/juju-core/environs/storage"25 "launchpad.net/juju-core/environs/storage"
25 envtools "launchpad.net/juju-core/environs/tools"26 envtools "launchpad.net/juju-core/environs/tools"
26 "launchpad.net/juju-core/errors"
27 "launchpad.net/juju-core/instance"27 "launchpad.net/juju-core/instance"
28 "launchpad.net/juju-core/provider/common"28 "launchpad.net/juju-core/provider/common"
29 "launchpad.net/juju-core/state"29 "launchpad.net/juju-core/state"
3030
=== modified file 'provider/azure/instance.go'
--- provider/azure/instance.go 2014-04-09 06:35:07 +0000
+++ provider/azure/instance.go 2014-05-15 02:28:23 +0000
@@ -8,9 +8,9 @@
8 "strings"8 "strings"
9 "sync"9 "sync"
1010
11 "github.com/juju/errors"
11 "launchpad.net/gwacl"12 "launchpad.net/gwacl"
1213
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/provider/common"15 "launchpad.net/juju-core/provider/common"
16 "launchpad.net/juju-core/worker/firewaller"16 "launchpad.net/juju-core/worker/firewaller"
1717
=== modified file 'provider/azure/instancetype.go'
--- provider/azure/instancetype.go 2014-04-14 12:36:13 +0000
+++ provider/azure/instancetype.go 2014-05-15 02:28:23 +0000
@@ -7,13 +7,13 @@
7 "fmt"7 "fmt"
8 "sort"8 "sort"
99
10 "github.com/juju/errors"
10 "launchpad.net/gwacl"11 "launchpad.net/gwacl"
1112
12 "launchpad.net/juju-core/constraints"13 "launchpad.net/juju-core/constraints"
13 "launchpad.net/juju-core/environs/imagemetadata"14 "launchpad.net/juju-core/environs/imagemetadata"
14 "launchpad.net/juju-core/environs/instances"15 "launchpad.net/juju-core/environs/instances"
15 "launchpad.net/juju-core/environs/simplestreams"16 "launchpad.net/juju-core/environs/simplestreams"
16 "launchpad.net/juju-core/errors"
17)17)
1818
19// preferredTypes is a list of machine types, in order of preference so that19// preferredTypes is a list of machine types, in order of preference so that
2020
=== modified file 'provider/azure/storage.go'
--- provider/azure/storage.go 2014-04-30 01:16:45 +0000
+++ provider/azure/storage.go 2014-05-15 02:28:23 +0000
@@ -9,10 +9,10 @@
9 "sync"9 "sync"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 "launchpad.net/gwacl"13 "launchpad.net/gwacl"
1314
14 "launchpad.net/juju-core/environs/storage"15 "launchpad.net/juju-core/environs/storage"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/utils"16 "launchpad.net/juju-core/utils"
17)17)
1818
1919
=== modified file 'provider/azure/storage_test.go'
--- provider/azure/storage_test.go 2014-04-14 12:36:13 +0000
+++ provider/azure/storage_test.go 2014-05-15 02:28:23 +0000
@@ -11,12 +11,12 @@
11 "net/url"11 "net/url"
12 "strings"12 "strings"
1313
14 "github.com/juju/errors"
14 jc "github.com/juju/testing/checkers"15 jc "github.com/juju/testing/checkers"
15 gc "launchpad.net/gocheck"16 gc "launchpad.net/gocheck"
16 "launchpad.net/gwacl"17 "launchpad.net/gwacl"
1718
18 "launchpad.net/juju-core/environs/storage"19 "launchpad.net/juju-core/environs/storage"
19 "launchpad.net/juju-core/errors"
20)20)
2121
22type storageSuite struct {22type storageSuite struct {
2323
=== modified file 'provider/common/destroy_test.go'
--- provider/common/destroy_test.go 2014-05-13 11:37:40 +0000
+++ provider/common/destroy_test.go 2014-05-15 02:28:23 +0000
@@ -7,11 +7,11 @@
7 "fmt"7 "fmt"
8 "strings"8 "strings"
99
10 "github.com/juju/errors"
10 jc "github.com/juju/testing/checkers"11 jc "github.com/juju/testing/checkers"
11 gc "launchpad.net/gocheck"12 gc "launchpad.net/gocheck"
1213
13 "launchpad.net/juju-core/environs"14 "launchpad.net/juju-core/environs"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/provider/common"16 "launchpad.net/juju-core/provider/common"
17 "launchpad.net/juju-core/testing/testbase"17 "launchpad.net/juju-core/testing/testbase"
1818
=== modified file 'provider/dummy/storage.go'
--- provider/dummy/storage.go 2014-01-31 00:14:11 +0000
+++ provider/dummy/storage.go 2014-05-15 02:28:23 +0000
@@ -13,8 +13,9 @@
13 "strings"13 "strings"
14 "time"14 "time"
1515
16 "github.com/juju/errors"
17
16 "launchpad.net/juju-core/environs/storage"18 "launchpad.net/juju-core/environs/storage"
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/utils"19 "launchpad.net/juju-core/utils"
19)20)
2021
2122
=== modified file 'provider/ec2/ec2.go'
--- provider/ec2/ec2.go 2014-05-14 02:59:53 +0000
+++ provider/ec2/ec2.go 2014-05-15 02:28:23 +0000
@@ -8,6 +8,7 @@
8 "sync"8 "sync"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 "github.com/juju/loggo"12 "github.com/juju/loggo"
12 "launchpad.net/goamz/aws"13 "launchpad.net/goamz/aws"
13 "launchpad.net/goamz/ec2"14 "launchpad.net/goamz/ec2"
@@ -22,7 +23,6 @@
22 "launchpad.net/juju-core/environs/simplestreams"23 "launchpad.net/juju-core/environs/simplestreams"
23 "launchpad.net/juju-core/environs/storage"24 "launchpad.net/juju-core/environs/storage"
24 envtools "launchpad.net/juju-core/environs/tools"25 envtools "launchpad.net/juju-core/environs/tools"
25 "launchpad.net/juju-core/errors"
26 "launchpad.net/juju-core/instance"26 "launchpad.net/juju-core/instance"
27 "launchpad.net/juju-core/juju/arch"27 "launchpad.net/juju-core/juju/arch"
28 "launchpad.net/juju-core/provider/common"28 "launchpad.net/juju-core/provider/common"
2929
=== modified file 'provider/ec2/storage.go'
--- provider/ec2/storage.go 2014-04-30 23:18:40 +0000
+++ provider/ec2/storage.go 2014-05-15 02:28:23 +0000
@@ -10,10 +10,10 @@
10 "sync"10 "sync"
11 "time"11 "time"
1212
13 "github.com/juju/errors"
13 "launchpad.net/goamz/s3"14 "launchpad.net/goamz/s3"
1415
15 "launchpad.net/juju-core/environs/storage"16 "launchpad.net/juju-core/environs/storage"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/utils"17 "launchpad.net/juju-core/utils"
18)18)
1919
2020
=== modified file 'provider/joyent/environ_instance.go'
--- provider/joyent/environ_instance.go 2014-05-14 02:59:53 +0000
+++ provider/joyent/environ_instance.go 2014-05-15 02:28:23 +0000
@@ -11,6 +11,7 @@
1111
12 "github.com/joyent/gocommon/client"12 "github.com/joyent/gocommon/client"
13 "github.com/joyent/gosdc/cloudapi"13 "github.com/joyent/gosdc/cloudapi"
14 "github.com/juju/errors"
1415
15 "launchpad.net/juju-core/constraints"16 "launchpad.net/juju-core/constraints"
16 "launchpad.net/juju-core/environs"17 "launchpad.net/juju-core/environs"
@@ -18,7 +19,6 @@
18 "launchpad.net/juju-core/environs/instances"19 "launchpad.net/juju-core/environs/instances"
19 "launchpad.net/juju-core/environs/network"20 "launchpad.net/juju-core/environs/network"
20 "launchpad.net/juju-core/environs/simplestreams"21 "launchpad.net/juju-core/environs/simplestreams"
21 "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/instance"22 "launchpad.net/juju-core/instance"
23 "launchpad.net/juju-core/juju/arch"23 "launchpad.net/juju-core/juju/arch"
24 "launchpad.net/juju-core/names"24 "launchpad.net/juju-core/names"
2525
=== modified file 'provider/joyent/storage.go'
--- provider/joyent/storage.go 2014-04-30 23:18:40 +0000
+++ provider/joyent/storage.go 2014-05-15 02:28:23 +0000
@@ -13,8 +13,8 @@
13 "sync"13 "sync"
14 "time"14 "time"
1515
16 "github.com/juju/errors"
16 "launchpad.net/juju-core/environs/storage"17 "launchpad.net/juju-core/environs/storage"
17 coreerrors "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/utils"18 "launchpad.net/juju-core/utils"
1919
20 "github.com/joyent/gocommon/client"20 "github.com/joyent/gocommon/client"
@@ -94,7 +94,7 @@
94 s.madeContainer = false94 s.madeContainer = false
95 }95 }
96 if je.IsResourceNotFound(err) {96 if je.IsResourceNotFound(err) {
97 return coreerrors.NewNotFound(err, fmt.Sprintf("cannot delete %s, not found", containerName))97 return errors.NewNotFound(err, fmt.Sprintf("cannot delete %s, not found", containerName))
98 }98 }
99 return err99 return err
100}100}
@@ -155,7 +155,7 @@
155func (s *JoyentStorage) Get(name string) (io.ReadCloser, error) {155func (s *JoyentStorage) Get(name string) (io.ReadCloser, error) {
156 b, err := s.manta.GetObject(s.containerName, name)156 b, err := s.manta.GetObject(s.containerName, name)
157 if err != nil {157 if err != nil {
158 return nil, coreerrors.NewNotFound(err, fmt.Sprintf("cannot find %s", name))158 return nil, errors.NewNotFound(err, fmt.Sprintf("cannot find %s", name))
159 }159 }
160 r := byteCloser{bytes.NewReader(b)}160 r := byteCloser{bytes.NewReader(b)}
161 return r, nil161 return r, nil
162162
=== modified file 'provider/joyent/storage_test.go'
--- provider/joyent/storage_test.go 2014-04-14 12:36:13 +0000
+++ provider/joyent/storage_test.go 2014-05-15 02:28:23 +0000
@@ -12,10 +12,10 @@
12 "strings"12 "strings"
1313
14 "github.com/joyent/gocommon/errors"14 "github.com/joyent/gocommon/errors"
15 jujuerrors "github.com/juju/errors"
15 jc "github.com/juju/testing/checkers"16 jc "github.com/juju/testing/checkers"
16 gc "launchpad.net/gocheck"17 gc "launchpad.net/gocheck"
1718
18 coreerrors "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/provider/joyent"19 "launchpad.net/juju-core/provider/joyent"
20 jp "launchpad.net/juju-core/provider/joyent"20 jp "launchpad.net/juju-core/provider/joyent"
21)21)
@@ -117,7 +117,7 @@
117117
118 _, err := mantaStorage.Get("noFile")118 _, err := mantaStorage.Get("noFile")
119 c.Assert(err, gc.NotNil)119 c.Assert(err, gc.NotNil)
120 c.Assert(err, jc.Satisfies, coreerrors.IsNotFound)120 c.Assert(err, jc.Satisfies, jujuerrors.IsNotFound)
121}121}
122122
123func (s *storageSuite) TestPut(c *gc.C) {123func (s *storageSuite) TestPut(c *gc.C) {
@@ -195,5 +195,5 @@
195195
196 err := mantaStorage.DeleteContainer("noContainer")196 err := mantaStorage.DeleteContainer("noContainer")
197 c.Assert(err, gc.NotNil)197 c.Assert(err, gc.NotNil)
198 c.Assert(err, jc.Satisfies, coreerrors.IsNotFound)198 c.Assert(err, jc.Satisfies, jujuerrors.IsNotFound)
199}199}
200200
=== modified file 'provider/local/environ.go'
--- provider/local/environ.go 2014-05-14 02:59:53 +0000
+++ provider/local/environ.go 2014-05-15 02:28:23 +0000
@@ -15,7 +15,7 @@
15 "sync"15 "sync"
16 "syscall"16 "syscall"
1717
18 "github.com/errgo/errgo"18 "github.com/juju/errors"
1919
20 "launchpad.net/juju-core/agent"20 "launchpad.net/juju-core/agent"
21 "launchpad.net/juju-core/agent/mongo"21 "launchpad.net/juju-core/agent/mongo"
@@ -34,7 +34,6 @@
34 "launchpad.net/juju-core/environs/simplestreams"34 "launchpad.net/juju-core/environs/simplestreams"
35 "launchpad.net/juju-core/environs/storage"35 "launchpad.net/juju-core/environs/storage"
36 envtools "launchpad.net/juju-core/environs/tools"36 envtools "launchpad.net/juju-core/environs/tools"
37 "launchpad.net/juju-core/errors"
38 "launchpad.net/juju-core/instance"37 "launchpad.net/juju-core/instance"
39 "launchpad.net/juju-core/juju/arch"38 "launchpad.net/juju-core/juju/arch"
40 "launchpad.net/juju-core/juju/osenv"39 "launchpad.net/juju-core/juju/osenv"
@@ -476,7 +475,7 @@
476 // Exit status 1 means no processes were matched:475 // Exit status 1 means no processes were matched:
477 // we don't consider this an error here.476 // we don't consider this an error here.
478 if err.ProcessState.Sys().(syscall.WaitStatus).ExitStatus() != 1 {477 if err.ProcessState.Sys().(syscall.WaitStatus).ExitStatus() != 1 {
479 return errgo.Annotate(err, "failed to kill jujud")478 return errors.Annotate(err, "failed to kill jujud")
480 }479 }
481 }480 }
482 }481 }
483482
=== modified file 'provider/local/instance.go'
--- provider/local/instance.go 2014-04-14 12:36:13 +0000
+++ provider/local/instance.go 2014-05-15 02:28:23 +0000
@@ -6,7 +6,8 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "launchpad.net/juju-core/errors"9 "github.com/juju/errors"
10
10 "launchpad.net/juju-core/instance"11 "launchpad.net/juju-core/instance"
11 "launchpad.net/juju-core/provider/common"12 "launchpad.net/juju-core/provider/common"
12)13)
1314
=== modified file 'provider/maas/environ.go'
--- provider/maas/environ.go 2014-05-14 02:59:53 +0000
+++ provider/maas/environ.go 2014-05-15 02:28:23 +0000
@@ -13,6 +13,7 @@
13 "sync"13 "sync"
14 "time"14 "time"
1515
16 "github.com/juju/errors"
16 "labix.org/v2/mgo/bson"17 "labix.org/v2/mgo/bson"
17 "launchpad.net/gomaasapi"18 "launchpad.net/gomaasapi"
1819
@@ -26,7 +27,6 @@
26 "launchpad.net/juju-core/environs/simplestreams"27 "launchpad.net/juju-core/environs/simplestreams"
27 "launchpad.net/juju-core/environs/storage"28 "launchpad.net/juju-core/environs/storage"
28 envtools "launchpad.net/juju-core/environs/tools"29 envtools "launchpad.net/juju-core/environs/tools"
29 "launchpad.net/juju-core/errors"
30 "launchpad.net/juju-core/instance"30 "launchpad.net/juju-core/instance"
31 "launchpad.net/juju-core/provider/common"31 "launchpad.net/juju-core/provider/common"
32 "launchpad.net/juju-core/state"32 "launchpad.net/juju-core/state"
3333
=== modified file 'provider/maas/environ_whitebox_test.go'
--- provider/maas/environ_whitebox_test.go 2014-05-14 02:59:53 +0000
+++ provider/maas/environ_whitebox_test.go 2014-05-15 02:28:23 +0000
@@ -12,6 +12,7 @@
12 "strings"12 "strings"
13 "text/template"13 "text/template"
1414
15 "github.com/juju/errors"
15 jc "github.com/juju/testing/checkers"16 jc "github.com/juju/testing/checkers"
16 gc "launchpad.net/gocheck"17 gc "launchpad.net/gocheck"
17 "launchpad.net/gomaasapi"18 "launchpad.net/gomaasapi"
@@ -27,7 +28,6 @@
27 "launchpad.net/juju-core/environs/storage"28 "launchpad.net/juju-core/environs/storage"
28 envtesting "launchpad.net/juju-core/environs/testing"29 envtesting "launchpad.net/juju-core/environs/testing"
29 envtools "launchpad.net/juju-core/environs/tools"30 envtools "launchpad.net/juju-core/environs/tools"
30 "launchpad.net/juju-core/errors"
31 "launchpad.net/juju-core/instance"31 "launchpad.net/juju-core/instance"
32 "launchpad.net/juju-core/juju/testing"32 "launchpad.net/juju-core/juju/testing"
33 coretesting "launchpad.net/juju-core/testing"33 coretesting "launchpad.net/juju-core/testing"
3434
=== modified file 'provider/maas/storage.go'
--- provider/maas/storage.go 2014-04-30 23:18:40 +0000
+++ provider/maas/storage.go 2014-05-15 02:28:23 +0000
@@ -14,10 +14,10 @@
14 "strings"14 "strings"
15 "sync"15 "sync"
1616
17 "github.com/juju/errors"
17 "launchpad.net/gomaasapi"18 "launchpad.net/gomaasapi"
1819
19 "launchpad.net/juju-core/environs/storage"20 "launchpad.net/juju-core/environs/storage"
20 "launchpad.net/juju-core/errors"
21 "launchpad.net/juju-core/utils"21 "launchpad.net/juju-core/utils"
22)22)
2323
2424
=== modified file 'provider/maas/storage_test.go'
--- provider/maas/storage_test.go 2014-04-14 12:36:13 +0000
+++ provider/maas/storage_test.go 2014-05-15 02:28:23 +0000
@@ -12,12 +12,12 @@
12 "net/url"12 "net/url"
13 "sync"13 "sync"
1414
15 "github.com/juju/errors"
15 jc "github.com/juju/testing/checkers"16 jc "github.com/juju/testing/checkers"
16 gc "launchpad.net/gocheck"17 gc "launchpad.net/gocheck"
17 "launchpad.net/gomaasapi"18 "launchpad.net/gomaasapi"
1819
19 "launchpad.net/juju-core/environs/storage"20 "launchpad.net/juju-core/environs/storage"
20 "launchpad.net/juju-core/errors"
21)21)
2222
23type storageSuite struct {23type storageSuite struct {
2424
=== modified file 'provider/manual/environ.go'
--- provider/manual/environ.go 2014-05-14 02:59:53 +0000
+++ provider/manual/environ.go 2014-05-15 02:28:23 +0000
@@ -5,13 +5,13 @@
55
6import (6import (
7 "bytes"7 "bytes"
8 "errors"
9 "fmt"8 "fmt"
10 "net"9 "net"
11 "path"10 "path"
12 "strings"11 "strings"
13 "sync"12 "sync"
1413
14 "github.com/juju/errors"
15 "github.com/juju/loggo"15 "github.com/juju/loggo"
1616
17 "launchpad.net/juju-core/agent"17 "launchpad.net/juju-core/agent"
@@ -26,7 +26,6 @@
26 "launchpad.net/juju-core/environs/sshstorage"26 "launchpad.net/juju-core/environs/sshstorage"
27 "launchpad.net/juju-core/environs/storage"27 "launchpad.net/juju-core/environs/storage"
28 envtools "launchpad.net/juju-core/environs/tools"28 envtools "launchpad.net/juju-core/environs/tools"
29 coreerrors "launchpad.net/juju-core/errors"
30 "launchpad.net/juju-core/instance"29 "launchpad.net/juju-core/instance"
31 "launchpad.net/juju-core/juju/arch"30 "launchpad.net/juju-core/juju/arch"
32 "launchpad.net/juju-core/provider/common"31 "launchpad.net/juju-core/provider/common"
@@ -205,7 +204,7 @@
205// given instance on the given network. This is not supported on the204// given instance on the given network. This is not supported on the
206// manual provider.205// manual provider.
207func (*manualEnviron) AllocateAddress(_ instance.Id, _ network.Id) (instance.Address, error) {206func (*manualEnviron) AllocateAddress(_ instance.Id, _ network.Id) (instance.Address, error) {
208 return instance.Address{}, coreerrors.NotSupportedf("AllocateAddress")207 return instance.Address{}, errors.NotSupportedf("AllocateAddress")
209}208}
210209
211var newSSHStorage = func(sshHost, storageDir, storageTmpdir string) (storage.Storage, error) {210var newSSHStorage = func(sshHost, storageDir, storageTmpdir string) (storage.Storage, error) {
212211
=== modified file 'provider/openstack/provider.go'
--- provider/openstack/provider.go 2014-05-14 02:59:53 +0000
+++ provider/openstack/provider.go 2014-05-15 02:28:23 +0000
@@ -14,6 +14,7 @@
14 "sync"14 "sync"
15 "time"15 "time"
1616
17 jujuerrors "github.com/juju/errors"
17 "github.com/juju/loggo"18 "github.com/juju/loggo"
18 "launchpad.net/goose/client"19 "launchpad.net/goose/client"
19 gooseerrors "launchpad.net/goose/errors"20 gooseerrors "launchpad.net/goose/errors"
@@ -30,7 +31,6 @@
30 "launchpad.net/juju-core/environs/simplestreams"31 "launchpad.net/juju-core/environs/simplestreams"
31 "launchpad.net/juju-core/environs/storage"32 "launchpad.net/juju-core/environs/storage"
32 envtools "launchpad.net/juju-core/environs/tools"33 envtools "launchpad.net/juju-core/environs/tools"
33 coreerrors "launchpad.net/juju-core/errors"
34 "launchpad.net/juju-core/instance"34 "launchpad.net/juju-core/instance"
35 "launchpad.net/juju-core/juju/arch"35 "launchpad.net/juju-core/juju/arch"
36 "launchpad.net/juju-core/names"36 "launchpad.net/juju-core/names"
@@ -1005,7 +1005,7 @@
1005// given instance on the given network. This is not implemented on the1005// given instance on the given network. This is not implemented on the
1006// OpenStack provider yet.1006// OpenStack provider yet.
1007func (*environ) AllocateAddress(_ instance.Id, _ network.Id) (instance.Address, error) {1007func (*environ) AllocateAddress(_ instance.Id, _ network.Id) (instance.Address, error) {
1008 return instance.Address{}, coreerrors.NotImplementedf("AllocateAddress")1008 return instance.Address{}, jujuerrors.NotImplementedf("AllocateAddress")
1009}1009}
10101010
1011func (e *environ) AllInstances() (insts []instance.Instance, err error) {1011func (e *environ) AllInstances() (insts []instance.Instance, err error) {
10121012
=== modified file 'provider/openstack/storage.go'
--- provider/openstack/storage.go 2014-04-30 23:18:40 +0000
+++ provider/openstack/storage.go 2014-05-15 02:28:23 +0000
@@ -9,11 +9,11 @@
9 "sync"9 "sync"
10 "time"10 "time"
1111
12 jujuerrors "github.com/juju/errors"
12 gooseerrors "launchpad.net/goose/errors"13 gooseerrors "launchpad.net/goose/errors"
13 "launchpad.net/goose/swift"14 "launchpad.net/goose/swift"
1415
15 "launchpad.net/juju-core/environs/storage"16 "launchpad.net/juju-core/environs/storage"
16 coreerrors "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/utils"17 "launchpad.net/juju-core/utils"
18)18)
1919
@@ -178,7 +178,7 @@
178// container not being found.178// container not being found.
179func maybeNotFound(err error) (error, bool) {179func maybeNotFound(err error) (error, bool) {
180 if err != nil && gooseerrors.IsNotFound(err) {180 if err != nil && gooseerrors.IsNotFound(err) {
181 return coreerrors.NewNotFound(err, ""), true181 return jujuerrors.NewNotFound(err, ""), true
182 }182 }
183 return err, false183 return err, false
184}184}
185185
=== modified file 'state/addmachine.go'
--- state/addmachine.go 2014-04-30 23:18:40 +0000
+++ state/addmachine.go 2014-05-15 02:28:23 +0000
@@ -7,11 +7,11 @@
7 "fmt"7 "fmt"
8 "strconv"8 "strconv"
99
10 "github.com/juju/errors"
10 "labix.org/v2/mgo/bson"11 "labix.org/v2/mgo/bson"
11 "labix.org/v2/mgo/txn"12 "labix.org/v2/mgo/txn"
1213
13 "launchpad.net/juju-core/constraints"14 "launchpad.net/juju-core/constraints"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/replicaset"16 "launchpad.net/juju-core/replicaset"
17 "launchpad.net/juju-core/state/api/params"17 "launchpad.net/juju-core/state/api/params"
1818
=== modified file 'state/annotator.go'
--- state/annotator.go 2014-04-17 12:47:50 +0000
+++ state/annotator.go 2014-05-15 02:28:23 +0000
@@ -7,11 +7,10 @@
7 "fmt"7 "fmt"
8 "strings"8 "strings"
99
10 "github.com/juju/errors"
10 "labix.org/v2/mgo"11 "labix.org/v2/mgo"
11 "labix.org/v2/mgo/bson"12 "labix.org/v2/mgo/bson"
12 "labix.org/v2/mgo/txn"13 "labix.org/v2/mgo/txn"
13
14 "launchpad.net/juju-core/errors"
15)14)
1615
17// annotatorDoc represents the internal state of annotations for an Entity in16// annotatorDoc represents the internal state of annotations for an Entity in
1817
=== modified file 'state/api/agent/machine_test.go'
--- state/api/agent/machine_test.go 2014-04-14 12:36:13 +0000
+++ state/api/agent/machine_test.go 2014-05-15 02:28:23 +0000
@@ -7,13 +7,13 @@
7 "fmt"7 "fmt"
8 stdtesting "testing"8 stdtesting "testing"
99
10 "github.com/juju/errors"
10 jc "github.com/juju/testing/checkers"11 jc "github.com/juju/testing/checkers"
11 "labix.org/v2/mgo"12 "labix.org/v2/mgo"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
14 "launchpad.net/juju-core/agent/mongo"15 "launchpad.net/juju-core/agent/mongo"
15 "launchpad.net/juju-core/environs"16 "launchpad.net/juju-core/environs"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/juju/testing"17 "launchpad.net/juju-core/juju/testing"
18 "launchpad.net/juju-core/state"18 "launchpad.net/juju-core/state"
19 "launchpad.net/juju-core/state/api"19 "launchpad.net/juju-core/state/api"
2020
=== modified file 'state/api/client.go'
--- state/api/client.go 2014-05-01 16:57:34 +0000
+++ state/api/client.go 2014-05-15 02:28:23 +0000
@@ -16,12 +16,12 @@
16 "time"16 "time"
1717
18 "code.google.com/p/go.net/websocket"18 "code.google.com/p/go.net/websocket"
19 "github.com/juju/errors"
19 "github.com/juju/loggo"20 "github.com/juju/loggo"
2021
21 "launchpad.net/juju-core/charm"22 "launchpad.net/juju-core/charm"
22 "launchpad.net/juju-core/constraints"23 "launchpad.net/juju-core/constraints"
23 "launchpad.net/juju-core/environs/network"24 "launchpad.net/juju-core/environs/network"
24 "launchpad.net/juju-core/errors"
25 "launchpad.net/juju-core/instance"25 "launchpad.net/juju-core/instance"
26 "launchpad.net/juju-core/state/api/params"26 "launchpad.net/juju-core/state/api/params"
27 "launchpad.net/juju-core/tools"27 "launchpad.net/juju-core/tools"
2828
=== modified file 'state/api/machiner/machiner_test.go'
--- state/api/machiner/machiner_test.go 2014-04-14 12:36:13 +0000
+++ state/api/machiner/machiner_test.go 2014-05-15 02:28:23 +0000
@@ -6,10 +6,10 @@
6import (6import (
7 stdtesting "testing"7 stdtesting "testing"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/instance"13 "launchpad.net/juju-core/instance"
14 "launchpad.net/juju-core/juju/testing"14 "launchpad.net/juju-core/juju/testing"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
1616
=== modified file 'state/api/provisioner/provisioner_test.go'
--- state/api/provisioner/provisioner_test.go 2014-05-09 13:24:50 +0000
+++ state/api/provisioner/provisioner_test.go 2014-05-15 02:28:23 +0000
@@ -6,12 +6,12 @@
6import (6import (
7 stdtesting "testing"7 stdtesting "testing"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/constraints"13 "launchpad.net/juju-core/constraints"
13 "launchpad.net/juju-core/container"14 "launchpad.net/juju-core/container"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/juju/testing"16 "launchpad.net/juju-core/juju/testing"
17 "launchpad.net/juju-core/names"17 "launchpad.net/juju-core/names"
1818
=== modified file 'state/api/uniter/unit_test.go'
--- state/api/uniter/unit_test.go 2014-04-14 12:36:13 +0000
+++ state/api/uniter/unit_test.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "sort"7 "sort"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/charm"13 "launchpad.net/juju-core/charm"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
16 "launchpad.net/juju-core/state/api/params"16 "launchpad.net/juju-core/state/api/params"
1717
=== modified file 'state/api/upgrader/unitupgrader_test.go'
--- state/api/upgrader/unitupgrader_test.go 2014-04-14 12:36:13 +0000
+++ state/api/upgrader/unitupgrader_test.go 2014-05-15 02:28:23 +0000
@@ -4,10 +4,10 @@
4package upgrader_test4package upgrader_test
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 gc "launchpad.net/gocheck"9 gc "launchpad.net/gocheck"
910
10 "launchpad.net/juju-core/errors"
11 jujutesting "launchpad.net/juju-core/juju/testing"11 jujutesting "launchpad.net/juju-core/juju/testing"
12 "launchpad.net/juju-core/state"12 "launchpad.net/juju-core/state"
13 "launchpad.net/juju-core/state/api"13 "launchpad.net/juju-core/state/api"
1414
=== modified file 'state/api/upgrader/upgrader_test.go'
--- state/api/upgrader/upgrader_test.go 2014-04-14 12:36:13 +0000
+++ state/api/upgrader/upgrader_test.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 stdtesting "testing"7 stdtesting "testing"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 envtesting "launchpad.net/juju-core/environs/testing"13 envtesting "launchpad.net/juju-core/environs/testing"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/juju/testing"14 "launchpad.net/juju-core/juju/testing"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
16 "launchpad.net/juju-core/state/api"16 "launchpad.net/juju-core/state/api"
1717
=== modified file 'state/apiserver/admin.go'
--- state/apiserver/admin.go 2014-04-30 21:51:15 +0000
+++ state/apiserver/admin.go 2014-05-15 02:28:23 +0000
@@ -7,7 +7,8 @@
7 stderrors "errors"7 stderrors "errors"
8 "sync"8 "sync"
99
10 "launchpad.net/juju-core/errors"10 "github.com/juju/errors"
11
11 "launchpad.net/juju-core/names"12 "launchpad.net/juju-core/names"
12 "launchpad.net/juju-core/rpc"13 "launchpad.net/juju-core/rpc"
13 "launchpad.net/juju-core/state"14 "launchpad.net/juju-core/state"
1415
=== modified file 'state/apiserver/charmrevisionupdater/updater.go'
--- state/apiserver/charmrevisionupdater/updater.go 2014-04-30 23:18:40 +0000
+++ state/apiserver/charmrevisionupdater/updater.go 2014-05-15 02:28:23 +0000
@@ -4,10 +4,10 @@
4package charmrevisionupdater4package charmrevisionupdater
55
6import (6import (
7 "github.com/juju/errors"
7 "github.com/juju/loggo"8 "github.com/juju/loggo"
89
9 "launchpad.net/juju-core/charm"10 "launchpad.net/juju-core/charm"
10 "launchpad.net/juju-core/errors"
11 "launchpad.net/juju-core/state"11 "launchpad.net/juju-core/state"
12 "launchpad.net/juju-core/state/api/params"12 "launchpad.net/juju-core/state/api/params"
13 "launchpad.net/juju-core/state/apiserver/common"13 "launchpad.net/juju-core/state/apiserver/common"
1414
=== modified file 'state/apiserver/charmrevisionupdater/updater_test.go'
--- state/apiserver/charmrevisionupdater/updater_test.go 2014-04-17 12:53:23 +0000
+++ state/apiserver/charmrevisionupdater/updater_test.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4package charmrevisionupdater_test4package charmrevisionupdater_test
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 gc "launchpad.net/gocheck"9 gc "launchpad.net/gocheck"
910
10 "launchpad.net/juju-core/charm"11 "launchpad.net/juju-core/charm"
11 "launchpad.net/juju-core/errors"
12 jujutesting "launchpad.net/juju-core/juju/testing"12 jujutesting "launchpad.net/juju-core/juju/testing"
13 "launchpad.net/juju-core/state"13 "launchpad.net/juju-core/state"
14 "launchpad.net/juju-core/state/apiserver/charmrevisionupdater"14 "launchpad.net/juju-core/state/apiserver/charmrevisionupdater"
1515
=== modified file 'state/apiserver/charms.go'
--- state/apiserver/charms.go 2014-04-07 05:11:48 +0000
+++ state/apiserver/charms.go 2014-05-15 02:28:23 +0000
@@ -21,7 +21,7 @@
21 "strconv"21 "strconv"
22 "strings"22 "strings"
2323
24 "github.com/errgo/errgo"24 "github.com/juju/errors"
2525
26 "launchpad.net/juju-core/charm"26 "launchpad.net/juju-core/charm"
27 "launchpad.net/juju-core/environs"27 "launchpad.net/juju-core/environs"
@@ -236,13 +236,13 @@
236 }236 }
237 zipr, err := zip.NewReader(f, fi.Size())237 zipr, err := zip.NewReader(f, fi.Size())
238 if err != nil {238 if err != nil {
239 return errgo.Annotate(err, "cannot open charm archive")239 return errors.Annotate(err, "cannot open charm archive")
240 }240 }
241241
242 // Find out the root dir prefix from the archive.242 // Find out the root dir prefix from the archive.
243 rootDir, err := h.findArchiveRootDir(zipr)243 rootDir, err := h.findArchiveRootDir(zipr)
244 if err != nil {244 if err != nil {
245 return errgo.Annotate(err, "cannot read charm archive")245 return errors.Annotate(err, "cannot read charm archive")
246 }246 }
247 if rootDir == "." {247 if rootDir == "." {
248 // Normal charm, just use charm.ReadBundle().248 // Normal charm, just use charm.ReadBundle().
@@ -253,15 +253,15 @@
253 // dir and then read it as a charm dir.253 // dir and then read it as a charm dir.
254 tempDir, err := ioutil.TempDir("", "charm-extract")254 tempDir, err := ioutil.TempDir("", "charm-extract")
255 if err != nil {255 if err != nil {
256 return errgo.Annotate(err, "cannot create temp directory")256 return errors.Annotate(err, "cannot create temp directory")
257 }257 }
258 defer os.RemoveAll(tempDir)258 defer os.RemoveAll(tempDir)
259 if err := ziputil.Extract(zipr, tempDir, rootDir); err != nil {259 if err := ziputil.Extract(zipr, tempDir, rootDir); err != nil {
260 return errgo.Annotate(err, "cannot extract charm archive")260 return errors.Annotate(err, "cannot extract charm archive")
261 }261 }
262 dir, err := charm.ReadDir(tempDir)262 dir, err := charm.ReadDir(tempDir)
263 if err != nil {263 if err != nil {
264 return errgo.Annotate(err, "cannot read extracted archive")264 return errors.Annotate(err, "cannot read extracted archive")
265 }265 }
266266
267 // Now repackage the dir as a bundle at the original path.267 // Now repackage the dir as a bundle at the original path.
@@ -313,25 +313,25 @@
313 // dir and the repackaged archive.313 // dir and the repackaged archive.
314 tempDir, err := ioutil.TempDir("", "charm-download")314 tempDir, err := ioutil.TempDir("", "charm-download")
315 if err != nil {315 if err != nil {
316 return errgo.Annotate(err, "cannot create temp directory")316 return errors.Annotate(err, "cannot create temp directory")
317 }317 }
318 defer os.RemoveAll(tempDir)318 defer os.RemoveAll(tempDir)
319 extractPath := filepath.Join(tempDir, "extracted")319 extractPath := filepath.Join(tempDir, "extracted")
320 repackagedPath := filepath.Join(tempDir, "repackaged.zip")320 repackagedPath := filepath.Join(tempDir, "repackaged.zip")
321 repackagedArchive, err := os.Create(repackagedPath)321 repackagedArchive, err := os.Create(repackagedPath)
322 if err != nil {322 if err != nil {
323 return errgo.Annotate(err, "cannot repackage uploaded charm")323 return errors.Annotate(err, "cannot repackage uploaded charm")
324 }324 }
325 defer repackagedArchive.Close()325 defer repackagedArchive.Close()
326326
327 // Expand and repack it with the revision specified by curl.327 // Expand and repack it with the revision specified by curl.
328 archive.SetRevision(curl.Revision)328 archive.SetRevision(curl.Revision)
329 if err := archive.ExpandTo(extractPath); err != nil {329 if err := archive.ExpandTo(extractPath); err != nil {
330 return errgo.Annotate(err, "cannot extract uploaded charm")330 return errors.Annotate(err, "cannot extract uploaded charm")
331 }331 }
332 charmDir, err := charm.ReadDir(extractPath)332 charmDir, err := charm.ReadDir(extractPath)
333 if err != nil {333 if err != nil {
334 return errgo.Annotate(err, "cannot read extracted charm")334 return errors.Annotate(err, "cannot read extracted charm")
335 }335 }
336336
337 // Bundle the charm and calculate its sha256 hash at the337 // Bundle the charm and calculate its sha256 hash at the
@@ -339,39 +339,39 @@
339 hash := sha256.New()339 hash := sha256.New()
340 err = charmDir.BundleTo(io.MultiWriter(hash, repackagedArchive))340 err = charmDir.BundleTo(io.MultiWriter(hash, repackagedArchive))
341 if err != nil {341 if err != nil {
342 return errgo.Annotate(err, "cannot repackage uploaded charm")342 return errors.Annotate(err, "cannot repackage uploaded charm")
343 }343 }
344 bundleSHA256 := hex.EncodeToString(hash.Sum(nil))344 bundleSHA256 := hex.EncodeToString(hash.Sum(nil))
345 size, err := repackagedArchive.Seek(0, 2)345 size, err := repackagedArchive.Seek(0, 2)
346 if err != nil {346 if err != nil {
347 return errgo.Annotate(err, "cannot get charm file size")347 return errors.Annotate(err, "cannot get charm file size")
348 }348 }
349349
350 // Now upload to provider storage.350 // Now upload to provider storage.
351 if _, err := repackagedArchive.Seek(0, 0); err != nil {351 if _, err := repackagedArchive.Seek(0, 0); err != nil {
352 return errgo.Annotate(err, "cannot rewind the charm file reader")352 return errors.Annotate(err, "cannot rewind the charm file reader")
353 }353 }
354 storage, err := environs.GetStorage(h.state)354 storage, err := environs.GetStorage(h.state)
355 if err != nil {355 if err != nil {
356 return errgo.Annotate(err, "cannot access provider storage")356 return errors.Annotate(err, "cannot access provider storage")
357 }357 }
358 name := charm.Quote(curl.String())358 name := charm.Quote(curl.String())
359 if err := storage.Put(name, repackagedArchive, size); err != nil {359 if err := storage.Put(name, repackagedArchive, size); err != nil {
360 return errgo.Annotate(err, "cannot upload charm to provider storage")360 return errors.Annotate(err, "cannot upload charm to provider storage")
361 }361 }
362 storageURL, err := storage.URL(name)362 storageURL, err := storage.URL(name)
363 if err != nil {363 if err != nil {
364 return errgo.Annotate(err, "cannot get storage URL for charm")364 return errors.Annotate(err, "cannot get storage URL for charm")
365 }365 }
366 bundleURL, err := url.Parse(storageURL)366 bundleURL, err := url.Parse(storageURL)
367 if err != nil {367 if err != nil {
368 return errgo.Annotate(err, "cannot parse storage URL")368 return errors.Annotate(err, "cannot parse storage URL")
369 }369 }
370370
371 // And finally, update state.371 // And finally, update state.
372 _, err = h.state.UpdateUploadedCharm(archive, curl, bundleURL, bundleSHA256)372 _, err = h.state.UpdateUploadedCharm(archive, curl, bundleURL, bundleSHA256)
373 if err != nil {373 if err != nil {
374 return errgo.Annotate(err, "cannot update uploaded charm in state")374 return errors.Annotate(err, "cannot update uploaded charm in state")
375 }375 }
376 return nil376 return nil
377}377}
@@ -416,18 +416,18 @@
416 // Get the provider storage.416 // Get the provider storage.
417 storage, err := environs.GetStorage(h.state)417 storage, err := environs.GetStorage(h.state)
418 if err != nil {418 if err != nil {
419 return errgo.Annotate(err, "cannot access provider storage")419 return errors.Annotate(err, "cannot access provider storage")
420 }420 }
421421
422 // Use the storage to retrieve and save the charm archive.422 // Use the storage to retrieve and save the charm archive.
423 reader, err := storage.Get(name)423 reader, err := storage.Get(name)
424 if err != nil {424 if err != nil {
425 return errgo.Annotate(err, "charm not found in the provider storage")425 return errors.Annotate(err, "charm not found in the provider storage")
426 }426 }
427 defer reader.Close()427 defer reader.Close()
428 data, err := ioutil.ReadAll(reader)428 data, err := ioutil.ReadAll(reader)
429 if err != nil {429 if err != nil {
430 return errgo.Annotate(err, "cannot read charm data")430 return errors.Annotate(err, "cannot read charm data")
431 }431 }
432 // In order to avoid races, the archive is saved in a temporary file which432 // In order to avoid races, the archive is saved in a temporary file which
433 // is then atomically renamed. The temporary file is created in the433 // is then atomically renamed. The temporary file is created in the
@@ -435,19 +435,19 @@
435 // target live in the same file system.435 // target live in the same file system.
436 cacheDir := filepath.Dir(charmArchivePath)436 cacheDir := filepath.Dir(charmArchivePath)
437 if err = os.MkdirAll(cacheDir, 0755); err != nil {437 if err = os.MkdirAll(cacheDir, 0755); err != nil {
438 return errgo.Annotate(err, "cannot create the charms cache")438 return errors.Annotate(err, "cannot create the charms cache")
439 }439 }
440 tempCharmArchive, err := ioutil.TempFile(cacheDir, "charm")440 tempCharmArchive, err := ioutil.TempFile(cacheDir, "charm")
441 if err != nil {441 if err != nil {
442 return errgo.Annotate(err, "cannot create charm archive temp file")442 return errors.Annotate(err, "cannot create charm archive temp file")
443 }443 }
444 defer tempCharmArchive.Close()444 defer tempCharmArchive.Close()
445 if err = ioutil.WriteFile(tempCharmArchive.Name(), data, 0644); err != nil {445 if err = ioutil.WriteFile(tempCharmArchive.Name(), data, 0644); err != nil {
446 return errgo.Annotate(err, "error processing charm archive download")446 return errors.Annotate(err, "error processing charm archive download")
447 }447 }
448 if err = os.Rename(tempCharmArchive.Name(), charmArchivePath); err != nil {448 if err = os.Rename(tempCharmArchive.Name(), charmArchivePath); err != nil {
449 defer os.Remove(tempCharmArchive.Name())449 defer os.Remove(tempCharmArchive.Name())
450 return errgo.Annotate(err, "error renaming the charm archive")450 return errors.Annotate(err, "error renaming the charm archive")
451 }451 }
452 return nil452 return nil
453}453}
454454
=== modified file 'state/apiserver/client/api_test.go'
--- state/apiserver/client/api_test.go 2014-05-01 16:14:47 +0000
+++ state/apiserver/client/api_test.go 2014-05-15 02:28:23 +0000
@@ -8,13 +8,13 @@
8 stdtesting "testing"8 stdtesting "testing"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
14 "launchpad.net/juju-core/constraints"15 "launchpad.net/juju-core/constraints"
15 "launchpad.net/juju-core/environs"16 "launchpad.net/juju-core/environs"
16 "launchpad.net/juju-core/environs/config"17 "launchpad.net/juju-core/environs/config"
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/instance"18 "launchpad.net/juju-core/instance"
19 "launchpad.net/juju-core/juju/testing"19 "launchpad.net/juju-core/juju/testing"
20 "launchpad.net/juju-core/state"20 "launchpad.net/juju-core/state"
2121
=== modified file 'state/apiserver/client/client.go'
--- state/apiserver/client/client.go 2014-04-30 23:18:40 +0000
+++ state/apiserver/client/client.go 2014-05-15 02:28:23 +0000
@@ -9,7 +9,7 @@
9 "os"9 "os"
10 "strings"10 "strings"
1111
12 "github.com/errgo/errgo"12 "github.com/juju/errors"
13 "github.com/juju/loggo"13 "github.com/juju/loggo"
1414
15 "launchpad.net/juju-core/charm"15 "launchpad.net/juju-core/charm"
@@ -17,7 +17,6 @@
17 "launchpad.net/juju-core/environs/config"17 "launchpad.net/juju-core/environs/config"
18 "launchpad.net/juju-core/environs/manual"18 "launchpad.net/juju-core/environs/manual"
19 envtools "launchpad.net/juju-core/environs/tools"19 envtools "launchpad.net/juju-core/environs/tools"
20 "launchpad.net/juju-core/errors"
21 "launchpad.net/juju-core/instance"20 "launchpad.net/juju-core/instance"
22 "launchpad.net/juju-core/juju"21 "launchpad.net/juju-core/juju"
23 "launchpad.net/juju-core/names"22 "launchpad.net/juju-core/names"
@@ -953,47 +952,47 @@
953 store := config.SpecializeCharmRepo(CharmStore, envConfig)952 store := config.SpecializeCharmRepo(CharmStore, envConfig)
954 downloadedCharm, err := store.Get(charmURL)953 downloadedCharm, err := store.Get(charmURL)
955 if err != nil {954 if err != nil {
956 return errgo.Annotatef(err, "cannot download charm %q", charmURL.String())955 return errors.Annotatef(err, "cannot download charm %q", charmURL.String())
957 }956 }
958957
959 // Open it and calculate the SHA256 hash.958 // Open it and calculate the SHA256 hash.
960 downloadedBundle, ok := downloadedCharm.(*charm.Bundle)959 downloadedBundle, ok := downloadedCharm.(*charm.Bundle)
961 if !ok {960 if !ok {
962 return errgo.New("expected a charm archive, got %T", downloadedCharm)961 return errors.Errorf("expected a charm archive, got %T", downloadedCharm)
963 }962 }
964 archive, err := os.Open(downloadedBundle.Path)963 archive, err := os.Open(downloadedBundle.Path)
965 if err != nil {964 if err != nil {
966 return errgo.Annotate(err, "cannot read downloaded charm")965 return errors.Annotate(err, "cannot read downloaded charm")
967 }966 }
968 defer archive.Close()967 defer archive.Close()
969 bundleSHA256, size, err := utils.ReadSHA256(archive)968 bundleSHA256, size, err := utils.ReadSHA256(archive)
970 if err != nil {969 if err != nil {
971 return errgo.Annotate(err, "cannot calculate SHA256 hash of charm")970 return errors.Annotate(err, "cannot calculate SHA256 hash of charm")
972 }971 }
973 if _, err := archive.Seek(0, 0); err != nil {972 if _, err := archive.Seek(0, 0); err != nil {
974 return errgo.Annotate(err, "cannot rewind charm archive")973 return errors.Annotate(err, "cannot rewind charm archive")
975 }974 }
976975
977 // Get the environment storage and upload the charm.976 // Get the environment storage and upload the charm.
978 env, err := environs.New(envConfig)977 env, err := environs.New(envConfig)
979 if err != nil {978 if err != nil {
980 return errgo.Annotate(err, "cannot access environment")979 return errors.Annotate(err, "cannot access environment")
981 }980 }
982 storage := env.Storage()981 storage := env.Storage()
983 archiveName, err := CharmArchiveName(charmURL.Name, charmURL.Revision)982 archiveName, err := CharmArchiveName(charmURL.Name, charmURL.Revision)
984 if err != nil {983 if err != nil {
985 return errgo.Annotate(err, "cannot generate charm archive name")984 return errors.Annotate(err, "cannot generate charm archive name")
986 }985 }
987 if err := storage.Put(archiveName, archive, size); err != nil {986 if err := storage.Put(archiveName, archive, size); err != nil {
988 return errgo.Annotate(err, "cannot upload charm to provider storage")987 return errors.Annotate(err, "cannot upload charm to provider storage")
989 }988 }
990 storageURL, err := storage.URL(archiveName)989 storageURL, err := storage.URL(archiveName)
991 if err != nil {990 if err != nil {
992 return errgo.Annotate(err, "cannot get storage URL for charm")991 return errors.Annotate(err, "cannot get storage URL for charm")
993 }992 }
994 bundleURL, err := url.Parse(storageURL)993 bundleURL, err := url.Parse(storageURL)
995 if err != nil {994 if err != nil {
996 return errgo.Annotate(err, "cannot parse storage URL")995 return errors.Annotate(err, "cannot parse storage URL")
997 }996 }
998997
999 // Finally, update the charm data in state and mark it as no longer pending.998 // Finally, update the charm data in state and mark it as no longer pending.
@@ -1005,7 +1004,7 @@
1005 // us. This means we have to delete what we just uploaded1004 // us. This means we have to delete what we just uploaded
1006 // to storage.1005 // to storage.
1007 if err := storage.Remove(archiveName); err != nil {1006 if err := storage.Remove(archiveName); err != nil {
1008 errgo.Annotate(err, "cannot remove duplicated charm from storage")1007 errors.Annotate(err, "cannot remove duplicated charm from storage")
1009 }1008 }
1010 return nil1009 return nil
1011 }1010 }
10121011
=== modified file 'state/apiserver/client/client_test.go'
--- state/apiserver/client/client_test.go 2014-04-23 11:57:06 +0000
+++ state/apiserver/client/client_test.go 2014-05-15 02:28:23 +0000
@@ -11,6 +11,7 @@
11 "sync"11 "sync"
12 "time"12 "time"
1313
14 "github.com/juju/errors"
14 jc "github.com/juju/testing/checkers"15 jc "github.com/juju/testing/checkers"
15 gc "launchpad.net/gocheck"16 gc "launchpad.net/gocheck"
1617
@@ -21,7 +22,6 @@
21 "launchpad.net/juju-core/environs/manual"22 "launchpad.net/juju-core/environs/manual"
22 envstorage "launchpad.net/juju-core/environs/storage"23 envstorage "launchpad.net/juju-core/environs/storage"
23 ttesting "launchpad.net/juju-core/environs/tools/testing"24 ttesting "launchpad.net/juju-core/environs/tools/testing"
24 "launchpad.net/juju-core/errors"
25 "launchpad.net/juju-core/instance"25 "launchpad.net/juju-core/instance"
26 "launchpad.net/juju-core/provider/dummy"26 "launchpad.net/juju-core/provider/dummy"
27 "launchpad.net/juju-core/state"27 "launchpad.net/juju-core/state"
2828
=== modified file 'state/apiserver/client/destroy_test.go'
--- state/apiserver/client/destroy_test.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/client/destroy_test.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/environs"13 "launchpad.net/juju-core/environs"
13 coreerrors "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/juju/testing"15 "launchpad.net/juju-core/juju/testing"
16 "launchpad.net/juju-core/state"16 "launchpad.net/juju-core/state"
@@ -109,7 +109,7 @@
109 for _, s := range services {109 for _, s := range services {
110 err = s.Refresh()110 err = s.Refresh()
111 if err != nil {111 if err != nil {
112 c.Assert(err, jc.Satisfies, coreerrors.IsNotFound)112 c.Assert(err, jc.Satisfies, errors.IsNotFound)
113 } else {113 } else {
114 c.Assert(s.Life(), gc.Not(gc.Equals), state.Alive)114 c.Assert(s.Life(), gc.Not(gc.Equals), state.Alive)
115 }115 }
116116
=== modified file 'state/apiserver/client/status.go'
--- state/apiserver/client/status.go 2014-05-01 17:56:04 +0000
+++ state/apiserver/client/status.go 2014-05-15 02:28:23 +0000
@@ -9,8 +9,9 @@
9 "regexp"9 "regexp"
10 "strings"10 "strings"
1111
12 "github.com/juju/errors"
13
12 "launchpad.net/juju-core/charm"14 "launchpad.net/juju-core/charm"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/juju"16 "launchpad.net/juju-core/juju"
16 "launchpad.net/juju-core/state"17 "launchpad.net/juju-core/state"
1718
=== modified file 'state/apiserver/common/errors.go'
--- state/apiserver/common/errors.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/common/errors.go 2014-05-15 02:28:23 +0000
@@ -7,7 +7,8 @@
7 stderrors "errors"7 stderrors "errors"
8 "fmt"8 "fmt"
99
10 "launchpad.net/juju-core/errors"10 "github.com/juju/errors"
11
11 "launchpad.net/juju-core/state"12 "launchpad.net/juju-core/state"
12 "launchpad.net/juju-core/state/api/params"13 "launchpad.net/juju-core/state/api/params"
13)14)
1415
=== modified file 'state/apiserver/common/errors_test.go'
--- state/apiserver/common/errors_test.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/common/errors_test.go 2014-05-15 02:28:23 +0000
@@ -6,10 +6,10 @@
6import (6import (
7 stderrors "errors"7 stderrors "errors"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/state"13 "launchpad.net/juju-core/state"
14 "launchpad.net/juju-core/state/api/params"14 "launchpad.net/juju-core/state/api/params"
15 "launchpad.net/juju-core/state/apiserver/common"15 "launchpad.net/juju-core/state/apiserver/common"
1616
=== modified file 'state/apiserver/common/password_test.go'
--- state/apiserver/common/password_test.go 2014-03-13 13:42:50 +0000
+++ state/apiserver/common/password_test.go 2014-05-15 02:28:23 +0000
@@ -6,10 +6,10 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/state"13 "launchpad.net/juju-core/state"
14 "launchpad.net/juju-core/state/api/params"14 "launchpad.net/juju-core/state/api/params"
15 "launchpad.net/juju-core/state/apiserver/common"15 "launchpad.net/juju-core/state/apiserver/common"
1616
=== modified file 'state/apiserver/deployer/deployer_test.go'
--- state/apiserver/deployer/deployer_test.go 2014-04-17 12:53:23 +0000
+++ state/apiserver/deployer/deployer_test.go 2014-05-15 02:28:23 +0000
@@ -7,10 +7,10 @@
7 "sort"7 "sort"
8 stdtesting "testing"8 stdtesting "testing"
99
10 "github.com/juju/errors"
10 jc "github.com/juju/testing/checkers"11 jc "github.com/juju/testing/checkers"
11 gc "launchpad.net/gocheck"12 gc "launchpad.net/gocheck"
1213
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/juju/testing"15 "launchpad.net/juju-core/juju/testing"
16 "launchpad.net/juju-core/names"16 "launchpad.net/juju-core/names"
1717
=== modified file 'state/apiserver/firewaller/firewaller_test.go'
--- state/apiserver/firewaller/firewaller_test.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/firewaller/firewaller_test.go 2014-05-15 02:28:23 +0000
@@ -6,10 +6,10 @@
6import (6import (
7 stdtesting "testing"7 stdtesting "testing"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/instance"13 "launchpad.net/juju-core/instance"
14 "launchpad.net/juju-core/juju/testing"14 "launchpad.net/juju-core/juju/testing"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
1616
=== modified file 'state/apiserver/keymanager/keymanager.go'
--- state/apiserver/keymanager/keymanager.go 2014-04-30 23:18:40 +0000
+++ state/apiserver/keymanager/keymanager.go 2014-05-15 02:28:23 +0000
@@ -8,10 +8,10 @@
8 "fmt"8 "fmt"
9 "strings"9 "strings"
1010
11 "github.com/juju/errors"
11 "github.com/juju/loggo"12 "github.com/juju/loggo"
1213
13 "launchpad.net/juju-core/environs/config"14 "launchpad.net/juju-core/environs/config"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/names"15 "launchpad.net/juju-core/names"
16 "launchpad.net/juju-core/state"16 "launchpad.net/juju-core/state"
17 "launchpad.net/juju-core/state/api/params"17 "launchpad.net/juju-core/state/api/params"
1818
=== modified file 'state/apiserver/keyupdater/authorisedkeys.go'
--- state/apiserver/keyupdater/authorisedkeys.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/keyupdater/authorisedkeys.go 2014-05-15 02:28:23 +0000
@@ -4,7 +4,8 @@
4package keyupdater4package keyupdater
55
6import (6import (
7 "launchpad.net/juju-core/errors"7 "github.com/juju/errors"
8
8 "launchpad.net/juju-core/state"9 "launchpad.net/juju-core/state"
9 "launchpad.net/juju-core/state/api/params"10 "launchpad.net/juju-core/state/api/params"
10 "launchpad.net/juju-core/state/apiserver/common"11 "launchpad.net/juju-core/state/apiserver/common"
1112
=== modified file 'state/apiserver/machine/machiner.go'
--- state/apiserver/machine/machiner.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/machine/machiner.go 2014-05-15 02:28:23 +0000
@@ -6,7 +6,8 @@
6package machine6package machine
77
8import (8import (
9 "launchpad.net/juju-core/errors"9 "github.com/juju/errors"
10
10 "launchpad.net/juju-core/state"11 "launchpad.net/juju-core/state"
11 "launchpad.net/juju-core/state/api/params"12 "launchpad.net/juju-core/state/api/params"
12 "launchpad.net/juju-core/state/apiserver/common"13 "launchpad.net/juju-core/state/apiserver/common"
1314
=== modified file 'state/apiserver/provisioner/provisioner_test.go'
--- state/apiserver/provisioner/provisioner_test.go 2014-05-09 13:24:50 +0000
+++ state/apiserver/provisioner/provisioner_test.go 2014-05-15 02:28:23 +0000
@@ -7,12 +7,12 @@
7 "fmt"7 "fmt"
8 stdtesting "testing"8 stdtesting "testing"
99
10 "github.com/juju/errors"
10 jc "github.com/juju/testing/checkers"11 jc "github.com/juju/testing/checkers"
11 gc "launchpad.net/gocheck"12 gc "launchpad.net/gocheck"
1213
13 "launchpad.net/juju-core/constraints"14 "launchpad.net/juju-core/constraints"
14 "launchpad.net/juju-core/container"15 "launchpad.net/juju-core/container"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/instance"16 "launchpad.net/juju-core/instance"
17 "launchpad.net/juju-core/juju/osenv"17 "launchpad.net/juju-core/juju/osenv"
18 "launchpad.net/juju-core/juju/testing"18 "launchpad.net/juju-core/juju/testing"
1919
=== modified file 'state/apiserver/uniter/uniter.go'
--- state/apiserver/uniter/uniter.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/uniter/uniter.go 2014-05-15 02:28:23 +0000
@@ -8,8 +8,9 @@
8import (8import (
9 "fmt"9 "fmt"
1010
11 "github.com/juju/errors"
12
11 "launchpad.net/juju-core/charm"13 "launchpad.net/juju-core/charm"
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/names"14 "launchpad.net/juju-core/names"
14 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
15 "launchpad.net/juju-core/state/api/params"16 "launchpad.net/juju-core/state/api/params"
1617
=== modified file 'state/apiserver/uniter/uniter_test.go'
--- state/apiserver/uniter/uniter_test.go 2014-04-17 12:53:23 +0000
+++ state/apiserver/uniter/uniter_test.go 2014-05-15 02:28:23 +0000
@@ -6,12 +6,12 @@
6import (6import (
7 stdtesting "testing"7 stdtesting "testing"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/charm"13 "launchpad.net/juju-core/charm"
13 envtesting "launchpad.net/juju-core/environs/testing"14 envtesting "launchpad.net/juju-core/environs/testing"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/juju/testing"16 "launchpad.net/juju-core/juju/testing"
17 "launchpad.net/juju-core/state"17 "launchpad.net/juju-core/state"
1818
=== modified file 'state/apiserver/upgrader/unitupgrader_test.go'
--- state/apiserver/upgrader/unitupgrader_test.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/upgrader/unitupgrader_test.go 2014-05-15 02:28:23 +0000
@@ -4,10 +4,10 @@
4package upgrader_test4package upgrader_test
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 gc "launchpad.net/gocheck"9 gc "launchpad.net/gocheck"
910
10 "launchpad.net/juju-core/errors"
11 jujutesting "launchpad.net/juju-core/juju/testing"11 jujutesting "launchpad.net/juju-core/juju/testing"
12 "launchpad.net/juju-core/state"12 "launchpad.net/juju-core/state"
13 "launchpad.net/juju-core/state/api/params"13 "launchpad.net/juju-core/state/api/params"
1414
=== modified file 'state/apiserver/upgrader/upgrader_test.go'
--- state/apiserver/upgrader/upgrader_test.go 2014-04-14 12:36:13 +0000
+++ state/apiserver/upgrader/upgrader_test.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4package upgrader_test4package upgrader_test
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 gc "launchpad.net/gocheck"9 gc "launchpad.net/gocheck"
910
10 envtesting "launchpad.net/juju-core/environs/testing"11 envtesting "launchpad.net/juju-core/environs/testing"
11 "launchpad.net/juju-core/errors"
12 jujutesting "launchpad.net/juju-core/juju/testing"12 jujutesting "launchpad.net/juju-core/juju/testing"
13 "launchpad.net/juju-core/state"13 "launchpad.net/juju-core/state"
14 "launchpad.net/juju-core/state/api/params"14 "launchpad.net/juju-core/state/api/params"
1515
=== modified file 'state/charm_test.go'
--- state/charm_test.go 2014-04-14 12:36:13 +0000
+++ state/charm_test.go 2014-05-15 02:28:23 +0000
@@ -7,11 +7,11 @@
7 "bytes"7 "bytes"
8 "net/url"8 "net/url"
99
10 "github.com/juju/errors"
10 jc "github.com/juju/testing/checkers"11 jc "github.com/juju/testing/checkers"
11 gc "launchpad.net/gocheck"12 gc "launchpad.net/gocheck"
1213
13 "launchpad.net/juju-core/charm"14 "launchpad.net/juju-core/charm"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
16 "launchpad.net/juju-core/testing"16 "launchpad.net/juju-core/testing"
17)17)
1818
=== modified file 'state/cleanup.go'
--- state/cleanup.go 2014-04-14 12:36:13 +0000
+++ state/cleanup.go 2014-05-15 02:28:23 +0000
@@ -3,10 +3,9 @@
3import (3import (
4 "fmt"4 "fmt"
55
6 "github.com/juju/errors"
6 "labix.org/v2/mgo/bson"7 "labix.org/v2/mgo/bson"
7 "labix.org/v2/mgo/txn"8 "labix.org/v2/mgo/txn"
8
9 "launchpad.net/juju-core/errors"
10)9)
1110
12// cleanupDoc represents a potentially large set of documents that should be11// cleanupDoc represents a potentially large set of documents that should be
1312
=== modified file 'state/cleanup_test.go'
--- state/cleanup_test.go 2014-04-14 12:36:13 +0000
+++ state/cleanup_test.go 2014-05-15 02:28:23 +0000
@@ -3,11 +3,11 @@
3import (3import (
4 "fmt"4 "fmt"
55
6 "github.com/juju/errors"
6 jc "github.com/juju/testing/checkers"7 jc "github.com/juju/testing/checkers"
7 gc "launchpad.net/gocheck"8 gc "launchpad.net/gocheck"
89
9 "launchpad.net/juju-core/charm"10 "launchpad.net/juju-core/charm"
10 "launchpad.net/juju-core/errors"
11 "launchpad.net/juju-core/instance"11 "launchpad.net/juju-core/instance"
12 "launchpad.net/juju-core/state"12 "launchpad.net/juju-core/state"
13)13)
1414
=== modified file 'state/configvalidator_test.go'
--- state/configvalidator_test.go 2014-04-14 12:36:13 +0000
+++ state/configvalidator_test.go 2014-05-15 02:28:23 +0000
@@ -4,9 +4,10 @@
4package state_test4package state_test
55
6import (6import (
7 "github.com/juju/errors"
7 gc "launchpad.net/gocheck"8 gc "launchpad.net/gocheck"
9
8 "launchpad.net/juju-core/environs/config"10 "launchpad.net/juju-core/environs/config"
9 "launchpad.net/juju-core/errors"
10 "launchpad.net/juju-core/state"11 "launchpad.net/juju-core/state"
11 coretesting "launchpad.net/juju-core/testing"12 coretesting "launchpad.net/juju-core/testing"
12)13)
1314
=== modified file 'state/conn_test.go'
--- state/conn_test.go 2014-04-22 09:23:39 +0000
+++ state/conn_test.go 2014-05-15 02:28:23 +0000
@@ -6,12 +6,12 @@
6import (6import (
7 stdtesting "testing"7 stdtesting "testing"
88
9 "github.com/juju/errors"
9 "labix.org/v2/mgo"10 "labix.org/v2/mgo"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/constraints"13 "launchpad.net/juju-core/constraints"
13 "launchpad.net/juju-core/environs/config"14 "launchpad.net/juju-core/environs/config"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
16 "launchpad.net/juju-core/testing"16 "launchpad.net/juju-core/testing"
17 "launchpad.net/juju-core/testing/testbase"17 "launchpad.net/juju-core/testing/testbase"
1818
=== modified file 'state/constraints.go'
--- state/constraints.go 2014-04-17 03:10:18 +0000
+++ state/constraints.go 2014-05-15 02:28:23 +0000
@@ -6,12 +6,12 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 "labix.org/v2/mgo"10 "labix.org/v2/mgo"
10 "labix.org/v2/mgo/bson"11 "labix.org/v2/mgo/bson"
11 "labix.org/v2/mgo/txn"12 "labix.org/v2/mgo/txn"
1213
13 "launchpad.net/juju-core/constraints"14 "launchpad.net/juju-core/constraints"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16)16)
1717
1818
=== modified file 'state/environ.go'
--- state/environ.go 2014-04-01 00:58:29 +0000
+++ state/environ.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4package state4package state
55
6import (6import (
7 "github.com/juju/errors"
7 "labix.org/v2/mgo"8 "labix.org/v2/mgo"
8 "labix.org/v2/mgo/bson"9 "labix.org/v2/mgo/bson"
9 "labix.org/v2/mgo/txn"10 "labix.org/v2/mgo/txn"
1011
11 "launchpad.net/juju-core/errors"
12 "launchpad.net/juju-core/names"12 "launchpad.net/juju-core/names"
13)13)
1414
1515
=== modified file 'state/environcapability_test.go'
--- state/environcapability_test.go 2014-04-14 12:36:13 +0000
+++ state/environcapability_test.go 2014-05-15 02:28:23 +0000
@@ -6,10 +6,10 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 gc "launchpad.net/gocheck"10 gc "launchpad.net/gocheck"
1011
11 "launchpad.net/juju-core/environs/config"12 "launchpad.net/juju-core/environs/config"
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/instance"13 "launchpad.net/juju-core/instance"
14 "launchpad.net/juju-core/state"14 "launchpad.net/juju-core/state"
15)15)
1616
=== modified file 'state/machine.go'
--- state/machine.go 2014-04-22 09:23:39 +0000
+++ state/machine.go 2014-05-15 02:28:23 +0000
@@ -9,12 +9,12 @@
9 "strings"9 "strings"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 "labix.org/v2/mgo"13 "labix.org/v2/mgo"
13 "labix.org/v2/mgo/bson"14 "labix.org/v2/mgo/bson"
14 "labix.org/v2/mgo/txn"15 "labix.org/v2/mgo/txn"
1516
16 "launchpad.net/juju-core/constraints"17 "launchpad.net/juju-core/constraints"
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/instance"18 "launchpad.net/juju-core/instance"
19 "launchpad.net/juju-core/names"19 "launchpad.net/juju-core/names"
20 "launchpad.net/juju-core/state/api/params"20 "launchpad.net/juju-core/state/api/params"
2121
=== modified file 'state/machine_test.go'
--- state/machine_test.go 2014-04-21 23:10:05 +0000
+++ state/machine_test.go 2014-05-15 02:28:23 +0000
@@ -7,6 +7,7 @@
7 "sort"7 "sort"
8 "strings"8 "strings"
99
10 "github.com/juju/errors"
10 "github.com/juju/loggo"11 "github.com/juju/loggo"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 "labix.org/v2/mgo/bson"13 "labix.org/v2/mgo/bson"
@@ -15,7 +16,6 @@
15 "launchpad.net/juju-core/constraints"16 "launchpad.net/juju-core/constraints"
16 "launchpad.net/juju-core/environs/config"17 "launchpad.net/juju-core/environs/config"
17 "launchpad.net/juju-core/environs/network"18 "launchpad.net/juju-core/environs/network"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/instance"19 "launchpad.net/juju-core/instance"
20 "launchpad.net/juju-core/state"20 "launchpad.net/juju-core/state"
21 "launchpad.net/juju-core/state/api/params"21 "launchpad.net/juju-core/state/api/params"
2222
=== modified file 'state/megawatcher.go'
--- state/megawatcher.go 2014-04-14 12:36:13 +0000
+++ state/megawatcher.go 2014-05-15 02:28:23 +0000
@@ -8,9 +8,9 @@
8 "reflect"8 "reflect"
9 "strings"9 "strings"
1010
11 "github.com/juju/errors"
11 "labix.org/v2/mgo"12 "labix.org/v2/mgo"
1213
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/state/api/params"14 "launchpad.net/juju-core/state/api/params"
15 "launchpad.net/juju-core/state/multiwatcher"15 "launchpad.net/juju-core/state/multiwatcher"
16 "launchpad.net/juju-core/state/watcher"16 "launchpad.net/juju-core/state/watcher"
1717
=== modified file 'state/minimumunits.go'
--- state/minimumunits.go 2014-04-17 12:47:50 +0000
+++ state/minimumunits.go 2014-05-15 02:28:23 +0000
@@ -4,12 +4,9 @@
4package state4package state
55
6import (6import (
7 "errors"7 "github.com/juju/errors"
8
9 "labix.org/v2/mgo/bson"8 "labix.org/v2/mgo/bson"
10 "labix.org/v2/mgo/txn"9 "labix.org/v2/mgo/txn"
11
12 coreerrors "launchpad.net/juju-core/errors"
13)10)
1411
15// minUnitsDoc keeps track of relevant changes on the service's MinUnits field12// minUnitsDoc keeps track of relevant changes on the service's MinUnits field
@@ -31,7 +28,7 @@
3128
32// SetMinUnits changes the number of minimum units required by the service.29// SetMinUnits changes the number of minimum units required by the service.
33func (s *Service) SetMinUnits(minUnits int) (err error) {30func (s *Service) SetMinUnits(minUnits int) (err error) {
34 defer coreerrors.Maskf(&err, "cannot set minimum units for service %q", s)31 defer errors.Maskf(&err, "cannot set minimum units for service %q", s)
35 defer func() {32 defer func() {
36 if err == nil {33 if err == nil {
37 s.doc.MinUnits = minUnits34 s.doc.MinUnits = minUnits
@@ -127,7 +124,7 @@
127// EnsureMinUnits adds new units if the service's MinUnits value is greater124// EnsureMinUnits adds new units if the service's MinUnits value is greater
128// than the number of alive units.125// than the number of alive units.
129func (s *Service) EnsureMinUnits() (err error) {126func (s *Service) EnsureMinUnits() (err error) {
130 defer coreerrors.Maskf(&err, "cannot ensure minimum units for service %q", s)127 defer errors.Maskf(&err, "cannot ensure minimum units for service %q", s)
131 service := &Service{st: s.st, doc: s.doc}128 service := &Service{st: s.st, doc: s.doc}
132 for {129 for {
133 // Ensure the service is alive.130 // Ensure the service is alive.
134131
=== modified file 'state/open.go'
--- state/open.go 2014-05-07 08:10:22 +0000
+++ state/open.go 2014-05-15 02:28:23 +0000
@@ -11,6 +11,7 @@
11 "net"11 "net"
12 "time"12 "time"
1313
14 "github.com/juju/errors"
14 "labix.org/v2/mgo"15 "labix.org/v2/mgo"
15 "labix.org/v2/mgo/bson"16 "labix.org/v2/mgo/bson"
16 "labix.org/v2/mgo/txn"17 "labix.org/v2/mgo/txn"
@@ -18,7 +19,6 @@
18 "launchpad.net/juju-core/cert"19 "launchpad.net/juju-core/cert"
19 "launchpad.net/juju-core/constraints"20 "launchpad.net/juju-core/constraints"
20 "launchpad.net/juju-core/environs/config"21 "launchpad.net/juju-core/environs/config"
21 "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/state/api/params"22 "launchpad.net/juju-core/state/api/params"
23 "launchpad.net/juju-core/state/presence"23 "launchpad.net/juju-core/state/presence"
24 "launchpad.net/juju-core/state/watcher"24 "launchpad.net/juju-core/state/watcher"
2525
=== modified file 'state/policy.go'
--- state/policy.go 2014-04-22 09:23:39 +0000
+++ state/policy.go 2014-05-15 02:28:23 +0000
@@ -6,9 +6,10 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
10
9 "launchpad.net/juju-core/constraints"11 "launchpad.net/juju-core/constraints"
10 "launchpad.net/juju-core/environs/config"12 "launchpad.net/juju-core/environs/config"
11 "launchpad.net/juju-core/errors"
12)13)
1314
14// Policy is an interface provided to State that may15// Policy is an interface provided to State that may
1516
=== modified file 'state/prechecker_test.go'
--- state/prechecker_test.go 2014-04-22 09:23:39 +0000
+++ state/prechecker_test.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 gc "launchpad.net/gocheck"10 gc "launchpad.net/gocheck"
1011
11 "launchpad.net/juju-core/constraints"12 "launchpad.net/juju-core/constraints"
12 "launchpad.net/juju-core/environs/config"13 "launchpad.net/juju-core/environs/config"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
16)16)
1717
=== modified file 'state/relation.go'
--- state/relation.go 2014-04-17 12:47:50 +0000
+++ state/relation.go 2014-05-15 02:28:23 +0000
@@ -10,12 +10,12 @@
10 "strconv"10 "strconv"
11 "strings"11 "strings"
1212
13 "github.com/juju/errors"
13 "labix.org/v2/mgo"14 "labix.org/v2/mgo"
14 "labix.org/v2/mgo/bson"15 "labix.org/v2/mgo/bson"
15 "labix.org/v2/mgo/txn"16 "labix.org/v2/mgo/txn"
1617
17 "launchpad.net/juju-core/charm"18 "launchpad.net/juju-core/charm"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/names"19 "launchpad.net/juju-core/names"
20)20)
2121
2222
=== modified file 'state/relation_test.go'
--- state/relation_test.go 2014-04-14 12:36:13 +0000
+++ state/relation_test.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4package state_test4package state_test
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 gc "launchpad.net/gocheck"9 gc "launchpad.net/gocheck"
910
10 "launchpad.net/juju-core/charm"11 "launchpad.net/juju-core/charm"
11 "launchpad.net/juju-core/errors"
12 "launchpad.net/juju-core/state"12 "launchpad.net/juju-core/state"
13)13)
1414
1515
=== modified file 'state/relationunit.go'
--- state/relationunit.go 2014-04-17 12:47:50 +0000
+++ state/relationunit.go 2014-05-15 02:28:23 +0000
@@ -8,12 +8,12 @@
8 "fmt"8 "fmt"
9 "strings"9 "strings"
1010
11 "github.com/juju/errors"
11 "labix.org/v2/mgo"12 "labix.org/v2/mgo"
12 "labix.org/v2/mgo/bson"13 "labix.org/v2/mgo/bson"
13 "labix.org/v2/mgo/txn"14 "labix.org/v2/mgo/txn"
1415
15 "launchpad.net/juju-core/charm"16 "launchpad.net/juju-core/charm"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/names"17 "launchpad.net/juju-core/names"
18)18)
1919
2020
=== modified file 'state/relationunit_test.go'
--- state/relationunit_test.go 2014-04-14 12:36:13 +0000
+++ state/relationunit_test.go 2014-05-15 02:28:23 +0000
@@ -9,11 +9,11 @@
9 "strconv"9 "strconv"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 jc "github.com/juju/testing/checkers"13 jc "github.com/juju/testing/checkers"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
1415
15 "launchpad.net/juju-core/charm"16 "launchpad.net/juju-core/charm"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/instance"17 "launchpad.net/juju-core/instance"
18 "launchpad.net/juju-core/state"18 "launchpad.net/juju-core/state"
19 "launchpad.net/juju-core/state/testing"19 "launchpad.net/juju-core/state/testing"
2020
=== modified file 'state/service.go'
--- state/service.go 2014-04-25 12:19:25 +0000
+++ state/service.go 2014-05-15 02:28:23 +0000
@@ -10,13 +10,13 @@
10 "strconv"10 "strconv"
11 "strings"11 "strings"
1212
13 "github.com/juju/errors"
13 "labix.org/v2/mgo"14 "labix.org/v2/mgo"
14 "labix.org/v2/mgo/bson"15 "labix.org/v2/mgo/bson"
15 "labix.org/v2/mgo/txn"16 "labix.org/v2/mgo/txn"
1617
17 "launchpad.net/juju-core/charm"18 "launchpad.net/juju-core/charm"
18 "launchpad.net/juju-core/constraints"19 "launchpad.net/juju-core/constraints"
19 "launchpad.net/juju-core/errors"
20 "launchpad.net/juju-core/names"20 "launchpad.net/juju-core/names"
21 "launchpad.net/juju-core/state/api/params"21 "launchpad.net/juju-core/state/api/params"
22)22)
2323
=== modified file 'state/service_test.go'
--- state/service_test.go 2014-04-21 23:10:05 +0000
+++ state/service_test.go 2014-05-15 02:28:23 +0000
@@ -7,6 +7,7 @@
7 "fmt"7 "fmt"
8 "sort"8 "sort"
99
10 "github.com/juju/errors"
10 "github.com/juju/loggo"11 "github.com/juju/loggo"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 "labix.org/v2/mgo"13 "labix.org/v2/mgo"
@@ -15,7 +16,6 @@
15 "launchpad.net/juju-core/charm"16 "launchpad.net/juju-core/charm"
16 "launchpad.net/juju-core/constraints"17 "launchpad.net/juju-core/constraints"
17 "launchpad.net/juju-core/environs/config"18 "launchpad.net/juju-core/environs/config"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/state"19 "launchpad.net/juju-core/state"
20 "launchpad.net/juju-core/state/testing"20 "launchpad.net/juju-core/state/testing"
21)21)
2222
=== modified file 'state/settings.go'
--- state/settings.go 2014-03-20 01:23:05 +0000
+++ state/settings.go 2014-05-15 02:28:23 +0000
@@ -8,11 +8,10 @@
8 "sort"8 "sort"
9 "strings"9 "strings"
1010
11 "github.com/juju/errors"
11 "labix.org/v2/mgo"12 "labix.org/v2/mgo"
12 "labix.org/v2/mgo/bson"13 "labix.org/v2/mgo/bson"
13 "labix.org/v2/mgo/txn"14 "labix.org/v2/mgo/txn"
14
15 "launchpad.net/juju-core/errors"
16)15)
1716
18// See: http://docs.mongodb.org/manual/faq/developers/#faq-dollar-sign-escaping17// See: http://docs.mongodb.org/manual/faq/developers/#faq-dollar-sign-escaping
1918
=== modified file 'state/settings_test.go'
--- state/settings_test.go 2014-04-14 12:36:13 +0000
+++ state/settings_test.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4package state4package state
55
6import (6import (
7 "github.com/juju/errors"
7 jc "github.com/juju/testing/checkers"8 jc "github.com/juju/testing/checkers"
8 "labix.org/v2/mgo/txn"9 "labix.org/v2/mgo/txn"
9 gc "launchpad.net/gocheck"10 gc "launchpad.net/gocheck"
1011
11 "launchpad.net/juju-core/errors"
12 "launchpad.net/juju-core/testing"12 "launchpad.net/juju-core/testing"
13 "launchpad.net/juju-core/testing/testbase"13 "launchpad.net/juju-core/testing/testbase"
14)14)
1515
=== modified file 'state/state.go'
--- state/state.go 2014-05-01 16:57:34 +0000
+++ state/state.go 2014-05-15 02:28:23 +0000
@@ -16,6 +16,7 @@
16 "strings"16 "strings"
17 "sync"17 "sync"
1818
19 "github.com/juju/errors"
19 "github.com/juju/loggo"20 "github.com/juju/loggo"
20 "labix.org/v2/mgo"21 "labix.org/v2/mgo"
21 "labix.org/v2/mgo/bson"22 "labix.org/v2/mgo/bson"
@@ -24,7 +25,6 @@
24 "launchpad.net/juju-core/charm"25 "launchpad.net/juju-core/charm"
25 "launchpad.net/juju-core/constraints"26 "launchpad.net/juju-core/constraints"
26 "launchpad.net/juju-core/environs/config"27 "launchpad.net/juju-core/environs/config"
27 "launchpad.net/juju-core/errors"
28 "launchpad.net/juju-core/names"28 "launchpad.net/juju-core/names"
29 "launchpad.net/juju-core/state/api/params"29 "launchpad.net/juju-core/state/api/params"
30 "launchpad.net/juju-core/state/multiwatcher"30 "launchpad.net/juju-core/state/multiwatcher"
3131
=== modified file 'state/state_test.go'
--- state/state_test.go 2014-05-01 16:14:47 +0000
+++ state/state_test.go 2014-05-15 02:28:23 +0000
@@ -10,6 +10,7 @@
10 "strings"10 "strings"
11 "time"11 "time"
1212
13 "github.com/juju/errors"
13 "github.com/juju/loggo"14 "github.com/juju/loggo"
14 jc "github.com/juju/testing/checkers"15 jc "github.com/juju/testing/checkers"
15 "labix.org/v2/mgo"16 "labix.org/v2/mgo"
@@ -19,7 +20,6 @@
19 "launchpad.net/juju-core/charm"20 "launchpad.net/juju-core/charm"
20 "launchpad.net/juju-core/constraints"21 "launchpad.net/juju-core/constraints"
21 "launchpad.net/juju-core/environs/config"22 "launchpad.net/juju-core/environs/config"
22 "launchpad.net/juju-core/errors"
23 "launchpad.net/juju-core/instance"23 "launchpad.net/juju-core/instance"
24 "launchpad.net/juju-core/names"24 "launchpad.net/juju-core/names"
25 "launchpad.net/juju-core/replicaset"25 "launchpad.net/juju-core/replicaset"
2626
=== modified file 'state/status.go'
--- state/status.go 2014-03-26 09:08:23 +0000
+++ state/status.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 "labix.org/v2/mgo"10 "labix.org/v2/mgo"
10 "labix.org/v2/mgo/bson"11 "labix.org/v2/mgo/bson"
11 "labix.org/v2/mgo/txn"12 "labix.org/v2/mgo/txn"
1213
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/state/api/params"14 "launchpad.net/juju-core/state/api/params"
15)15)
1616
1717
=== modified file 'state/tools_test.go'
--- state/tools_test.go 2014-04-14 12:36:13 +0000
+++ state/tools_test.go 2014-05-15 02:28:23 +0000
@@ -6,10 +6,10 @@
6import (6import (
7 "fmt"7 "fmt"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/state"13 "launchpad.net/juju-core/state"
14 "launchpad.net/juju-core/tools"14 "launchpad.net/juju-core/tools"
15 "launchpad.net/juju-core/version"15 "launchpad.net/juju-core/version"
1616
=== modified file 'state/unit.go'
--- state/unit.go 2014-04-30 23:18:40 +0000
+++ state/unit.go 2014-05-15 02:28:23 +0000
@@ -8,6 +8,7 @@
8 "fmt"8 "fmt"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 "github.com/juju/loggo"12 "github.com/juju/loggo"
12 "labix.org/v2/mgo"13 "labix.org/v2/mgo"
13 "labix.org/v2/mgo/bson"14 "labix.org/v2/mgo/bson"
@@ -15,7 +16,6 @@
1516
16 "launchpad.net/juju-core/charm"17 "launchpad.net/juju-core/charm"
17 "launchpad.net/juju-core/constraints"18 "launchpad.net/juju-core/constraints"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/instance"19 "launchpad.net/juju-core/instance"
20 "launchpad.net/juju-core/names"20 "launchpad.net/juju-core/names"
21 "launchpad.net/juju-core/state/api/params"21 "launchpad.net/juju-core/state/api/params"
2222
=== modified file 'state/unit_test.go'
--- state/unit_test.go 2014-04-14 12:36:13 +0000
+++ state/unit_test.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "strconv"7 "strconv"
88
9 "github.com/juju/errors"
9 jc "github.com/juju/testing/checkers"10 jc "github.com/juju/testing/checkers"
10 gc "launchpad.net/gocheck"11 gc "launchpad.net/gocheck"
1112
12 "launchpad.net/juju-core/charm"13 "launchpad.net/juju-core/charm"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15 "launchpad.net/juju-core/state"15 "launchpad.net/juju-core/state"
16 "launchpad.net/juju-core/state/api/params"16 "launchpad.net/juju-core/state/api/params"
1717
=== modified file 'state/user.go'
--- state/user.go 2014-03-28 12:28:30 +0000
+++ state/user.go 2014-05-15 02:28:23 +0000
@@ -4,11 +4,11 @@
4 "fmt"4 "fmt"
5 "regexp"5 "regexp"
66
7 "github.com/juju/errors"
7 "labix.org/v2/mgo"8 "labix.org/v2/mgo"
8 "labix.org/v2/mgo/bson"9 "labix.org/v2/mgo/bson"
9 "labix.org/v2/mgo/txn"10 "labix.org/v2/mgo/txn"
1011
11 "launchpad.net/juju-core/errors"
12 "launchpad.net/juju-core/names"12 "launchpad.net/juju-core/names"
13 "launchpad.net/juju-core/utils"13 "launchpad.net/juju-core/utils"
14)14)
1515
=== modified file 'state/watcher.go'
--- state/watcher.go 2014-04-30 23:18:40 +0000
+++ state/watcher.go 2014-05-15 02:28:23 +0000
@@ -9,13 +9,13 @@
9 "strings"9 "strings"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 "github.com/juju/loggo"13 "github.com/juju/loggo"
13 "labix.org/v2/mgo"14 "labix.org/v2/mgo"
14 "labix.org/v2/mgo/bson"15 "labix.org/v2/mgo/bson"
15 "launchpad.net/tomb"16 "launchpad.net/tomb"
1617
17 "launchpad.net/juju-core/environs/config"18 "launchpad.net/juju-core/environs/config"
18 "launchpad.net/juju-core/errors"
19 "launchpad.net/juju-core/instance"19 "launchpad.net/juju-core/instance"
20 "launchpad.net/juju-core/names"20 "launchpad.net/juju-core/names"
21 "launchpad.net/juju-core/state/api/params"21 "launchpad.net/juju-core/state/api/params"
2222
=== modified file 'worker/authenticationworker/worker.go'
--- worker/authenticationworker/worker.go 2014-04-17 03:41:32 +0000
+++ worker/authenticationworker/worker.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "strings"7 "strings"
88
9 "github.com/juju/errors"
9 "github.com/juju/loggo"10 "github.com/juju/loggo"
10 "launchpad.net/tomb"11 "launchpad.net/tomb"
1112
12 "launchpad.net/juju-core/agent"13 "launchpad.net/juju-core/agent"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/state/api/keyupdater"14 "launchpad.net/juju-core/state/api/keyupdater"
15 "launchpad.net/juju-core/state/api/watcher"15 "launchpad.net/juju-core/state/api/watcher"
16 "launchpad.net/juju-core/utils/set"16 "launchpad.net/juju-core/utils/set"
1717
=== modified file 'worker/deployer/deployer_test.go'
--- worker/deployer/deployer_test.go 2014-04-14 12:36:13 +0000
+++ worker/deployer/deployer_test.go 2014-05-15 02:28:23 +0000
@@ -9,9 +9,9 @@
9 stdtesting "testing"9 stdtesting "testing"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
14 "launchpad.net/juju-core/errors"
15 jujutesting "launchpad.net/juju-core/juju/testing"15 jujutesting "launchpad.net/juju-core/juju/testing"
16 "launchpad.net/juju-core/state"16 "launchpad.net/juju-core/state"
17 "launchpad.net/juju-core/state/api"17 "launchpad.net/juju-core/state/api"
1818
=== modified file 'worker/firewaller/firewaller.go'
--- worker/firewaller/firewaller.go 2014-04-30 23:18:40 +0000
+++ worker/firewaller/firewaller.go 2014-05-15 02:28:23 +0000
@@ -4,7 +4,7 @@
4package firewaller4package firewaller
55
6import (6import (
7 "github.com/errgo/errgo"7 "github.com/juju/errors"
8 "github.com/juju/loggo"8 "github.com/juju/loggo"
9 "launchpad.net/tomb"9 "launchpad.net/tomb"
1010
@@ -122,7 +122,7 @@
122 case change := <-fw.portsChange:122 case change := <-fw.portsChange:
123 change.unitd.ports = change.ports123 change.unitd.ports = change.ports
124 if err := fw.flushUnits([]*unitData{change.unitd}); err != nil {124 if err := fw.flushUnits([]*unitData{change.unitd}); err != nil {
125 return errgo.Annotate(err, "cannot change firewall ports")125 return errors.Annotate(err, "cannot change firewall ports")
126 }126 }
127 case change := <-fw.exposedChange:127 case change := <-fw.exposedChange:
128 change.serviced.exposed = change.exposed128 change.serviced.exposed = change.exposed
@@ -131,7 +131,7 @@
131 unitds = append(unitds, unitd)131 unitds = append(unitds, unitd)
132 }132 }
133 if err := fw.flushUnits(unitds); err != nil {133 if err := fw.flushUnits(unitds); err != nil {
134 return errgo.Annotate(err, "cannot change firewall ports")134 return errors.Annotate(err, "cannot change firewall ports")
135 }135 }
136 }136 }
137 }137 }
@@ -157,7 +157,7 @@
157 if params.IsCodeNotFound(err) {157 if params.IsCodeNotFound(err) {
158 return nil158 return nil
159 } else if err != nil {159 } else if err != nil {
160 return errgo.Annotate(err, "cannot watch machine units")160 return errors.Annotate(err, "cannot watch machine units")
161 }161 }
162 unitw, err := m.WatchUnits()162 unitw, err := m.WatchUnits()
163 if err != nil {163 if err != nil {
@@ -177,7 +177,7 @@
177 if err != nil {177 if err != nil {
178 stop("units watcher", unitw)178 stop("units watcher", unitw)
179 delete(fw.machineds, tag)179 delete(fw.machineds, tag)
180 return errgo.Annotatef(err, "cannot respond to units changes for %q", tag)180 return errors.Annotatef(err, "cannot respond to units changes for %q", tag)
181 }181 }
182 }182 }
183 go machined.watchLoop(unitw)183 go machined.watchLoop(unitw)
@@ -374,7 +374,7 @@
374 }374 }
375 }375 }
376 if err := fw.flushUnits(changed); err != nil {376 if err := fw.flushUnits(changed); err != nil {
377 return errgo.Annotate(err, "cannot change firewall ports")377 return errors.Annotate(err, "cannot change firewall ports")
378 }378 }
379 return nil379 return nil
380}380}
381381
=== modified file 'worker/instancepoller/aggregate.go'
--- worker/instancepoller/aggregate.go 2014-03-13 17:32:36 +0000
+++ worker/instancepoller/aggregate.go 2014-05-15 02:28:23 +0000
@@ -6,11 +6,11 @@
6import (6import (
7 "time"7 "time"
88
9 "github.com/juju/errors"
9 "github.com/juju/ratelimit"10 "github.com/juju/ratelimit"
10 "launchpad.net/tomb"11 "launchpad.net/tomb"
1112
12 "launchpad.net/juju-core/environs"13 "launchpad.net/juju-core/environs"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/instance"14 "launchpad.net/juju-core/instance"
15)15)
1616
1717
=== modified file 'worker/instancepoller/aggregate_test.go'
--- worker/instancepoller/aggregate_test.go 2014-04-15 18:51:24 +0000
+++ worker/instancepoller/aggregate_test.go 2014-05-15 02:28:23 +0000
@@ -9,11 +9,11 @@
9 "sync/atomic"9 "sync/atomic"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 jc "github.com/juju/testing/checkers"13 jc "github.com/juju/testing/checkers"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
1415
15 "launchpad.net/juju-core/environs"16 "launchpad.net/juju-core/environs"
16 "launchpad.net/juju-core/errors"
17 "launchpad.net/juju-core/instance"17 "launchpad.net/juju-core/instance"
18 "launchpad.net/juju-core/testing/testbase"18 "launchpad.net/juju-core/testing/testbase"
19)19)
@@ -163,7 +163,8 @@
163 aggregator := newAggregator(testGetter)163 aggregator := newAggregator(testGetter)
164 _, err := aggregator.instanceInfo("foo")164 _, err := aggregator.instanceInfo("foo")
165165
166 c.Assert(err, gc.DeepEquals, errors.NotFoundf("instance foo"))166 c.Assert(err, gc.ErrorMatches, "instance foo not found")
167 c.Assert(err, jc.Satisfies, errors.IsNotFound)
167}168}
168169
169func (s *aggregateSuite) TestAddressesError(c *gc.C) {170func (s *aggregateSuite) TestAddressesError(c *gc.C) {
170171
=== modified file 'worker/instancepoller/machine_test.go'
--- worker/instancepoller/machine_test.go 2014-05-08 06:58:42 +0000
+++ worker/instancepoller/machine_test.go 2014-05-15 02:28:23 +0000
@@ -13,10 +13,10 @@
13 "sync/atomic"13 "sync/atomic"
14 "time"14 "time"
1515
16 "github.com/juju/errors"
16 jc "github.com/juju/testing/checkers"17 jc "github.com/juju/testing/checkers"
17 gc "launchpad.net/gocheck"18 gc "launchpad.net/gocheck"
1819
19 "launchpad.net/juju-core/errors"
20 "launchpad.net/juju-core/instance"20 "launchpad.net/juju-core/instance"
21 "launchpad.net/juju-core/state"21 "launchpad.net/juju-core/state"
22 "launchpad.net/juju-core/state/api/params"22 "launchpad.net/juju-core/state/api/params"
2323
=== modified file 'worker/instancepoller/updater.go'
--- worker/instancepoller/updater.go 2014-05-08 06:58:42 +0000
+++ worker/instancepoller/updater.go 2014-05-15 02:28:23 +0000
@@ -7,9 +7,9 @@
7 "fmt"7 "fmt"
8 "time"8 "time"
99
10 "github.com/juju/errors"
10 "github.com/juju/loggo"11 "github.com/juju/loggo"
1112
12 "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/instance"13 "launchpad.net/juju-core/instance"
14 "launchpad.net/juju-core/state"14 "launchpad.net/juju-core/state"
15 "launchpad.net/juju-core/state/api/params"15 "launchpad.net/juju-core/state/api/params"
1616
=== modified file 'worker/peergrouper/mock_test.go'
--- worker/peergrouper/mock_test.go 2014-04-17 16:13:09 +0000
+++ worker/peergrouper/mock_test.go 2014-05-15 02:28:23 +0000
@@ -12,9 +12,9 @@
12 "strconv"12 "strconv"
13 "sync"13 "sync"
1414
15 "github.com/juju/errors"
15 "launchpad.net/tomb"16 "launchpad.net/tomb"
1617
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/instance"18 "launchpad.net/juju-core/instance"
19 "launchpad.net/juju-core/replicaset"19 "launchpad.net/juju-core/replicaset"
20 "launchpad.net/juju-core/state"20 "launchpad.net/juju-core/state"
2121
=== modified file 'worker/peergrouper/worker.go'
--- worker/peergrouper/worker.go 2014-04-17 17:30:48 +0000
+++ worker/peergrouper/worker.go 2014-05-15 02:28:23 +0000
@@ -8,10 +8,10 @@
8 "sync"8 "sync"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 "launchpad.net/tomb"12 "launchpad.net/tomb"
1213
13 "launchpad.net/juju-core/agent/mongo"14 "launchpad.net/juju-core/agent/mongo"
14 "launchpad.net/juju-core/errors"
15 "launchpad.net/juju-core/instance"15 "launchpad.net/juju-core/instance"
16 "launchpad.net/juju-core/replicaset"16 "launchpad.net/juju-core/replicaset"
17 "launchpad.net/juju-core/state"17 "launchpad.net/juju-core/state"
1818
=== modified file 'worker/provisioner/kvm-broker_test.go'
--- worker/provisioner/kvm-broker_test.go 2014-05-14 02:59:53 +0000
+++ worker/provisioner/kvm-broker_test.go 2014-05-15 02:28:23 +0000
@@ -8,6 +8,7 @@
8 "path/filepath"8 "path/filepath"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
@@ -17,7 +18,6 @@
17 "launchpad.net/juju-core/container/kvm/mock"18 "launchpad.net/juju-core/container/kvm/mock"
18 kvmtesting "launchpad.net/juju-core/container/kvm/testing"19 kvmtesting "launchpad.net/juju-core/container/kvm/testing"
19 "launchpad.net/juju-core/environs"20 "launchpad.net/juju-core/environs"
20 "launchpad.net/juju-core/errors"
21 "launchpad.net/juju-core/instance"21 "launchpad.net/juju-core/instance"
22 instancetest "launchpad.net/juju-core/instance/testing"22 instancetest "launchpad.net/juju-core/instance/testing"
23 jujutesting "launchpad.net/juju-core/juju/testing"23 jujutesting "launchpad.net/juju-core/juju/testing"
2424
=== modified file 'worker/provisioner/lxc-broker_test.go'
--- worker/provisioner/lxc-broker_test.go 2014-05-14 02:59:53 +0000
+++ worker/provisioner/lxc-broker_test.go 2014-05-15 02:28:23 +0000
@@ -9,6 +9,7 @@
9 "path/filepath"9 "path/filepath"
10 "time"10 "time"
1111
12 "github.com/juju/errors"
12 jc "github.com/juju/testing/checkers"13 jc "github.com/juju/testing/checkers"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
1415
@@ -18,7 +19,6 @@
18 "launchpad.net/juju-core/container/lxc/mock"19 "launchpad.net/juju-core/container/lxc/mock"
19 lxctesting "launchpad.net/juju-core/container/lxc/testing"20 lxctesting "launchpad.net/juju-core/container/lxc/testing"
20 "launchpad.net/juju-core/environs"21 "launchpad.net/juju-core/environs"
21 "launchpad.net/juju-core/errors"
22 "launchpad.net/juju-core/instance"22 "launchpad.net/juju-core/instance"
23 instancetest "launchpad.net/juju-core/instance/testing"23 instancetest "launchpad.net/juju-core/instance/testing"
24 jujutesting "launchpad.net/juju-core/juju/testing"24 jujutesting "launchpad.net/juju-core/juju/testing"
2525
=== modified file 'worker/provisioner/provisioner.go'
--- worker/provisioner/provisioner.go 2014-04-14 12:36:13 +0000
+++ worker/provisioner/provisioner.go 2014-05-15 02:28:23 +0000
@@ -6,13 +6,13 @@
6import (6import (
7 "sync"7 "sync"
88
9 "github.com/juju/errors"
9 "github.com/juju/loggo"10 "github.com/juju/loggo"
10 "launchpad.net/tomb"11 "launchpad.net/tomb"
1112
12 "launchpad.net/juju-core/agent"13 "launchpad.net/juju-core/agent"
13 "launchpad.net/juju-core/environs"14 "launchpad.net/juju-core/environs"
14 "launchpad.net/juju-core/environs/config"15 "launchpad.net/juju-core/environs/config"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/instance"16 "launchpad.net/juju-core/instance"
17 apiprovisioner "launchpad.net/juju-core/state/api/provisioner"17 apiprovisioner "launchpad.net/juju-core/state/api/provisioner"
18 apiwatcher "launchpad.net/juju-core/state/api/watcher"18 apiwatcher "launchpad.net/juju-core/state/api/watcher"
1919
=== modified file 'worker/provisioner/provisioner_test.go'
--- worker/provisioner/provisioner_test.go 2014-05-13 11:37:40 +0000
+++ worker/provisioner/provisioner_test.go 2014-05-15 02:28:23 +0000
@@ -8,6 +8,7 @@
8 "strings"8 "strings"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
@@ -17,7 +18,6 @@
17 "launchpad.net/juju-core/environs/network"18 "launchpad.net/juju-core/environs/network"
18 "launchpad.net/juju-core/environs/simplestreams"19 "launchpad.net/juju-core/environs/simplestreams"
19 "launchpad.net/juju-core/environs/tools"20 "launchpad.net/juju-core/environs/tools"
20 "launchpad.net/juju-core/errors"
21 "launchpad.net/juju-core/instance"21 "launchpad.net/juju-core/instance"
22 "launchpad.net/juju-core/juju/testing"22 "launchpad.net/juju-core/juju/testing"
23 "launchpad.net/juju-core/names"23 "launchpad.net/juju-core/names"
2424
=== modified file 'worker/rsyslog/worker.go'
--- worker/rsyslog/worker.go 2014-04-24 11:55:01 +0000
+++ worker/rsyslog/worker.go 2014-05-15 02:28:23 +0000
@@ -10,7 +10,7 @@
10 "strconv"10 "strconv"
11 "time"11 "time"
1212
13 "github.com/errgo/errgo"13 "github.com/juju/errors"
14 "github.com/juju/loggo"14 "github.com/juju/loggo"
1515
16 "launchpad.net/juju-core/agent"16 "launchpad.net/juju-core/agent"
@@ -122,7 +122,7 @@
122func (h *RsyslogConfigHandler) SetUp() (watcher.NotifyWatcher, error) {122func (h *RsyslogConfigHandler) SetUp() (watcher.NotifyWatcher, error) {
123 if h.mode == RsyslogModeAccumulate {123 if h.mode == RsyslogModeAccumulate {
124 if err := h.ensureCertificates(); err != nil {124 if err := h.ensureCertificates(); err != nil {
125 return nil, errgo.Annotate(err, "failed to write rsyslog certificates")125 return nil, errors.Annotate(err, "failed to write rsyslog certificates")
126 }126 }
127 }127 }
128 return h.st.WatchForEnvironConfigChanges()128 return h.st.WatchForEnvironConfigChanges()
@@ -140,7 +140,7 @@
140func (h *RsyslogConfigHandler) Handle() error {140func (h *RsyslogConfigHandler) Handle() error {
141 cfg, err := h.st.EnvironConfig()141 cfg, err := h.st.EnvironConfig()
142 if err != nil {142 if err != nil {
143 return errgo.Annotate(err, "cannot get environ config")143 return errors.Annotate(err, "cannot get environ config")
144 }144 }
145 rsyslogCACert := cfg.RsyslogCACert()145 rsyslogCACert := cfg.RsyslogCACert()
146 if rsyslogCACert == "" {146 if rsyslogCACert == "" {
@@ -154,20 +154,20 @@
154 h.syslogConfig.Port = cfg.SyslogPort()154 h.syslogConfig.Port = cfg.SyslogPort()
155 if h.mode == RsyslogModeForwarding {155 if h.mode == RsyslogModeForwarding {
156 if err := writeFileAtomic(h.syslogConfig.CACertPath(), []byte(rsyslogCACert), 0644, 0, 0); err != nil {156 if err := writeFileAtomic(h.syslogConfig.CACertPath(), []byte(rsyslogCACert), 0644, 0, 0); err != nil {
157 return errgo.Annotate(err, "cannot write CA certificate")157 return errors.Annotate(err, "cannot write CA certificate")
158 }158 }
159 }159 }
160 data, err := h.syslogConfig.Render()160 data, err := h.syslogConfig.Render()
161 if err != nil {161 if err != nil {
162 return errgo.Annotate(err, "failed to render rsyslog configuration file")162 return errors.Annotate(err, "failed to render rsyslog configuration file")
163 }163 }
164 if err := writeFileAtomic(h.syslogConfig.ConfigFilePath(), []byte(data), 0644, 0, 0); err != nil {164 if err := writeFileAtomic(h.syslogConfig.ConfigFilePath(), []byte(data), 0644, 0, 0); err != nil {
165 return errgo.Annotate(err, "failed to write rsyslog configuration file")165 return errors.Annotate(err, "failed to write rsyslog configuration file")
166 }166 }
167 logger.Debugf("Reloading rsyslog configuration")167 logger.Debugf("Reloading rsyslog configuration")
168 if err := restartRsyslog(); err != nil {168 if err := restartRsyslog(); err != nil {
169 logger.Errorf("failed to reload rsyslog configuration")169 logger.Errorf("failed to reload rsyslog configuration")
170 return errgo.Annotate(err, "cannot restart rsyslog")170 return errors.Annotate(err, "cannot restart rsyslog")
171 }171 }
172 // Record config values so we don't try again.172 // Record config values so we don't try again.
173 // Do this last so we recover from intermittent173 // Do this last so we recover from intermittent
174174
=== modified file 'worker/uniter/charm/bundles.go'
--- worker/uniter/charm/bundles.go 2014-04-17 12:47:50 +0000
+++ worker/uniter/charm/bundles.go 2014-05-15 02:28:23 +0000
@@ -8,9 +8,10 @@
8 "os"8 "os"
9 "path"9 "path"
1010
11 "github.com/juju/errors"
12
11 "launchpad.net/juju-core/charm"13 "launchpad.net/juju-core/charm"
12 "launchpad.net/juju-core/downloader"14 "launchpad.net/juju-core/downloader"
13 "launchpad.net/juju-core/errors"
14 "launchpad.net/juju-core/utils"15 "launchpad.net/juju-core/utils"
15)16)
1617
1718
=== modified file 'worker/uniter/relation/relation.go'
--- worker/uniter/relation/relation.go 2014-04-17 12:47:50 +0000
+++ worker/uniter/relation/relation.go 2014-05-15 02:28:23 +0000
@@ -13,8 +13,9 @@
13 "strconv"13 "strconv"
14 "strings"14 "strings"
1515
16 "github.com/juju/errors"
17
16 "launchpad.net/juju-core/charm/hooks"18 "launchpad.net/juju-core/charm/hooks"
17 "launchpad.net/juju-core/errors"
18 "launchpad.net/juju-core/utils"19 "launchpad.net/juju-core/utils"
19 "launchpad.net/juju-core/worker/uniter/hook"20 "launchpad.net/juju-core/worker/uniter/hook"
20)21)
2122
=== modified file 'worker/uniter/relationer_test.go'
--- worker/uniter/relationer_test.go 2014-04-14 12:36:13 +0000
+++ worker/uniter/relationer_test.go 2014-05-15 02:28:23 +0000
@@ -8,11 +8,11 @@
8 "strings"8 "strings"
9 "time"9 "time"
1010
11 "github.com/juju/errors"
11 jc "github.com/juju/testing/checkers"12 jc "github.com/juju/testing/checkers"
12 gc "launchpad.net/gocheck"13 gc "launchpad.net/gocheck"
1314
14 "launchpad.net/juju-core/charm/hooks"15 "launchpad.net/juju-core/charm/hooks"
15 "launchpad.net/juju-core/errors"
16 "launchpad.net/juju-core/instance"16 "launchpad.net/juju-core/instance"
17 jujutesting "launchpad.net/juju-core/juju/testing"17 jujutesting "launchpad.net/juju-core/juju/testing"
18 "launchpad.net/juju-core/state"18 "launchpad.net/juju-core/state"
1919
=== modified file 'worker/uniter/state.go'
--- worker/uniter/state.go 2014-04-17 12:47:50 +0000
+++ worker/uniter/state.go 2014-05-15 02:28:23 +0000
@@ -4,12 +4,12 @@
4package uniter4package uniter
55
6import (6import (
7 "errors"
8 "fmt"7 "fmt"
9 "os"8 "os"
109
10 "github.com/juju/errors"
11
11 "launchpad.net/juju-core/charm"12 "launchpad.net/juju-core/charm"
12 coreerrors "launchpad.net/juju-core/errors"
13 "launchpad.net/juju-core/utils"13 "launchpad.net/juju-core/utils"
14 uhook "launchpad.net/juju-core/worker/uniter/hook"14 uhook "launchpad.net/juju-core/worker/uniter/hook"
15)15)
@@ -75,7 +75,7 @@
7575
76// validate returns an error if the state violates expectations.76// validate returns an error if the state violates expectations.
77func (st State) validate() (err error) {77func (st State) validate() (err error) {
78 defer coreerrors.Maskf(&err, "invalid uniter state")78 defer errors.Maskf(&err, "invalid uniter state")
79 hasHook := st.Hook != nil79 hasHook := st.Hook != nil
80 hasCharm := st.CharmURL != nil80 hasCharm := st.CharmURL != nil
81 switch st.Op {81 switch st.Op {
8282
=== modified file 'worker/uniter/uniter_test.go'
--- worker/uniter/uniter_test.go 2014-05-13 23:18:30 +0000
+++ worker/uniter/uniter_test.go 2014-05-15 02:28:23 +0000
@@ -17,6 +17,7 @@
17 stdtesting "testing"17 stdtesting "testing"
18 "time"18 "time"
1919
20 "github.com/juju/errors"
20 gt "github.com/juju/testing"21 gt "github.com/juju/testing"
21 jc "github.com/juju/testing/checkers"22 jc "github.com/juju/testing/checkers"
22 gc "launchpad.net/gocheck"23 gc "launchpad.net/gocheck"
@@ -24,7 +25,6 @@
2425
25 "launchpad.net/juju-core/agent/tools"26 "launchpad.net/juju-core/agent/tools"
26 corecharm "launchpad.net/juju-core/charm"27 corecharm "launchpad.net/juju-core/charm"
27 "launchpad.net/juju-core/errors"
28 "launchpad.net/juju-core/instance"28 "launchpad.net/juju-core/instance"
29 "launchpad.net/juju-core/juju/osenv"29 "launchpad.net/juju-core/juju/osenv"
30 "launchpad.net/juju-core/juju/testing"30 "launchpad.net/juju-core/juju/testing"
3131
=== modified file 'worker/upgrader/upgrader_test.go'
--- worker/upgrader/upgrader_test.go 2014-04-14 12:36:13 +0000
+++ worker/upgrader/upgrader_test.go 2014-05-15 02:28:23 +0000
@@ -10,6 +10,7 @@
10 stdtesting "testing"10 stdtesting "testing"
11 "time"11 "time"
1212
13 "github.com/juju/errors"
13 gc "launchpad.net/gocheck"14 gc "launchpad.net/gocheck"
14 coretesting "launchpad.net/juju-core/testing"15 coretesting "launchpad.net/juju-core/testing"
1516
@@ -18,7 +19,6 @@
18 agenttools "launchpad.net/juju-core/agent/tools"19 agenttools "launchpad.net/juju-core/agent/tools"
19 envtesting "launchpad.net/juju-core/environs/testing"20 envtesting "launchpad.net/juju-core/environs/testing"
20 envtools "launchpad.net/juju-core/environs/tools"21 envtools "launchpad.net/juju-core/environs/tools"
21 "launchpad.net/juju-core/errors"
22 jujutesting "launchpad.net/juju-core/juju/testing"22 jujutesting "launchpad.net/juju-core/juju/testing"
23 "launchpad.net/juju-core/provider/dummy"23 "launchpad.net/juju-core/provider/dummy"
24 "launchpad.net/juju-core/state"24 "launchpad.net/juju-core/state"

Subscribers

People subscribed via source and target branches

to status/vote changes: