Code review comment for lp:~thumper/juju-core/instance-id

Revision history for this message
Ian Booth (wallyworld) wrote :

LGTM with the rename suggestion.

https://codereview.appspot.com/10325043/diff/1/environs/maas/instance.go
File environs/maas/instance.go (right):

https://codereview.appspot.com/10325043/diff/1/environs/maas/instance.go#newcode20
environs/maas/instance.go:20: func (this *maasInstance) Id() instance.Id
{
The usual convention would be something like:
func (mi *maasInstance) Id() instance.Id {

https://codereview.appspot.com/10325043/

« Back to merge proposal