Code review comment for lp:~thumper/juju-core/fix-uniter-proxy-env-vars

Reviewers: mp+203459_code.launchpad.net,

Message:
Please take a look.

Description:
Fix the proxy env vars in the uniter.

The shell variables exported in the uniter are
incorrect. They should have underscores not
dashes.

In an attempt to reduce the likelihood of this
happening again, moved the proxy code to use string
constants.

https://code.launchpad.net/~thumper/juju-core/fix-uniter-proxy-env-vars/+merge/203459

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/57590043/

Affected files (+101, -36 lines):
   A [revision details]
   M environs/config/config.go
   M environs/config/config_test.go
   M juju/osenv/proxy.go
   M juju/osenv/proxy_test.go
   M provider/local/environprovider_test.go
   M worker/uniter/uniter_test.go