Code review comment for lp:~thumper/juju-core/fix-provider-query-in-machine-env-worker

Revision history for this message
Tim Penhey (thumper) wrote :

https://codereview.appspot.com/61990043/diff/20001/worker/machineenvironmentworker/machineenvironmentworker.go
File worker/machineenvironmentworker/machineenvironmentworker.go
(right):

https://codereview.appspot.com/61990043/diff/20001/worker/machineenvironmentworker/machineenvironmentworker.go#newcode69
worker/machineenvironmentworker/machineenvironmentworker.go:69:
agentConfig.Value(agent.ProviderType) == provider.Local)
On 2014/02/12 23:04:45, wallyworld wrote:
> I still wish this were

> writeSystemFiles := agentConfig.Tag() != names.MachineTag("0") ||
> agentConfig.Value(agent.JujuProviderType) != provider.Local

> much easier to parse and no brackets

Done.

https://codereview.appspot.com/61990043/

« Back to merge proposal