Merge lp:~thumper/juju-core/fix-local-bootstrap into lp:juju-core/1.16

Proposed by Tim Penhey
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 1973
Proposed branch: lp:~thumper/juju-core/fix-local-bootstrap
Merge into: lp:juju-core/1.16
Diff against target: 15 lines (+5/-0)
1 file modified
provider/local/environ.go (+5/-0)
To merge this branch: bzr merge lp:~thumper/juju-core/fix-local-bootstrap
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+191522@code.launchpad.net

Commit message

Fix local provider bootstrap.

The bootstrap storage was not set up for the local
provider.

https://codereview.appspot.com/14439067/

Description of the change

Fix local provider bootstrap.

The bootstrap storage was not set up for the local
provider.

https://codereview.appspot.com/14439067/

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+191522_code.launchpad.net,

Message:
Please take a look.

Description:
Fix local provider bootstrap.

The bootstrap storage was not set up for the local
provider.

https://code.launchpad.net/~thumper/juju-core/fix-local-bootstrap/+merge/191522

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14439067/

Affected files (+7, -0 lines):
   A [revision details]
   M provider/local/environ.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20131010031125-8lgphpzdl93berr7
+New revision: <email address hidden>

Index: provider/local/environ.go
=== modified file 'provider/local/environ.go'
--- provider/local/environ.go 2013-10-04 08:45:50 +0000
+++ provider/local/environ.go 2013-10-16 21:28:54 +0000
@@ -335,6 +335,11 @@
   return httpstorage.Client(env.config.sharedStorageAddr())
  }

+// Implements environs.BootstrapStorager.
+func (env *localEnviron) EnableBootstrapStorage() error {
+ return env.setupLocalStorage()
+}
+
  // Destroy is specified in the Environ interface.
  func (env *localEnviron) Destroy() error {
   if !env.config.runningAsRoot {

Revision history for this message
Tim Penhey (thumper) wrote :

On 2013/10/16 22:31:25, thumper wrote:
> Please take a look.

LGTM - just backporting fix to 1.16

https://codereview.appspot.com/14439067/

Revision history for this message
Tim Penhey (thumper) wrote :

Self approving the backport of the fix to 1.16

review: Approve
Revision history for this message
Sidnei da Silva (sidnei) wrote :

On 2013/10/16 22:36:52, thumper wrote:
> On 2013/10/16 22:31:25, thumper wrote:
> > Please take a look.

> LGTM - just backporting fix to 1.16

LGTM.

https://codereview.appspot.com/14439067/

Revision history for this message
Sidnei da Silva (sidnei) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'provider/local/environ.go'
2--- provider/local/environ.go 2013-10-04 08:45:50 +0000
3+++ provider/local/environ.go 2013-10-16 22:29:44 +0000
4@@ -335,6 +335,11 @@
5 return httpstorage.Client(env.config.sharedStorageAddr())
6 }
7
8+// Implements environs.BootstrapStorager.
9+func (env *localEnviron) EnableBootstrapStorage() error {
10+ return env.setupLocalStorage()
11+}
12+
13 // Destroy is specified in the Environ interface.
14 func (env *localEnviron) Destroy() error {
15 if !env.config.runningAsRoot {

Subscribers

People subscribed via source and target branches

to all changes: