Reviewers: mp+185420_code.launchpad.net,
Message: Please take a look.
Description: Don't specify the log-file for the machine agent.
Logging now supports multiple locations. We were writing to both stderr and the logfile, and getting duplicate lines.
Surprisingly, the unit agent didn't specify this.
https://code.launchpad.net/~thumper/juju-core/fix-duplicate-agent-log-lines/+merge/185420
(do not edit description out of merge proposal)
Please review this at https://codereview.appspot.com/13694043/
Affected files (+2, -1 lines): A [revision details] M upstart/service.go
Index: [revision details] === added file '[revision details]' --- [revision details] 2012-01-01 00:00:00 +0000 +++ [revision details] 2012-01-01 00:00:00 +0000 @@ -0,0 +1,2 @@ +Old revision: tarmac-20130913044751-ah3cblx7arm3h2tm +New revision: <email address hidden>
Index: upstart/service.go === modified file 'upstart/service.go' --- upstart/service.go 2013-07-30 22:21:47 +0000 +++ upstart/service.go 2013-09-13 05:20:56 +0000 @@ -53,7 +53,6 @@ }, Cmd: filepath.Join(toolsDir, "jujud") + " machine" + - " --log-file " + utils.ShQuote(logFile) + " --data-dir " + utils.ShQuote(dataDir) + " --machine-id " + machineId + " " + logConfig,
« Back to merge proposal
Reviewers: mp+185420_ code.launchpad. net,
Message:
Please take a look.
Description:
Don't specify the log-file for the machine agent.
Logging now supports multiple locations. We were writing
to both stderr and the logfile, and getting duplicate lines.
Surprisingly, the unit agent didn't specify this.
https:/ /code.launchpad .net/~thumper/ juju-core/ fix-duplicate- agent-log- lines/+ merge/185420
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13694043/
Affected files (+2, -1 lines):
A [revision details]
M upstart/service.go
Index: [revision details] 20130913044751- ah3cblx7arm3h2t m
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-
+New revision: <email address hidden>
Index: upstart/service.go service. go' Join(toolsDir, "jujud") + logFile) + dataDir) +
=== modified file 'upstart/
--- upstart/service.go 2013-07-30 22:21:47 +0000
+++ upstart/service.go 2013-09-13 05:20:56 +0000
@@ -53,7 +53,6 @@
},
Cmd: filepath.
" machine" +
- " --log-file " + utils.ShQuote(
" --data-dir " + utils.ShQuote(
" --machine-id " + machineId +
" " + logConfig,