https://codereview.appspot.com/85570045/diff/20001/state/apiserver/debuglog.go#newcode258
state/apiserver/debuglog.go:258: if stream.started && result &&
stream.maxLines > 0 {
It would be better to just split filterLine into something non-counting
and counting, where the latter calls the former and adds the linecount
check. Then you don't need the boolean.
LGTM with a few suggestions
https:/ /codereview. appspot. com/85570045/ diff/20001/ state/apiserver /debuglog. go /debuglog. go (right):
File state/apiserver
https:/ /codereview. appspot. com/85570045/ diff/20001/ state/apiserver /debuglog. go#newcode225 /debuglog. go:225: err := tailer. SeekLastLines( logFile, SeekLastLines( ...
state/apiserver
stream.backlog, stream.filterLine)
return tailer.
https:/ /codereview. appspot. com/85570045/ diff/20001/ state/apiserver /debuglog. go#newcode258 /debuglog. go:258: if stream.started && result &&
state/apiserver
stream.maxLines > 0 {
It would be better to just split filterLine into something non-counting
and counting, where the latter calls the former and adds the linecount
check. Then you don't need the boolean.
https:/ /codereview. appspot. com/85570045/ diff/20001/ utils/tailer/ tailer. go tailer. go (right):
File utils/tailer/
https:/ /codereview. appspot. com/85570045/ diff/20001/ utils/tailer/ tailer. go#newcode31 tailer. go:31: // TailerFilterSta rtedFunc is a callback that
utils/tailer/
is called when the filtering is
Delete this?
https:/ /codereview. appspot. com/85570045/