Code review comment for lp:~thumper/juju-core/find-ipv4-address

Is this an address or a range? /24 is a range over 256 addresses, isnt it?
I may be wrong on the name, but I would have thought this would be
something more like GetIPv4AddressRange. I realize you are dropping the /24
but that is only valid if it is /32 (fully specify one ip) isnt it?

Also, is it possible to avoid forcing v4? It would be really nice if we
didnt have to do a lot of work to be compatible with v6.

Anyway, if we need to do this the helper is nice to have and it looks well
tested.

John
=:->
On Jul 5, 2013 5:07 AM, "Tim Penhey" <email address hidden> wrote:

> The proposal to merge lp:~thumper/juju-core/find-ipv4-address into
> lp:juju-core has been updated.
>
> Description changed to:
>
> Utility function to find IPv4 address.
>
> There was no simple way to get an IPv4 address for
> a particular net.Interface. So I added this.
>
> https://codereview.appspot.com/10951043/
>
>
> For more details, see:
>
> https://code.launchpad.net/~thumper/juju-core/find-ipv4-address/+merge/173119
> --
>
> https://code.launchpad.net/~thumper/juju-core/find-ipv4-address/+merge/173119
> You are subscribed to branch lp:juju-core.
>