Code review comment for lp:~thumper/juju-core/fast-lxc

Revision history for this message
Tim Penhey (thumper) wrote :

On 2014/03/06 23:20:15, sidnei.da.silva wrote:
> https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go
> File provider/local/lxc.go (right):

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go#newcode38
> provider/local/lxc.go:38: return value >= 14.04
> Is it possible at all to do a feature check instead of a version check
here
> (even if it means parsing lxc-create --help)? It should technically be
possible
> to use fast lxc if you have a backport of lxc 1.0 for anything between
precise
> and trusty.

While technically possible, it seemed reasonable to me and others to
keep it simple and say this is a trusty feature.

https://codereview.appspot.com/72210043/

« Back to merge proposal