I'm not fully across the finer details about lxc cloning. I think this
looks good. Perhaps a little more test coverage though. Specifically:
1. EnsureCloneTemplate behaves correctly if called when a template
already exists
2. The cloud init contents are devoid of apt stuff
I'm not fully across the finer details about lxc cloning. I think this
looks good. Perhaps a little more test coverage though. Specifically:
1. EnsureCloneTemplate behaves correctly if called when a template
already exists
2. The cloud init contents are devoid of apt stuff
https:/ /codereview. appspot. com/74370044/ diff/1/ container/ lxc/lxc. go lxc/lxc. go (right):
File container/
https:/ /codereview. appspot. com/74370044/ diff/1/ container/ lxc/lxc. go#newcode92 lxc/lxc. go:92: if conf["use-clone"] == "true" {
container/
Is there a helper function for str -> bool?
https:/ /codereview. appspot. com/74370044/ diff/1/ container/ lxc/lxc_ test.go lxc/lxc_ test.go (right):
File container/
https:/ /codereview. appspot. com/74370044/ diff/1/ container/ lxc/lxc_ test.go# newcode165 lxc/lxc_ test.go: 165: func (s *LxcSuite) AssertEvent(c *gc.C,
container/
event mock.Event, expected mock.Action, id string) {
does this need to be exported?
https:/ /codereview. appspot. com/74370044/ diff/1/ container/ lxc/lxc_ test.go# newcode203 lxc/lxc_ test.go: 203: c.Assert( template. Name(), gc.Equals,
container/
name)
Should we be checking (some key aspects of) the contents of the
template?
https:/ /codereview. appspot. com/74370044/