Code review comment for lp:~thumper/juju-core/default-command-info

Revision history for this message
Tim Penhey (thumper) wrote :

On 2013/11/06 11:45:34, jameinel wrote:
> We have a cmd.Context object which is passed to all the commands, and
is
> something that we can then pass into internal code.

> It seems better to have it on an object, rather than as a package
level
> function.

> does that make sense to you?

moved the methods to the context object.

I had originally thought that by having them as stand alone functions,
we wouldn't have to pass the context down to the places that are needing
them.

Consider the bastardisation we have with loggers at the moment.

https://codereview.appspot.com/22320043/

« Back to merge proposal