Code review comment for lp:~thumper/juju-core/default-command-info

On 2013/11/06 04:31:25, wallyworld wrote:
> A few questions.

> 1. -d for debug is sorta bad

> There's a number of existing commands that use the -d option (eg for
specifying
> a directory) so I think we want to stcik with just --debug

Removed -d

> 2. Does it make sense to allow -q and --debug together?

> If you want debug, then I think you would want everything else as well

Yes -q and --debug is fine (IMO). In fact I force the fact, as if you
say
--debug, by forcing -q we get all the info, and verbose output as log
file
entries.

> 3. show-log

> I think if verbose is specified, that could turn on show-log. Do we
still need
> show-log? I'm not sure we do. For a user's perspective, I want to see
either:

> i. nothing at all except errors... option = "--quiet"
> ii. informational lines that signpost where the command is up to as it
executes
> (without timestamps etc)... the default, option = ""
> iii. verbose output with timestamps and some more detail... option =
"--verbose"

> As a developer, I also want:

> iv. debug output with everything... option = "--debug"

> I'm not sure with the above if show-log is still relevant.

Perhaps not... but outside the scope of this for now.

> As for the stdout vs stderr thing, I can see both sides. My initial
view is that
> stderr is for all log outout and stdout is for command results in
json/yaml etc

> https://codereview.appspot.com/22320043/diff/1/cmd/logging.go
> File cmd/logging.go (right):

https://codereview.appspot.com/22320043/diff/1/cmd/logging.go#newcode77
> cmd/logging.go:77: return fmt.Errorf(`"verbose" and "quiet" flags
clash`)
> perhaps

> "verbose" and "quiet" flags clash, please use one or the other, not
both

done

https://codereview.appspot.com/22320043/