Code review comment for lp:~thumper/juju-core/debug-log-apiserver

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+214455_code.launchpad.net,

Message:
Please take a look.

Description:
Add debug-log server api

Add the server side end-point for the debug-log api
call. This is implemented as a websocket, with the
request parameters defining the filtering behaviour,
and the log lines that match being streamed back to
the user over the web-socket.

The first line over the websocket is the an error
structure. If there are any issues either processing
the parameters or opening the log file, there is
an error, and if not, the Error component is 'null'.

The capabilities of the server match the older python
version as closely as possible.

https://code.launchpad.net/~thumper/juju-core/debug-log-apiserver/+merge/214455

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/84880044/

Affected files (+971, -0 lines):
   A [revision details]
   M state/apiserver/apiserver.go
   A state/apiserver/debuglog.go
   A state/apiserver/debuglog_internal_test.go
   A state/apiserver/debuglog_test.go

« Back to merge proposal