Code review comment for lp:~thumper/juju-core/debug-log-api-client
Revision history for this message
| Tim Penhey (thumper) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Please take a look.
https:/
File state/api/client.go (right):
https:/
state/api/
filtering of the log messages. If the
On 2014/04/10 07:04:18, rog wrote:
> // DebugLogParams holds parameters for WatchDebugLog that
> // control the filtering of the log messages.
> ?
> Thanks a lot for documenting these, BTW. It makes a big difference.
Done.
https:/
state/api/
included.
On 2014/04/10 07:04:18, rog wrote:
> s/ / /
> Does the inclusion of a logging module here imply all its sub-modules
too?
Yes, updated.
https:/
state/api/
On 2014/04/10 07:04:18, rog wrote:
> // If zero, there is no limit.
> ?
Updated.
https:/
state/api/
On 2014/04/10 07:04:18, rog wrote:
> Just realised - we probably want %q here so that we don't get a blank
line in
> the log.
Done.
https:/
File state/api/
https:/
state/api/
err}, nil
On 2014/04/10 07:04:18, rog wrote:
> or ioutil.
> then you can lose the ReadCloser field inside badReader.
Good call.
https:/
state/api/
func(*websocket
On 2014/04/10 07:04:18, rog wrote:
> s/echoUrl/echoURL/
> (Go convention is to capitalise either all or none of an acronym)
Done.
https:/
File state/api/
https:/
state/api/
On 2014/04/10 07:04:18, rog wrote:
> s/apiserver/agent running the API server./
> ?
Done.
https:/
File state/apiserver
https:/
state/apiserver
current version that the api server is running.
On 2014/04/10 07:04:18, rog wrote:
> s/api/API/
Done.
https:/