Code review comment for lp:~thumper/juju-core/container-interface

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+194757_code.launchpad.net,

Message:
Please take a look.

Description:
Move generic bits to container package.

The ContainerManager and the config type to create
it are common over both LXC and KVM. Also, network
config is similarly generic.

Most of this work is just moving types, changing imports
and parameter types.

https://code.launchpad.net/~thumper/juju-core/container-interface/+merge/194757

Requires:
https://code.launchpad.net/~thumper/juju-core/fix-add-machine-test/+merge/194753

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/24780043/

Affected files (+106, -81 lines):
   A [revision details]
   A container/interface.go
   M container/lxc/lxc.go
   M container/lxc/lxc_test.go
   A container/network.go
   M provider/local/environ.go
   M worker/provisioner/lxc-broker.go

« Back to merge proposal