Code review comment for lp:~thumper/juju-core/container-dir-filesystem-type

Revision history for this message
Andrew Wilkins (axwalk) wrote :

https://codereview.appspot.com/73310043/diff/1/container/lxc/lxc.go
File container/lxc/lxc.go (right):

https://codereview.appspot.com/73310043/diff/1/container/lxc/lxc.go#newcode49
container/lxc/lxc.go:49: var FsCommandOutput =
(*exec.Cmd).CombinedOutput
Do you really want CombinedOutput? Just Output, I think.

https://codereview.appspot.com/73310043/diff/1/container/lxc/lxc.go#newcode52
container/lxc/lxc.go:52: cmd := exec.Command("df", "--output=fstype",
LxcContainerDir)
If you use Output instead, you can store Stderr in a bytes.Buffer and
add it to the error for context.

https://codereview.appspot.com/73310043/

« Back to merge proposal